2013-10-31 18:33:59

by Stratos Karafotis

Subject: [PATCH] cpufreq: ondemand: Remove redundant return statement

After commit dfa5bb622555d9da0df21b50f46ebdeef390041b
"cpufreq: ondemand: Change the calculation of target frequency",
this return statement is no longer needed.

Reported-by: Henrik Nilsson <[email protected]>
Signed-off-by: Stratos Karafotis <[email protected]>
---
drivers/cpufreq/cpufreq_ondemand.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/cpufreq/cpufreq_ondemand.c b/drivers/cpufreq/cpufreq_ondemand.c
index 32f26f6..18d4091 100644
--- a/drivers/cpufreq/cpufreq_ondemand.c
+++ b/drivers/cpufreq/cpufreq_ondemand.c
@@ -168,7 +168,6 @@ static void od_check_cpu(int cpu, unsigned int load)
dbs_info->rate_mult =
od_tuners->sampling_down_factor;
dbs_freq_increase(policy, policy->max);
- return;
} else {
/* Calculate the next frequency proportional to load */
unsigned int freq_next;
--
1.8.3.1

2013-10-31 18:39:21

by Viresh Kumar

Subject: Re: [PATCH] cpufreq: ondemand: Remove redundant return statement

On 31 October 2013 23:57, Stratos Karafotis <[email protected]> wrote:
> After commit dfa5bb622555d9da0df21b50f46ebdeef390041b
> "cpufreq: ondemand: Change the calculation of target frequency",
> this return statement is no longer needed.
>
> Reported-by: Henrik Nilsson <[email protected]>
> Signed-off-by: Stratos Karafotis <[email protected]>
> ---
> drivers/cpufreq/cpufreq_ondemand.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cpufreq/cpufreq_ondemand.c b/drivers/cpufreq/cpufreq_ondemand.c
> index 32f26f6..18d4091 100644
> --- a/drivers/cpufreq/cpufreq_ondemand.c
> +++ b/drivers/cpufreq/cpufreq_ondemand.c
> @@ -168,7 +168,6 @@ static void od_check_cpu(int cpu, unsigned int load)
> dbs_info->rate_mult =
> od_tuners->sampling_down_factor;
> dbs_freq_increase(policy, policy->max);
> - return;
> } else {
> /* Calculate the next frequency proportional to load */
> unsigned int freq_next;

Acked-by: Viresh Kumar <[email protected]>

2013-11-01 00:05:53

by Rafael J. Wysocki

Subject: Re: [PATCH] cpufreq: ondemand: Remove redundant return statement

On Friday, November 01, 2013 12:09:16 AM Viresh Kumar wrote:
> On 31 October 2013 23:57, Stratos Karafotis <[email protected]> wrote:
> > After commit dfa5bb622555d9da0df21b50f46ebdeef390041b
> > "cpufreq: ondemand: Change the calculation of target frequency",
> > this return statement is no longer needed.
> >
> > Reported-by: Henrik Nilsson <[email protected]>
> > Signed-off-by: Stratos Karafotis <[email protected]>
> > ---
> > drivers/cpufreq/cpufreq_ondemand.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/cpufreq_ondemand.c b/drivers/cpufreq/cpufreq_ondemand.c
> > index 32f26f6..18d4091 100644
> > --- a/drivers/cpufreq/cpufreq_ondemand.c
> > +++ b/drivers/cpufreq/cpufreq_ondemand.c
> > @@ -168,7 +168,6 @@ static void od_check_cpu(int cpu, unsigned int load)
> > dbs_info->rate_mult =
> > od_tuners->sampling_down_factor;
> > dbs_freq_increase(policy, policy->max);
> > - return;
> > } else {
> > /* Calculate the next frequency proportional to load */
> > unsigned int freq_next;
>
> Acked-by: Viresh Kumar <[email protected]>

Queued up for 3.13, thanks!

--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.