2014-01-02 20:47:15

by Tim Jester-Pfadt

Subject: [PATCH v2] Staging: rtl8188eu: Fixed coding style issues

Fixed indentation coding style issues on rtw_io.c

Signed-off-by: Tim Jester-Pfadt <[email protected]>
---
drivers/staging/rtl8188eu/core/rtw_io.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_io.c b/drivers/staging/rtl8188eu/core/rtw_io.c
index 10c9c65..6be6c50 100644
--- a/drivers/staging/rtl8188eu/core/rtw_io.c
+++ b/drivers/staging/rtl8188eu/core/rtw_io.c
@@ -205,9 +205,9 @@ void _rtw_read_mem(struct adapter *adapter, u32 addr, u32 cnt, u8 *pmem)

_func_enter_;
if (adapter->bDriverStopped || adapter->bSurpriseRemoved) {
- RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
- ("rtw_read_mem:bDriverStopped(%d) OR bSurpriseRemoved(%d)",
- adapter->bDriverStopped, adapter->bSurpriseRemoved));
+ RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
+ ("rtw_read_mem:bDriverStopped(%d) OR bSurpriseRemoved(%d)",
+ adapter->bDriverStopped, adapter->bSurpriseRemoved));
return;
}
_read_mem = pintfhdl->io_ops._read_mem;
@@ -239,9 +239,9 @@ void _rtw_read_port(struct adapter *adapter, u32 addr, u32 cnt, u8 *pmem)
_func_enter_;

if (adapter->bDriverStopped || adapter->bSurpriseRemoved) {
- RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
- ("rtw_read_port:bDriverStopped(%d) OR bSurpriseRemoved(%d)",
- adapter->bDriverStopped, adapter->bSurpriseRemoved));
+ RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
+ ("rtw_read_port:bDriverStopped(%d) OR bSurpriseRemoved(%d)",
+ adapter->bDriverStopped, adapter->bSurpriseRemoved));
return;
}

--
1.8.5.2

2014-01-02 21:37:17

by Larry Finger

Subject: Re: [PATCH v2] Staging: rtl8188eu: Fixed coding style issues

On 01/02/2014 02:46 PM, Tim Jester-Pfadt wrote:
> Fixed indentation coding style issues on rtw_io.c
>
> Signed-off-by: Tim Jester-Pfadt <[email protected]>
> ---
> drivers/staging/rtl8188eu/core/rtw_io.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_io.c b/drivers/staging/rtl8188eu/core/rtw_io.c
> index 10c9c65..6be6c50 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_io.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_io.c
> @@ -205,9 +205,9 @@ void _rtw_read_mem(struct adapter *adapter, u32 addr, u32 cnt, u8 *pmem)
>
> _func_enter_;
> if (adapter->bDriverStopped || adapter->bSurpriseRemoved) {
> - RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
> - ("rtw_read_mem:bDriverStopped(%d) OR bSurpriseRemoved(%d)",
> - adapter->bDriverStopped, adapter->bSurpriseRemoved));
> + RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
> + ("rtw_read_mem:bDriverStopped(%d) OR bSurpriseRemoved(%d)",
> + adapter->bDriverStopped, adapter->bSurpriseRemoved));

The latest version of checkpatch.pl lists the following:

CHECK: Alignment should match open parenthesis
#87: FILE: drivers/staging/rtl8188eu/core/rtw_io.c:207:
+ RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
+ ("rtw_read_mem:bDriverStopped(%d) OR bSurpriseRemoved(%d)",

The continuing lines should be indented one more space.

Larry

2014-01-02 23:23:35

by Tim Jester-Pfadt

Subject: [PATCH v3] Staging: rtl8188eu: Fixed coding style issues

Fixed indentation coding style issues on rtw_io.c

Signed-off-by: Tim Jester-Pfadt <[email protected]>
---
drivers/staging/rtl8188eu/core/rtw_io.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_io.c b/drivers/staging/rtl8188eu/core/rtw_io.c
index 10c9c65..f1b8dfe 100644
--- a/drivers/staging/rtl8188eu/core/rtw_io.c
+++ b/drivers/staging/rtl8188eu/core/rtw_io.c
@@ -205,9 +205,9 @@ void _rtw_read_mem(struct adapter *adapter, u32 addr, u32 cnt, u8 *pmem)

_func_enter_;
if (adapter->bDriverStopped || adapter->bSurpriseRemoved) {
- RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
- ("rtw_read_mem:bDriverStopped(%d) OR bSurpriseRemoved(%d)",
- adapter->bDriverStopped, adapter->bSurpriseRemoved));
+ RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
+ ("rtw_read_mem:bDriverStopped(%d) OR bSurpriseRemoved(%d)",
+ adapter->bDriverStopped, adapter->bSurpriseRemoved));
return;
}
_read_mem = pintfhdl->io_ops._read_mem;
@@ -239,9 +239,9 @@ void _rtw_read_port(struct adapter *adapter, u32 addr, u32 cnt, u8 *pmem)
_func_enter_;

if (adapter->bDriverStopped || adapter->bSurpriseRemoved) {
- RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
- ("rtw_read_port:bDriverStopped(%d) OR bSurpriseRemoved(%d)",
- adapter->bDriverStopped, adapter->bSurpriseRemoved));
+ RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
+ ("rtw_read_port:bDriverStopped(%d) OR bSurpriseRemoved(%d)",
+ adapter->bDriverStopped, adapter->bSurpriseRemoved));
return;
}

--
1.8.5.2

2014-01-02 23:33:57

by Larry Finger

Subject: Re: [PATCH v3] Staging: rtl8188eu: Fixed coding style issues

On 01/02/2014 05:22 PM, Tim Jester-Pfadt wrote:
> Fixed indentation coding style issues on rtw_io.c
>
> Signed-off-by: Tim Jester-Pfadt <[email protected]>
> ---
> drivers/staging/rtl8188eu/core/rtw_io.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_io.c b/drivers/staging/rtl8188eu/core/rtw_io.c
> index 10c9c65..f1b8dfe 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_io.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_io.c
> @@ -205,9 +205,9 @@ void _rtw_read_mem(struct adapter *adapter, u32 addr, u32 cnt, u8 *pmem)
>
> _func_enter_;
> if (adapter->bDriverStopped || adapter->bSurpriseRemoved) {
> - RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
> - ("rtw_read_mem:bDriverStopped(%d) OR bSurpriseRemoved(%d)",
> - adapter->bDriverStopped, adapter->bSurpriseRemoved));
> + RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
> + ("rtw_read_mem:bDriverStopped(%d) OR bSurpriseRemoved(%d)",
> + adapter->bDriverStopped, adapter->bSurpriseRemoved));
> return;
> }
> _read_mem = pintfhdl->io_ops._read_mem;
> @@ -239,9 +239,9 @@ void _rtw_read_port(struct adapter *adapter, u32 addr, u32 cnt, u8 *pmem)
> _func_enter_;
>
> if (adapter->bDriverStopped || adapter->bSurpriseRemoved) {
> - RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
> - ("rtw_read_port:bDriverStopped(%d) OR bSurpriseRemoved(%d)",
> - adapter->bDriverStopped, adapter->bSurpriseRemoved));
> + RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
> + ("rtw_read_port:bDriverStopped(%d) OR bSurpriseRemoved(%d)",
> + adapter->bDriverStopped, adapter->bSurpriseRemoved));
> return;
> }

Acked-by: Larry Finger <[email protected]>

Thanks,

Larry

2014-01-03 03:58:11

by Joe Perches

Subject: Re: [PATCH v3] Staging: rtl8188eu: Fixed coding style issues

On Fri, 2014-01-03 at 00:22 +0100, Tim Jester-Pfadt wrote:
> Fixed indentation coding style issues on rtw_io.c
[]
> diff --git a/drivers/staging/rtl8188eu/core/rtw_io.c b/drivers/staging/rtl8188eu/core/rtw_io.c
[]
> @@ -205,9 +205,9 @@ void _rtw_read_mem(struct adapter *adapter, u32 addr, u32 cnt, u8 *pmem)
>
> _func_enter_;
> if (adapter->bDriverStopped || adapter->bSurpriseRemoved) {
> - RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
> - ("rtw_read_mem:bDriverStopped(%d) OR bSurpriseRemoved(%d)",
> - adapter->bDriverStopped, adapter->bSurpriseRemoved));
> + RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
> + ("rtw_read_mem:bDriverStopped(%d) OR bSurpriseRemoved(%d)",
> + adapter->bDriverStopped, adapter->bSurpriseRemoved));

Be nice to remove the unnecessary parentheses on all of these too

RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
"rtw_read_mem:bDriverStopped(%d) OR bSurpriseRemoved(%d)",
adapter->bDriverStopped, adapter->bSurpriseRemoved);

etc...

A few other things too:

o The _func_enter_ uses are unnecessary and could/should
be removed. There's a standard function tracing capability.
o The RT_TRACE uses that embed a function name could/should use
%s:, __func__
o The RT_TRACE macro doesn't add a terminating newline and these
uses should have them.

RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
"%s:bDriverStopped(%d) OR bSurpriseRemoved(%d)\n",
__func__, adapter->bDriverStopped, adapter->bSurpriseRemoved);

2014-01-03 07:55:14

by Dan Carpenter

Subject: Re: [PATCH v3] Staging: rtl8188eu: Fixed coding style issues

On Fri, Jan 03, 2014 at 12:22:59AM +0100, Tim Jester-Pfadt wrote:
> Fixed indentation coding style issues on rtw_io.c
>
> Signed-off-by: Tim Jester-Pfadt <[email protected]>
> ---
Next time, if you do a v2 patch please put a note here under the ---
line what changed between the previous one and this one.

2: changed blah blah blah.

> drivers/staging/rtl8188eu/core/rtw_io.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)


regards,
dan carpenter

2014-01-03 12:09:16

by Tim Jester-Pfadt

Subject: Re: [PATCH v3] Staging: rtl8188eu: Fixed coding style issues

Thank you for your feedback.
I'm still figuring stuff out. Submitting patches to the kernel has
been my new year's resolution.

Regards,

Tim

2014/1/3 Dan Carpenter <[email protected]>:
> On Fri, Jan 03, 2014 at 12:22:59AM +0100, Tim Jester-Pfadt wrote:
>> Fixed indentation coding style issues on rtw_io.c
>>
>> Signed-off-by: Tim Jester-Pfadt <[email protected]>
>> ---
> Next time, if you do a v2 patch please put a note here under the ---
> line what changed between the previous one and this one.
>
> 2: changed blah blah blah.
>
>> drivers/staging/rtl8188eu/core/rtw_io.c | 12 ++++++------
>> 1 file changed, 6 insertions(+), 6 deletions(-)
>
>
> regards,
> dan carpenter
>