Hi Simon,
Today's linux-next merge of the renesas tree got a conflict in
arch/arm/mach-shmobile/setup-r8a7740.c between commit 0583fe478a7d ("ARM:
convert arm/arm64 arch timer to use CLKSRC_OF init") from the arm-soc
tree and commit 74d6523995cc ("ARM: shmobile: r8a7740: Prepare for
reference DT setup") from the renesas tree.
I fixed it up (see below) and can carry the fix as necessary (no action
is required).
--
Cheers,
Stephen Rothwell [email protected]
diff --cc arch/arm/mach-shmobile/setup-r8a7740.c
index 326a4ab,00c5a70..0000000
--- a/arch/arm/mach-shmobile/setup-r8a7740.c
+++ b/arch/arm/mach-shmobile/setup-r8a7740.c
@@@ -1027,9 -1016,10 +1016,9 @@@ static const char *r8a7740_boards_compa
DT_MACHINE_START(R8A7740_DT, "Generic R8A7740 (Flattened Device Tree)")
.map_io = r8a7740_map_io,
- .init_early = r8a7740_add_early_devices_dt,
- .init_irq = r8a7740_init_irq,
- .init_machine = r8a7740_add_standard_devices_dt,
+ .init_early = r8a7740_init_delay,
+ .init_irq = r8a7740_init_irq_of,
+ .init_machine = r8a7740_generic_init,
- .init_time = shmobile_timer_init,
.dt_compat = r8a7740_boards_compat_dt,
MACHINE_END
On Mon, Dec 16, 2013 at 2:00 AM, Nicolas Ferre <[email protected]> wrote:
> On 16/12/2013 00:47, Stephen Rothwell :
>> Hi Simon,
>>
>> Today's linux-next merge of the renesas tree got a conflict in
>> drivers/clk/Makefile between commit 0ad6125b1579 ("clk: at91: add PMC
>> base support") from the arm-soc tree and commit 10cdfe9f327a ("clk:
>> shmobile: Add R-Car Gen2 clocks support") from the renesas tree.
>>
>> I fixed it up (see below) and can carry the fix as necessary (no action
>> is required).
>
> Fine for me.
Simon, Nicolas,
<mini-rant>
While a very minor issue, this should have been altogether avoided
with a little more attention when applying patches. The Makefile is
sorted, and you've appended new lines to the end instead of in the
place they're supposed to go. Sure, others have done the same mistake
in a few places but that doesn't mean we shouldn't try to keep it
sorted.
The very reason _to_ sort a Makefile is to avoid these needless
add-add conflicts when two people append to the same unsorted list.
Now I can't resolve it properly and move the entries when I do the
same merge (and get the same conflict), because that will cause a
third conflict for Stephen, and he's about to return from vacation and
is going to cuss at us if we cause too many new conflicts in one day.
:)
</mini-rant>
So, best choice is to keep the unsortedness now, and have Mike resort
his Makefile for us at the end of the merge window. And keep a little
closer eye on Makefile and Kconfig additions in the future. :)
-Olof
Hi Olof,
On Fri, 3 Jan 2014 21:11:29 -0800 Olof Johansson <[email protected]> wrote:
>
> Now I can't resolve it properly and move the entries when I do the
> same merge (and get the same conflict), because that will cause a
> third conflict for Stephen, and he's about to return from vacation and
> is going to cuss at us if we cause too many new conflicts in one day.
> :)
Since I have now been made aware of the issue, you might as well just
sort it in the merge. And I have never been known to "cuss", though
ranting is a possibility :-)
--
Cheers,
Stephen Rothwell [email protected]
On Sat, Jan 04, 2014 at 10:43:46PM +1100, Stephen Rothwell wrote:
> Hi Olof,
>
> On Fri, 3 Jan 2014 21:11:29 -0800 Olof Johansson <[email protected]> wrote:
> >
> > Now I can't resolve it properly and move the entries when I do the
> > same merge (and get the same conflict), because that will cause a
> > third conflict for Stephen, and he's about to return from vacation and
> > is going to cuss at us if we cause too many new conflicts in one day.
> > :)
>
> Since I have now been made aware of the issue, you might as well just
> sort it in the merge. And I have never been known to "cuss", though
> ranting is a possibility :-)
Rant accepted. I will be more careful in future.
On 04/01/2014 06:11, Olof Johansson :
> On Mon, Dec 16, 2013 at 2:00 AM, Nicolas Ferre <[email protected]> wrote:
>> On 16/12/2013 00:47, Stephen Rothwell :
>>> Hi Simon,
>>>
>>> Today's linux-next merge of the renesas tree got a conflict in
>>> drivers/clk/Makefile between commit 0ad6125b1579 ("clk: at91: add PMC
>>> base support") from the arm-soc tree and commit 10cdfe9f327a ("clk:
>>> shmobile: Add R-Car Gen2 clocks support") from the renesas tree.
>>>
>>> I fixed it up (see below) and can carry the fix as necessary (no action
>>> is required).
>>
>> Fine for me.
>
> Simon, Nicolas,
>
> <mini-rant>
>
> While a very minor issue, this should have been altogether avoided
> with a little more attention when applying patches. The Makefile is
> sorted, and you've appended new lines to the end instead of in the
> place they're supposed to go. Sure, others have done the same mistake
> in a few places but that doesn't mean we shouldn't try to keep it
> sorted.
>
> The very reason _to_ sort a Makefile is to avoid these needless
> add-add conflicts when two people append to the same unsorted list.
>
> Now I can't resolve it properly and move the entries when I do the
> same merge (and get the same conflict), because that will cause a
> third conflict for Stephen, and he's about to return from vacation and
> is going to cuss at us if we cause too many new conflicts in one day.
> :)
>
> </mini-rant>
>
> So, best choice is to keep the unsortedness now, and have Mike resort
> his Makefile for us at the end of the merge window. And keep a little
> closer eye on Makefile and Kconfig additions in the future. :)
Totally agree in keeping a Makefile sorted, when it is already sorted.
What I recall having thought when I had seen this Makefile is: well this
one must be of the "append your changes to the end" type...
Anyway be sure that I will pay attention to this.
Bye,
--
Nicolas Ferre
Quoting Nicolas Ferre (2014-01-06 01:44:27)
> On 04/01/2014 06:11, Olof Johansson :
> > On Mon, Dec 16, 2013 at 2:00 AM, Nicolas Ferre <[email protected]> wrote:
> >> On 16/12/2013 00:47, Stephen Rothwell :
> >>> Hi Simon,
> >>>
> >>> Today's linux-next merge of the renesas tree got a conflict in
> >>> drivers/clk/Makefile between commit 0ad6125b1579 ("clk: at91: add PMC
> >>> base support") from the arm-soc tree and commit 10cdfe9f327a ("clk:
> >>> shmobile: Add R-Car Gen2 clocks support") from the renesas tree.
> >>>
> >>> I fixed it up (see below) and can carry the fix as necessary (no action
> >>> is required).
> >>
> >> Fine for me.
> >
> > Simon, Nicolas,
> >
> > <mini-rant>
> >
> > While a very minor issue, this should have been altogether avoided
> > with a little more attention when applying patches. The Makefile is
> > sorted, and you've appended new lines to the end instead of in the
> > place they're supposed to go. Sure, others have done the same mistake
> > in a few places but that doesn't mean we shouldn't try to keep it
> > sorted.
> >
> > The very reason _to_ sort a Makefile is to avoid these needless
> > add-add conflicts when two people append to the same unsorted list.
> >
> > Now I can't resolve it properly and move the entries when I do the
> > same merge (and get the same conflict), because that will cause a
> > third conflict for Stephen, and he's about to return from vacation and
> > is going to cuss at us if we cause too many new conflicts in one day.
> > :)
> >
> > </mini-rant>
> >
> > So, best choice is to keep the unsortedness now, and have Mike resort
> > his Makefile for us at the end of the merge window. And keep a little
> > closer eye on Makefile and Kconfig additions in the future. :)
>
> Totally agree in keeping a Makefile sorted, when it is already sorted.
> What I recall having thought when I had seen this Makefile is: well this
> one must be of the "append your changes to the end" type...
>
> Anyway be sure that I will pay attention to this.
The file used to be sorted. I've cleaned it up locally and will apply
the patch after I take in a few more pull requests.
Regards,
Mike
>
> Bye,
> --
> Nicolas Ferre