2014-01-07 16:24:10

by Emil Goode

[permalink] [raw]
Subject: [PATCH] ACPI: thermal: remove const from thermal_zone_device_ops declaration

The following commit introduced the requirement to not declare
thermal_zone_device_ops structs as const in order to allow
changing the .get_temp callback.

commit 4e5e4705bf69ea450f58fc709ac5888f321a9299
Author: Eduardo Valentin <[email protected]>
Date: Wed Jul 3 15:35:39 2013 -0400

thermal: introduce device tree parser

Signed-off-by: Emil Goode <[email protected]>
---
drivers/acpi/thermal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c
index 1fd21ad..8349a55 100644
--- a/drivers/acpi/thermal.c
+++ b/drivers/acpi/thermal.c
@@ -861,7 +861,7 @@ acpi_thermal_unbind_cooling_device(struct thermal_zone_device *thermal,
return acpi_thermal_cooling_device_cb(thermal, cdev, false);
}

-static const struct thermal_zone_device_ops acpi_thermal_zone_ops = {
+static struct thermal_zone_device_ops acpi_thermal_zone_ops = {
.bind = acpi_thermal_bind_cooling_device,
.unbind = acpi_thermal_unbind_cooling_device,
.get_temp = thermal_get_temp,
--
1.7.10.4


2014-01-07 23:34:38

by Eduardo Valentin

[permalink] [raw]
Subject: Re: [PATCH] ACPI: thermal: remove const from thermal_zone_device_ops declaration

On 07-01-2014 12:24, Emil Goode wrote:
> The following commit introduced the requirement to not declare
> thermal_zone_device_ops structs as const in order to allow
> changing the .get_temp callback.
>
> commit 4e5e4705bf69ea450f58fc709ac5888f321a9299
> Author: Eduardo Valentin <[email protected]>
> Date: Wed Jul 3 15:35:39 2013 -0400
>
> thermal: introduce device tree parser
>
> Signed-off-by: Emil Goode <[email protected]>

Acked-by: Eduardo Valentin <[email protected]>

> ---
> drivers/acpi/thermal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c
> index 1fd21ad..8349a55 100644
> --- a/drivers/acpi/thermal.c
> +++ b/drivers/acpi/thermal.c
> @@ -861,7 +861,7 @@ acpi_thermal_unbind_cooling_device(struct thermal_zone_device *thermal,
> return acpi_thermal_cooling_device_cb(thermal, cdev, false);
> }
>
> -static const struct thermal_zone_device_ops acpi_thermal_zone_ops = {
> +static struct thermal_zone_device_ops acpi_thermal_zone_ops = {
> .bind = acpi_thermal_bind_cooling_device,
> .unbind = acpi_thermal_unbind_cooling_device,
> .get_temp = thermal_get_temp,
>


--
You have got to be excited about what you are doing. (L. Lamport)

Eduardo Valentin


Attachments:
signature.asc (295.00 B)
OpenPGP digital signature

2014-01-08 22:54:07

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [PATCH] ACPI: thermal: remove const from thermal_zone_device_ops declaration

On Tuesday, January 07, 2014 07:34:03 PM Eduardo Valentin wrote:
>
> --d38TXoq0sN4NKSKSmrSA0nrfhHhs3Hefk
> Content-Type: text/plain; charset=ISO-8859-1
> Content-Transfer-Encoding: quoted-printable
>
> On 07-01-2014 12:24, Emil Goode wrote:
> > The following commit introduced the requirement to not declare
> > thermal_zone_device_ops structs as const in order to allow
> > changing the .get_temp callback.
> >=20
> > commit 4e5e4705bf69ea450f58fc709ac5888f321a9299
> > Author: Eduardo Valentin <[email protected]>
> > Date: Wed Jul 3 15:35:39 2013 -0400
> >=20
> > thermal: introduce device tree parser
> >=20
> > Signed-off-by: Emil Goode <[email protected]>
>
> Acked-by: Eduardo Valentin <[email protected]>

Queued up for 3.14, thanks!

> > ---
> > drivers/acpi/thermal.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >=20
> > diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c
> > index 1fd21ad..8349a55 100644
> > --- a/drivers/acpi/thermal.c
> > +++ b/drivers/acpi/thermal.c
> > @@ -861,7 +861,7 @@ acpi_thermal_unbind_cooling_device(struct thermal_z=
> one_device *thermal,
> > return acpi_thermal_cooling_device_cb(thermal, cdev, false);
> > }
> > =20
> > -static const struct thermal_zone_device_ops acpi_thermal_zone_ops =3D =
> {
> > +static struct thermal_zone_device_ops acpi_thermal_zone_ops =3D {
> > .bind =3D acpi_thermal_bind_cooling_device,
> > .unbind =3D acpi_thermal_unbind_cooling_device,
> > .get_temp =3D thermal_get_temp,
> >=20
>
>
> --=20
> You have got to be excited about what you are doing. (L. Lamport)
>
> Eduardo Valentin
>
>
> --d38TXoq0sN4NKSKSmrSA0nrfhHhs3Hefk
> Content-Type: application/pgp-signature; name="signature.asc"
> Content-Description: OpenPGP digital signature
> Content-Disposition: attachment; filename="signature.asc"
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.12 (GNU/Linux)
> Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
>
> iF4EAREIAAYFAlLMjvIACgkQCXcVR3XQvP3L6gD7B2J7f2SUQuZhpShZH/GNtjUm
> 66MHYjXagUB6rDRkCAQA/3/Hh35+smtAZvxKm/IX45BOmyC/z3qMulmA6Alsy52I
> =Cuu1
> -----END PGP SIGNATURE-----
>
> --d38TXoq0sN4NKSKSmrSA0nrfhHhs3Hefk--
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>

--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.