2014-01-08 02:54:16

by Ding Tianhong

[permalink] [raw]

Subject: [PATCH v3.6 06/19] batman-adv: use batadv_compare_eth for concise

---

It is better to use batadv_compate_eth instead of memcpy for
concise style.

Cc: Marek Lindner <[email protected]>
Cc: Simon Wunderlich <[email protected]>
Cc: Antonio Quartulli <[email protected]>
Cc: "David S. Miller" <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Signed-off-by: Tan Xiaojun <[email protected]>
Signed-off-by: Ding Tianhong <[email protected]>
Acked-by: Antonio Quartulli <[email protected]>
---
net/batman-adv/originator.c | 2 +-
net/batman-adv/translation-table.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/batman-adv/originator.c b/net/batman-adv/originator.c
index 8ab1434..803ab4b 100644
--- a/net/batman-adv/originator.c
+++ b/net/batman-adv/originator.c
@@ -41,7 +41,7 @@ int batadv_compare_orig(const struct hlist_node *node, const void *data2)
const void *data1 = container_of(node, struct batadv_orig_node,
hash_entry);

- return (memcmp(data1, data2, ETH_ALEN) == 0 ? 1 : 0);
+ return batadv_compare_eth(data1, data2);
}

/**
diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c
index 4add57d..06506e6 100644
--- a/net/batman-adv/translation-table.c
+++ b/net/batman-adv/translation-table.c
@@ -51,7 +51,7 @@ static int batadv_compare_tt(const struct hlist_node *node, const void *data2)
const void *data1 = container_of(node, struct batadv_tt_common_entry,
hash_entry);

- return (memcmp(data1, data2, ETH_ALEN) == 0 ? 1 : 0);
+ return batadv_compare_eth(data1, data2);
}

/**
--
1.8.0

2014-01-08 07:08:09

by Antonio Quartulli

[permalink] [raw]

Subject: Re: [B.A.T.M.A.N.] [PATCH v3.6 06/19] batman-adv: use batadv_compare_eth for concise

---

On 08/01/14 03:53, Ding Tianhong wrote:
> It is better to use batadv_compate_eth instead of memcpy for
> concise style.
>
> Cc: Marek Lindner <[email protected]>
> Cc: Simon Wunderlich <[email protected]>
> Cc: Antonio Quartulli <[email protected]>
> Cc: "David S. Miller" <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Signed-off-by: Tan Xiaojun <[email protected]>
> Signed-off-by: Ding Tianhong <[email protected]>
> Acked-by: Antonio Quartulli <[email protected]>

Am I wrong or this patch has already been merged in net-next (together
with other patches from this series)?



Regards,


--
Antonio Quartulli

---

Attachments:

signature.asc (836.00 B)
OpenPGP digital signature

2014-01-08 07:32:49

by Ding Tianhong

[permalink] [raw]

Subject: Re: [B.A.T.M.A.N.] [PATCH v3.6 06/19] batman-adv: use batadv_compare_eth for concise

---

On 2014/1/8 15:06, Antonio Quartulli wrote:
> On 08/01/14 03:53, Ding Tianhong wrote:
>> It is better to use batadv_compate_eth instead of memcpy for
>> concise style.
>>
>> Cc: Marek Lindner <[email protected]>
>> Cc: Simon Wunderlich <[email protected]>
>> Cc: Antonio Quartulli <[email protected]>
>> Cc: "David S. Miller" <[email protected]>
>> Cc: [email protected]
>> Cc: [email protected]
>> Cc: [email protected]
>> Signed-off-by: Tan Xiaojun <[email protected]>
>> Signed-off-by: Ding Tianhong <[email protected]>
>> Acked-by: Antonio Quartulli <[email protected]>
>
> Am I wrong or this patch has already been merged in net-next (together
> with other patches from this series)?
>
>
>
> Regards,
>
>
Yes， it is already in net-next, so miss it, thanks.

Regards
Ding