2014-01-10 07:25:23

by Francis Moreau

[permalink] [raw]
Subject: Re: 3.12: kernel panic when resuming from suspend to RAM (x86_64)

Hi.

On 12/10/2013 09:29 AM, Samuel Ortiz wrote:
> Hi Micky,
>
> On Tue, Dec 10, 2013 at 09:56:48AM +0800, micky wrote:
>> Hi Francis:
>> On 12/10/2013 09:39 AM, wwang wrote:
>>> which is based on Thomas' patch.
>>
>> Can you help us test this patch, we disable irq while suspend here.
> I already pushed a patch from Thomas to mfd-fixes that seems to fix the
> resume breakage:
>
> https://git.kernel.org/cgit/linux/kernel/git/sameo/mfd-fixes.git/commit/?id=19e49e445e198197c5e243f92d333d076e23d032
>

I still can see any traces of this fix in Linus' tree.

Shouldn't this get merged before 3.13 is out ?

Thanks


2014-01-10 09:16:18

by 敬锐

[permalink] [raw]
Subject: Re: 3.12: kernel panic when resuming from suspend to RAM (x86_64)

Hi,
On 01/10/2014 03:26 PM, Francis Moreau wrote:
> I still can see any traces of this fix in Linus' tree.
>
> Shouldn't this get merged before 3.13 is out ?
>
> Thanks
Good, I think it is good to merge. Thanks.

Best Regards.
micky.

2014-01-10 09:52:16

by Samuel Ortiz

[permalink] [raw]
Subject: Re: 3.12: kernel panic when resuming from suspend to RAM (x86_64)

Hi Francis,

On Fri, Jan 10, 2014 at 08:26:13AM +0100, Francis Moreau wrote:
> Hi.
>
> On 12/10/2013 09:29 AM, Samuel Ortiz wrote:
> > Hi Micky,
> >
> > On Tue, Dec 10, 2013 at 09:56:48AM +0800, micky wrote:
> >> Hi Francis:
> >> On 12/10/2013 09:39 AM, wwang wrote:
> >>> which is based on Thomas' patch.
> >>
> >> Can you help us test this patch, we disable irq while suspend here.
> > I already pushed a patch from Thomas to mfd-fixes that seems to fix the
> > resume breakage:
> >
> > https://git.kernel.org/cgit/linux/kernel/git/sameo/mfd-fixes.git/commit/?id=19e49e445e198197c5e243f92d333d076e23d032
> >
>
> I still can see any traces of this fix in Linus' tree.
>
> Shouldn't this get merged before 3.13 is out ?
Yes, it should. I just sent a pull request to Linus for that.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/

2014-01-10 10:07:00

by Francis Moreau

[permalink] [raw]
Subject: Re: 3.12: kernel panic when resuming from suspend to RAM (x86_64)

On 01/10/2014 10:52 AM, Samuel Ortiz wrote:
> Hi Francis,
>
> On Fri, Jan 10, 2014 at 08:26:13AM +0100, Francis Moreau wrote:
>> Hi.
>>
>> On 12/10/2013 09:29 AM, Samuel Ortiz wrote:
>>> Hi Micky,
>>>
>>> On Tue, Dec 10, 2013 at 09:56:48AM +0800, micky wrote:
>>>> Hi Francis:
>>>> On 12/10/2013 09:39 AM, wwang wrote:
>>>>> which is based on Thomas' patch.
>>>>
>>>> Can you help us test this patch, we disable irq while suspend here.
>>> I already pushed a patch from Thomas to mfd-fixes that seems to fix the
>>> resume breakage:
>>>
>>> https://git.kernel.org/cgit/linux/kernel/git/sameo/mfd-fixes.git/commit/?id=19e49e445e198197c5e243f92d333d076e23d032
>>>
>>
>> I still can see any traces of this fix in Linus' tree.
>>
>> Shouldn't this get merged before 3.13 is out ?
> Yes, it should. I just sent a pull request to Linus for that.

Thanks, you might consider to send this to the 3.12 stable tree as well.