2014-01-16 22:45:26

by Linus Walleij

Subject: [PATCH] pinctrl: capri: add dependency on OF

As this driver is using pinconf_generic_dt_node_to_map_pin() it
needs to depend on OF so as not to cause build problems on
archs that do not support OF.

Cc: Sherman Yin <[email protected]>
Signed-off-by: Linus Walleij <[email protected]>
---
drivers/pinctrl/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index f1dda4d9de13..be361b7cd30f 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -106,6 +106,7 @@ config PINCTRL_BCM2835

config PINCTRL_CAPRI
bool "Broadcom Capri pinctrl driver"
+ depends on OF
select PINMUX
select PINCONF
select GENERIC_PINCONF
--
1.8.4.2

2014-01-17 19:52:08

by Sherman Yin

Subject: Re: [PATCH] pinctrl: capri: add dependency on OF

On 14-01-16 02:45 PM, Linus Walleij wrote:
> As this driver is using pinconf_generic_dt_node_to_map_pin() it
> needs to depend on OF so as not to cause build problems on
> archs that do not support OF.
>
> Cc: Sherman Yin <[email protected]>
> Signed-off-by: Linus Walleij <[email protected]>
> ---
> drivers/pinctrl/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index f1dda4d9de13..be361b7cd30f 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -106,6 +106,7 @@ config PINCTRL_BCM2835
>
> config PINCTRL_CAPRI
> bool "Broadcom Capri pinctrl driver"
> + depends on OF
> select PINMUX
> select PINCONF
> select GENERIC_PINCONF
>

Thanks for the fix, Linus. While we're visiting this config, should we
add "depends on MACH_BCM_MOBILE" as well?

Thanks,
Sherman

2014-01-17 23:12:40

by Linus Walleij

Subject: Re: [PATCH] pinctrl: capri: add dependency on OF

On Fri, Jan 17, 2014 at 8:51 PM, Sherman Yin <[email protected]> wrote:

> Thanks for the fix, Linus. While we're visiting this config, should we add
> "depends on MACH_BCM_MOBILE" as well?

No, it's nice to get the compile coverage.

Yours,
Linus Walleij

2014-01-17 23:13:32

by Linus Walleij

Subject: Re: [PATCH] pinctrl: capri: add dependency on OF

On Sat, Jan 18, 2014 at 12:12 AM, Linus Walleij
<[email protected]> wrote:
> On Fri, Jan 17, 2014 at 8:51 PM, Sherman Yin <[email protected]> wrote:
>
>> Thanks for the fix, Linus. While we're visiting this config, should we add
>> "depends on MACH_BCM_MOBILE" as well?
>
> No, it's nice to get the compile coverage.

But maybe you can experiment with that special option that only
turns on the driver on other platforms to do compile test.

Yours,
Linus Walleij

2014-01-17 23:27:30

by Stephen Warren

Subject: Re: [PATCH] pinctrl: capri: add dependency on OF

On 01/17/2014 04:13 PM, Linus Walleij wrote:
> On Sat, Jan 18, 2014 at 12:12 AM, Linus Walleij
> <[email protected]> wrote:
>> On Fri, Jan 17, 2014 at 8:51 PM, Sherman Yin <[email protected]> wrote:
>>
>>> Thanks for the fix, Linus. While we're visiting this config, should we add
>>> "depends on MACH_BCM_MOBILE" as well?
>>
>> No, it's nice to get the compile coverage.
>
> But maybe you can experiment with that special option that only
> turns on the driver on other platforms to do compile test.

a/k/a
depends on XXX || COMPILE_TEST

2014-01-20 08:17:25

by Linus Walleij

Subject: Re: [PATCH] pinctrl: capri: add dependency on OF

On Sat, Jan 18, 2014 at 12:27 AM, Stephen Warren <[email protected]> wrote:
> On 01/17/2014 04:13 PM, Linus Walleij wrote:
>> On Sat, Jan 18, 2014 at 12:12 AM, Linus Walleij
>> <[email protected]> wrote:
>>> On Fri, Jan 17, 2014 at 8:51 PM, Sherman Yin <[email protected]> wrote:
>>>
>>>> Thanks for the fix, Linus. While we're visiting this config, should we add
>>>> "depends on MACH_BCM_MOBILE" as well?
>>>
>>> No, it's nice to get the compile coverage.
>>
>> But maybe you can experiment with that special option that only
>> turns on the driver on other platforms to do compile test.
>
> a/k/a
> depends on XXX || COMPILE_TEST

Yep, thanks Stephen :-)

Linus Walleij