2014-02-13 02:03:08

by Daeseok Youn

Subject: [PATCH] kernel/resource.c: fix sparse non static symbol warning

>From f8e0752ac80e56bcbfe197a5820692d199822b52 Mon Sep 17 00:00:00 2001
From: Daeseok Youn <[email protected]>
Date: Thu, 13 Feb 2014 10:11:39 +0900
Subject: [PATCH] kernel/resource.c: fix sparse non static symbol warning

kernel/resource.c:518:5: warning:
symbol 'reallocate_resource' was not declared. Should it be static?

Signed-off-by: Daeseok Youn <[email protected]>
---
kernel/resource.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/resource.c b/kernel/resource.c
index 3f285dc..b2979c6 100644
--- a/kernel/resource.c
+++ b/kernel/resource.c
@@ -515,7 +515,7 @@ static int find_resource(struct resource *root, struct resource *new,
* @newsize: new size of the resource descriptor
* @constraint: the size and alignment constraints to be met.
*/
-int reallocate_resource(struct resource *root, struct resource *old,
+static int reallocate_resource(struct resource *root, struct resource *old,
resource_size_t newsize,
struct resource_constraint *constraint)
{
--
1.7.9.5

2014-02-13 02:28:45

by David Rientjes

Subject: Re: [PATCH] kernel/resource.c: fix sparse non static symbol warning

On Thu, 13 Feb 2014, Daeseok Youn wrote:

> From f8e0752ac80e56bcbfe197a5820692d199822b52 Mon Sep 17 00:00:00 2001
> From: Daeseok Youn <[email protected]>
> Date: Thu, 13 Feb 2014 10:11:39 +0900
> Subject: [PATCH] kernel/resource.c: fix sparse non static symbol warning
>
> kernel/resource.c:518:5: warning:
> symbol 'reallocate_resource' was not declared. Should it be static?
>
> Signed-off-by: Daeseok Youn <[email protected]>

Changelog would be better if it said it's only referenced in file scope so
it can be marked static.

Acked-by: David Rientjes <[email protected]>

2014-02-13 06:20:43

by Daeseok Youn

Subject: Re: [PATCH] kernel/resource.c: fix sparse non static symbol warning

OK. If I send a patch like this again, ChangeLog is written as you comment.

Thanks.
Daeseok Youn.


2014-02-13 11:28 GMT+09:00 David Rientjes <[email protected]>:
> On Thu, 13 Feb 2014, Daeseok Youn wrote:
>
>> From f8e0752ac80e56bcbfe197a5820692d199822b52 Mon Sep 17 00:00:00 2001
>> From: Daeseok Youn <[email protected]>
>> Date: Thu, 13 Feb 2014 10:11:39 +0900
>> Subject: [PATCH] kernel/resource.c: fix sparse non static symbol warning
>>
>> kernel/resource.c:518:5: warning:
>> symbol 'reallocate_resource' was not declared. Should it be static?
>>
>> Signed-off-by: Daeseok Youn <[email protected]>
>
> Changelog would be better if it said it's only referenced in file scope so
> it can be marked static.
>
> Acked-by: David Rientjes <[email protected]>

2014-02-13 23:29:24

by Yasuaki Ishimatsu

Subject: Re: [PATCH] kernel/resource.c: fix sparse non static symbol warning

(2014/02/13 11:02), Daeseok Youn wrote:
> From f8e0752ac80e56bcbfe197a5820692d199822b52 Mon Sep 17 00:00:00 2001
> From: Daeseok Youn <[email protected]>
> Date: Thu, 13 Feb 2014 10:11:39 +0900
> Subject: [PATCH] kernel/resource.c: fix sparse non static symbol warning
>
> kernel/resource.c:518:5: warning:
> symbol 'reallocate_resource' was not declared. Should it be static?
>
> Signed-off-by: Daeseok Youn <[email protected]>
> ---

Reviewed-by: Yasuaki Ishimatsu <[email protected]>

Thanks,
Yasuaki Ishimatsu


> kernel/resource.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/resource.c b/kernel/resource.c
> index 3f285dc..b2979c6 100644
> --- a/kernel/resource.c
> +++ b/kernel/resource.c
> @@ -515,7 +515,7 @@ static int find_resource(struct resource *root, struct resource *new,
> * @newsize: new size of the resource descriptor
> * @constraint: the size and alignment constraints to be met.
> */
> -int reallocate_resource(struct resource *root, struct resource *old,
> +static int reallocate_resource(struct resource *root, struct resource *old,
> resource_size_t newsize,
> struct resource_constraint *constraint)
> {
>