2005-10-29 05:46:06

by Al Viro

Subject: [PATCH] missing include in infiniband

use of IS_ERR/PTR_ERR in infiniband/core/agent.c, without
a portable chain of includes pulling err.h (breaks on a bunch of
platforms).
Signed-off-by: Al Viro <[email protected]>
----
diff -urN RC14-base/drivers/infiniband/core/agent.h current/drivers/infiniband/core/agent.h
--- RC14-base/drivers/infiniband/core/agent.h 2005-10-28 22:35:58.000000000 -0400
+++ current/drivers/infiniband/core/agent.h 2005-10-29 01:25:34.000000000 -0400
@@ -39,6 +39,7 @@
#ifndef __AGENT_H_
#define __AGENT_H_

+#include <linux/err.h>
#include <rdma/ib_mad.h>

extern int ib_agent_port_open(struct ib_device *device, int port_num);

2005-10-29 14:08:34

by Roland Dreier

Subject: Re: [PATCH] missing include in infiniband

> use of IS_ERR/PTR_ERR in infiniband/core/agent.c, without
> a portable chain of includes pulling err.h (breaks on a bunch of
> platforms).
> Signed-off-by: Al Viro <[email protected]>

Looks good to me:

Acked-by: Roland Dreier <[email protected]>

I guess I still need to a few more cross-compilers to me collection --
none of i386, x86_64, ppc64, ia64, sparc64 or ppc caught this :(.

- R.