2017-11-06 12:37:04

by Egil Hjelmeland

[permalink] [raw]
Subject: Re: [PATCH net-next 4/5] net: dsa: lan9303: Remove unnecessary parentheses

On 03. nov. 2017 15:54, Vivien Didelot wrote:
> Hi Egil,
>
> Egil Hjelmeland <[email protected]> writes:
>
> If you send a v2, you may want to address the other parenthesis
> alignment issues found when running ./scripts/checkpatch -f on the
> lan9303* files.
>

There is just one remaining alignment issue. Removing that would
require introducing an extra variable just for that purpose. I
don't think that makes the code more readable. So I will not do it.
If anybody else want to do it, fine, I will just watch in silence.

> Applying this gives you a few more: https://patchwork.kernel.org/patch/10014913/
>
> (you can also add my Reviewed-by tag on patches you didn't touch.)
>
>
> Thanks,
>
> Vivien
>

Egil

From 1583310431912725164@xxx Mon Nov 06 10:01:33 +0000 2017
X-GM-THRID: 1583042314863571680
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread