2014-01-08 13:03:27

by Kusanagi Kouichi

[permalink] [raw]
Subject: [PATCH] trace-cmd: Fix out-of-tree build

make O=foo fails with following error:

.../Makefile:221: features.mk: No such file or directory
make[1]: *** No rule to make target `features.mk'. Stop.
make: *** [sub-make] Error 2

Signed-off-by: Kusanagi Kouichi <[email protected]>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 0578546..b967019 100644
--- a/Makefile
+++ b/Makefile
@@ -218,7 +218,7 @@ KERNELSHARK_VERSION = $(KS_VERSION).$(KS_PATCHLEVEL).$(KS_EXTRAVERSION)

INCLUDES = -I. $(CONFIG_INCLUDES)

-include features.mk
+include $(src)/features.mk

# Set compile option CFLAGS if not set elsewhere
CFLAGS ?= -g -Wall
--
1.8.5.2


2014-01-08 14:04:00

by Steven Rostedt

[permalink] [raw]
Subject: Re: [PATCH] trace-cmd: Fix out-of-tree build

On Wed, 8 Jan 2014 22:03:22 +0900
Kusanagi Kouichi <[email protected]> wrote:

> make O=foo fails with following error:
>
> .../Makefile:221: features.mk: No such file or directory
> make[1]: *** No rule to make target `features.mk'. Stop.
> make: *** [sub-make] Error 2
>
> Signed-off-by: Kusanagi Kouichi <[email protected]>

Thanks! Applied and pushed.

-- Steve

> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 0578546..b967019 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -218,7 +218,7 @@ KERNELSHARK_VERSION = $(KS_VERSION).$(KS_PATCHLEVEL).$(KS_EXTRAVERSION)
>
> INCLUDES = -I. $(CONFIG_INCLUDES)
>
> -include features.mk
> +include $(src)/features.mk
>
> # Set compile option CFLAGS if not set elsewhere
> CFLAGS ?= -g -Wall