2022-09-08 13:27:03

by wangjianli

Subject: [PATCH] media/i2c: fix repeated words in comments

Delete the redundant word 'in'.

Signed-off-by: wangjianli <[email protected]>
---
drivers/media/i2c/adv7175.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/i2c/adv7175.c b/drivers/media/i2c/adv7175.c
index b58689728243..bc8f8bbedb45 100644
--- a/drivers/media/i2c/adv7175.c
+++ b/drivers/media/i2c/adv7175.c
@@ -209,7 +209,7 @@ static int adv7175_s_std_output(struct v4l2_subdev *sd, v4l2_std_id std)
/* This is an attempt to convert
* SECAM->PAL (typically it does not work
* due to genlock: when decoder is in SECAM
- * and encoder in in PAL the subcarrier can
+ * and encoder in PAL the subcarrier can
* not be synchronized with horizontal
* quency) */
adv7175_write_block(sd, init_pal, sizeof(init_pal));
--
2.36.1

2022-09-08 14:13:59

by Randy Dunlap

Subject: Re: [PATCH] media/i2c: fix repeated words in comments

On 9/8/22 05:30, wangjianli wrote:
> Delete the redundant word 'in'.
>
> Signed-off-by: wangjianli <[email protected]>
> ---
> drivers/media/i2c/adv7175.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/adv7175.c b/drivers/media/i2c/adv7175.c
> index b58689728243..bc8f8bbedb45 100644
> --- a/drivers/media/i2c/adv7175.c
> +++ b/drivers/media/i2c/adv7175.c
> @@ -209,7 +209,7 @@ static int adv7175_s_std_output(struct v4l2_subdev *sd, v4l2_std_id std)
> /* This is an attempt to convert
> * SECAM->PAL (typically it does not work
> * due to genlock: when decoder is in SECAM
> - * and encoder in in PAL the subcarrier can

is in

> + * and encoder in PAL the subcarrier can
> * not be synchronized with horizontal
> * quency) */
> adv7175_write_block(sd, init_pal, sizeof(init_pal));

--
~Randy

2022-11-28 09:08:37

by Hans Verkuil

Subject: Re: [PATCH] media/i2c: fix repeated words in comments

On 08/09/2022 14:30, wangjianli wrote:
> Delete the redundant word 'in'.
>
> Signed-off-by: wangjianli <[email protected]>
> ---
> drivers/media/i2c/adv7175.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/adv7175.c b/drivers/media/i2c/adv7175.c
> index b58689728243..bc8f8bbedb45 100644
> --- a/drivers/media/i2c/adv7175.c
> +++ b/drivers/media/i2c/adv7175.c
> @@ -209,7 +209,7 @@ static int adv7175_s_std_output(struct v4l2_subdev *sd, v4l2_std_id std)
> /* This is an attempt to convert
> * SECAM->PAL (typically it does not work
> * due to genlock: when decoder is in SECAM
> - * and encoder in in PAL the subcarrier can
> + * and encoder in PAL the subcarrier can

As Randy said, this should be: is in

> * not be synchronized with horizontal
> * quency) */

And while at it, let's replace 'quency' with 'frequency'.

> adv7175_write_block(sd, init_pal, sizeof(init_pal));

And PLEASE add the driver name to the subject line.

If it starts with 'media/i2c' then that suggests the patch changes
multiple files in that directory. With 'media: i2c: adv7175:' I
know it is just for that driver.

Regards,

Hans