2014-02-21 01:10:36

by Daeseok Youn

[permalink] [raw]
Subject: [PATCH] [SCSI] lpfc 8.3.43: use NULL instead of 0 for pointer

>From 9e7478f6e953fac5b2bef0f5abe76fe8dc9e59d1 Mon Sep 17 00:00:00 2001
From: Daeseok Youn <[email protected]>
Date: Fri, 21 Feb 2014 09:03:32 +0900
Subject: [PATCH] [SCSI] lpfc 8.3.43: use NULL instead of 0 for pointer

sparse says:
drivers/scsi/lpfc/lpfc_sli.c:16547:37: warning:
Using plain integer as NULL pointer

Signed-off-by: Daeseok Youn <[email protected]>
---
drivers/scsi/lpfc/lpfc_sli.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
index 8f580fd..a218ecd 100644
--- a/drivers/scsi/lpfc/lpfc_sli.c
+++ b/drivers/scsi/lpfc/lpfc_sli.c
@@ -16544,7 +16544,7 @@ lpfc_drain_txq(struct lpfc_hba *phba)
{
LIST_HEAD(completions);
struct lpfc_sli_ring *pring = &phba->sli.ring[LPFC_ELS_RING];
- struct lpfc_iocbq *piocbq = 0;
+ struct lpfc_iocbq *piocbq = NULL;
unsigned long iflags = 0;
char *fail_msg = NULL;
struct lpfc_sglq *sglq;
--
1.7.9.5

---


2014-02-24 17:37:54

by James Smart

[permalink] [raw]
Subject: Re: [PATCH] [SCSI] lpfc 8.3.43: use NULL instead of 0 for pointer

Acked-by: James Smart <[email protected]>

-- james s



On 2/20/2014 8:10 PM, Daeseok Youn wrote:
> >From 9e7478f6e953fac5b2bef0f5abe76fe8dc9e59d1 Mon Sep 17 00:00:00 2001
> From: Daeseok Youn <[email protected]>
> Date: Fri, 21 Feb 2014 09:03:32 +0900
> Subject: [PATCH] [SCSI] lpfc 8.3.43: use NULL instead of 0 for pointer
>
> sparse says:
> drivers/scsi/lpfc/lpfc_sli.c:16547:37: warning:
> Using plain integer as NULL pointer
>
> Signed-off-by: Daeseok Youn <[email protected]>
> ---
> drivers/scsi/lpfc/lpfc_sli.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
> index 8f580fd..a218ecd 100644
> --- a/drivers/scsi/lpfc/lpfc_sli.c
> +++ b/drivers/scsi/lpfc/lpfc_sli.c
> @@ -16544,7 +16544,7 @@ lpfc_drain_txq(struct lpfc_hba *phba)
> {
> LIST_HEAD(completions);
> struct lpfc_sli_ring *pring = &phba->sli.ring[LPFC_ELS_RING];
> - struct lpfc_iocbq *piocbq = 0;
> + struct lpfc_iocbq *piocbq = NULL;
> unsigned long iflags = 0;
> char *fail_msg = NULL;
> struct lpfc_sglq *sglq;