2014-02-23 01:19:36

by Satoru Takeuchi

Subject: [PATCH] ktest: Set CLOSE_CONSOLE_SIGNAL in the kvm.conf

From: Satoru Takeuchi <[email protected]>

As mentioned at commit 5a5d8e48449, we can't terminate 'virsh console'
with the default signal(INT). So it's better to set CLOSE_CONSOLE_SIGNAL
in the kvm.conf.

Signed-off-by: Satoru Takeuchi <[email protected]>
Cc: Steven Rostedt <[email protected]>
---
tools/testing/ktest/examples/kvm.conf | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/tools/testing/ktest/examples/kvm.conf b/tools/testing/ktest/examples/kvm.conf
index 831c7c5..40356f7 100644
--- a/tools/testing/ktest/examples/kvm.conf
+++ b/tools/testing/ktest/examples/kvm.conf
@@ -10,6 +10,10 @@ MACHINE = Guest
# Use virsh to read the serial console of the guest
CONSOLE = virsh console ${MACHINE}

+# Use SIGILL to terminate virsh console. We can't kill virsh console
+# by the default signal, SIGINT.
+CLOSE_CONSOLE_SIGNAL = KILL
+
#*************************************#
# This part is the same as test.conf #
#*************************************#
--
1.8.4.2

2014-02-24 14:30:43

by Steven Rostedt

Subject: Re: [PATCH] ktest: Set CLOSE_CONSOLE_SIGNAL in the kvm.conf

On Sun, 23 Feb 2014 10:19:28 +0900
Satoru Takeuchi <[email protected]> wrote:

> From: Satoru Takeuchi <[email protected]>
>
> As mentioned at commit 5a5d8e48449, we can't terminate 'virsh console'
> with the default signal(INT). So it's better to set CLOSE_CONSOLE_SIGNAL
> in the kvm.conf.
>
> Signed-off-by: Satoru Takeuchi <[email protected]>
> Cc: Steven Rostedt <[email protected]>
> ---
> tools/testing/ktest/examples/kvm.conf | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tools/testing/ktest/examples/kvm.conf b/tools/testing/ktest/examples/kvm.conf
> index 831c7c5..40356f7 100644
> --- a/tools/testing/ktest/examples/kvm.conf
> +++ b/tools/testing/ktest/examples/kvm.conf
> @@ -10,6 +10,10 @@ MACHINE = Guest
> # Use virsh to read the serial console of the guest
> CONSOLE = virsh console ${MACHINE}
>
> +# Use SIGILL to terminate virsh console. We can't kill virsh console
> +# by the default signal, SIGINT.
> +CLOSE_CONSOLE_SIGNAL = KILL
> +

Thanks, I'll add this to my 3.15 queue.

-- Steve

> #*************************************#
> # This part is the same as test.conf #
> #*************************************#

2014-02-26 02:21:25

by MUNEDA Takahiro

Subject: Re: [PATCH] ktest: Set CLOSE_CONSOLE_SIGNAL in the kvm.conf

On Mon, 24 Feb 2014 09:30:39 -0500,
Steven Rostedt <[email protected]> wrote:

> On Sun, 23 Feb 2014 10:19:28 +0900
> Satoru Takeuchi <[email protected]> wrote:
>
>> From: Satoru Takeuchi <[email protected]>
>>
>> As mentioned at commit 5a5d8e48449, we can't terminate 'virsh console'
>> with the default signal(INT). So it's better to set CLOSE_CONSOLE_SIGNAL
>> in the kvm.conf.
>>
>> Signed-off-by: Satoru Takeuchi <[email protected]>
>> Cc: Steven Rostedt <[email protected]>
>> ---
>> tools/testing/ktest/examples/kvm.conf | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/tools/testing/ktest/examples/kvm.conf b/tools/testing/ktest/examples/kvm.conf
>> index 831c7c5..40356f7 100644
>> --- a/tools/testing/ktest/examples/kvm.conf
>> +++ b/tools/testing/ktest/examples/kvm.conf
>> @@ -10,6 +10,10 @@ MACHINE = Guest
>> # Use virsh to read the serial console of the guest
>> CONSOLE = virsh console ${MACHINE}
>>
>> +# Use SIGILL to terminate virsh console. We can't kill virsh console
>> +# by the default signal, SIGINT.
>> +CLOSE_CONSOLE_SIGNAL = KILL
>> +
>
> Thanks, I'll add this to my 3.15 queue.

Hmm, it seems that we need a following patch as well.
Or, please merge with the orignal patch.

Thanks,
Takahiro

======================================================================
From a1c7b948c47a6ea7b74225bf5698fdfb7199726a Mon Sep 17 00:00:00 2001
From: MUNEDA Takahiro <[email protected]>
Date: Tue, 25 Feb 2014 15:32:35 -0500
Subject: [PATCH] ktest: Fixes a trivial typo

Signed-off-by: MUNEDA Takahiro <[email protected]>
Cc: Satoru Takeuchi <[email protected]>
Cc: Steven Rostedt <[email protected]>

---
tools/testing/ktest/examples/kvm.conf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/ktest/examples/kvm.conf b/tools/testing/ktest/examples/kvm.conf
index 40356f7..fbc134f 100644
--- a/tools/testing/ktest/examples/kvm.conf
+++ b/tools/testing/ktest/examples/kvm.conf
@@ -10,7 +10,7 @@ MACHINE = Guest
# Use virsh to read the serial console of the guest
CONSOLE = virsh console ${MACHINE}

-# Use SIGILL to terminate virsh console. We can't kill virsh console
+# Use SIGKILL to terminate virsh console. We can't kill virsh console
# by the default signal, SIGINT.
CLOSE_CONSOLE_SIGNAL = KILL

--
1.8.3.1

2014-02-26 11:43:27

by Satoru Takeuchi

Subject: Re: [PATCH] ktest: Set CLOSE_CONSOLE_SIGNAL in the kvm.conf

At Tue, 25 Feb 2014 21:21:18 -0500,
MUNEDA Takahiro wrote:
>
> On Mon, 24 Feb 2014 09:30:39 -0500,
> Steven Rostedt <[email protected]> wrote:
>
> > On Sun, 23 Feb 2014 10:19:28 +0900
> > Satoru Takeuchi <[email protected]> wrote:
> >
> >> From: Satoru Takeuchi <[email protected]>
> >>
> >> As mentioned at commit 5a5d8e48449, we can't terminate 'virsh console'
> >> with the default signal(INT). So it's better to set CLOSE_CONSOLE_SIGNAL
> >> in the kvm.conf.
> >>
> >> Signed-off-by: Satoru Takeuchi <[email protected]>
> >> Cc: Steven Rostedt <[email protected]>
> >> ---
> >> tools/testing/ktest/examples/kvm.conf | 4 ++++
> >> 1 file changed, 4 insertions(+)
> >>
> >> diff --git a/tools/testing/ktest/examples/kvm.conf b/tools/testing/ktest/examples/kvm.conf
> >> index 831c7c5..40356f7 100644
> >> --- a/tools/testing/ktest/examples/kvm.conf
> >> +++ b/tools/testing/ktest/examples/kvm.conf
> >> @@ -10,6 +10,10 @@ MACHINE = Guest
> >> # Use virsh to read the serial console of the guest
> >> CONSOLE = virsh console ${MACHINE}
> >>
> >> +# Use SIGILL to terminate virsh console. We can't kill virsh console
> >> +# by the default signal, SIGINT.
> >> +CLOSE_CONSOLE_SIGNAL = KILL
> >> +
> >
> > Thanks, I'll add this to my 3.15 queue.
>
> Hmm, it seems that we need a following patch as well.
> Or, please merge with the orignal patch.
>
> Thanks,
> Takahiro
>
> ======================================================================
> From a1c7b948c47a6ea7b74225bf5698fdfb7199726a Mon Sep 17 00:00:00 2001
> From: MUNEDA Takahiro <[email protected]>
> Date: Tue, 25 Feb 2014 15:32:35 -0500
> Subject: [PATCH] ktest: Fixes a trivial typo
>
> Signed-off-by: MUNEDA Takahiro <[email protected]>
> Cc: Satoru Takeuchi <[email protected]>
> Cc: Steven Rostedt <[email protected]>
>
> ---
> tools/testing/ktest/examples/kvm.conf | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/ktest/examples/kvm.conf b/tools/testing/ktest/examples/kvm.conf
> index 40356f7..fbc134f 100644
> --- a/tools/testing/ktest/examples/kvm.conf
> +++ b/tools/testing/ktest/examples/kvm.conf
> @@ -10,7 +10,7 @@ MACHINE = Guest
> # Use virsh to read the serial console of the guest
> CONSOLE = virsh console ${MACHINE}
> -# Use SIGILL to terminate virsh console. We can't kill virsh console
> +# Use SIGKILL to terminate virsh console. We can't kill virsh console

Oops, it's a completely the different signal. Thanks Takahiro.

Satoru

> # by the default signal, SIGINT.
> CLOSE_CONSOLE_SIGNAL = KILL
> --
> 1.8.3.1

2014-02-26 13:43:08

by Steven Rostedt

Subject: Re: [PATCH] ktest: Set CLOSE_CONSOLE_SIGNAL in the kvm.conf

On Wed, 26 Feb 2014 20:43:16 +0900
Satoru Takeuchi <[email protected]> wrote:

> > -# Use SIGILL to terminate virsh console. We can't kill virsh console
> > +# Use SIGKILL to terminate virsh console. We can't kill virsh console
>
> Oops, it's a completely the different signal. Thanks Takahiro.

Please be careful...
That one letter is the difference between the "Beastie Boys" and "007"

Sending the Beastie Boys out to serve for Her Majesty's Secret Service
would be a disaster.

http://en.wikipedia.org/wiki/Licensed_to_Ill
http://en.wikipedia.org/wiki/Licensed_to_Kill_(1965_film)

-- Steve

2014-02-26 20:29:41

by Steven Rostedt

Subject: Re: [PATCH] ktest: Set CLOSE_CONSOLE_SIGNAL in the kvm.conf

On Tue, 25 Feb 2014 21:21:18 -0500
MUNEDA Takahiro <[email protected]> wrote:

> Hmm, it seems that we need a following patch as well.
> Or, please merge with the orignal patch.

I folded this fix in, here's the final:

>From 62183dcac539a14ed0a820b8392db353d72a7d7e Mon Sep 17 00:00:00 2001
From: Satoru Takeuchi <[email protected]>
Date: Sun, 23 Feb 2014 10:19:28 +0900
Subject: [PATCH] ktest: Set CLOSE_CONSOLE_SIGNAL in the kvm.conf

As mentioned at commit 5a5d8e48449, we can't terminate 'virsh console'
with the default signal(INT). So it's better to set CLOSE_CONSOLE_SIGNAL
in the kvm.conf.

Link: http://lkml.kernel.org/r/8738jatylb.wl%[email protected]

Signed-off-by: Satoru Takeuchi <[email protected]>
[ Typo fixed by ]
Signed-off-by: MUNEDA Takahiro <[email protected]>
Signed-off-by: Steven Rostedt <[email protected]>
---
tools/testing/ktest/examples/kvm.conf | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/tools/testing/ktest/examples/kvm.conf b/tools/testing/ktest/examples/kvm.conf
index 831c7c5..fbc134f 100644
--- a/tools/testing/ktest/examples/kvm.conf
+++ b/tools/testing/ktest/examples/kvm.conf
@@ -10,6 +10,10 @@ MACHINE = Guest
# Use virsh to read the serial console of the guest
CONSOLE = virsh console ${MACHINE}

+# Use SIGKILL to terminate virsh console. We can't kill virsh console
+# by the default signal, SIGINT.
+CLOSE_CONSOLE_SIGNAL = KILL
+
#*************************************#
# This part is the same as test.conf #
#*************************************#
--
1.8.5.3