Document the IPQ9574 dwc3 compatible.
Signed-off-by: Varadarajan Narayanan <[email protected]>
---
Changes in v6:
- Made power-domains as optional
- Resolved all 'make dtbs_check' messages
Changes in v5:
- Restore removed constraints
Changes in v4:
- Update other relevant sections
- Remove constraints not applicable to IPQ9574
---
.../devicetree/bindings/usb/qcom,dwc3.yaml | 22 +++++++++++++++++++++-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
index d842819..f5dd268 100644
--- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
@@ -17,6 +17,7 @@ properties:
- qcom,ipq6018-dwc3
- qcom,ipq8064-dwc3
- qcom,ipq8074-dwc3
+ - qcom,ipq9574-dwc3
- qcom,msm8953-dwc3
- qcom,msm8994-dwc3
- qcom,msm8996-dwc3
@@ -133,7 +134,6 @@ required:
- "#address-cells"
- "#size-cells"
- ranges
- - power-domains
- clocks
- clock-names
- interrupts
@@ -197,6 +197,26 @@ allOf:
- const: iface
- const: sleep
- const: mock_utmi
+ required:
+ - power-domains
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - qcom,ipq9574-dwc3
+ then:
+ properties:
+ clocks:
+ maxItems: 5
+ clock-names:
+ items:
+ - const: cfg_noc
+ - const: core
+ - const: iface
+ - const: sleep
+ - const: mock_utmi
- if:
properties:
--
2.7.4
On 05/04/2023 13:41, Varadarajan Narayanan wrote:
> Document the IPQ9574 dwc3 compatible.
>
> Signed-off-by: Varadarajan Narayanan <[email protected]>
> ---
> Changes in v6:
> - Made power-domains as optional
> - Resolved all 'make dtbs_check' messages
>
> Changes in v5:
> - Restore removed constraints
>
> Changes in v4:
> - Update other relevant sections
> - Remove constraints not applicable to IPQ9574
> ---
> .../devicetree/bindings/usb/qcom,dwc3.yaml | 22 +++++++++++++++++++++-
> 1 file changed, 21 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> index d842819..f5dd268 100644
> --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> @@ -17,6 +17,7 @@ properties:
> - qcom,ipq6018-dwc3
> - qcom,ipq8064-dwc3
> - qcom,ipq8074-dwc3
> + - qcom,ipq9574-dwc3
> - qcom,msm8953-dwc3
> - qcom,msm8994-dwc3
> - qcom,msm8996-dwc3
> @@ -133,7 +134,6 @@ required:
> - "#address-cells"
> - "#size-cells"
> - ranges
> - - power-domains
Power domains are required. Commit msg does not explain why this should
be now optional.
> - clocks
> - clock-names
> - interrupts
> @@ -197,6 +197,26 @@ allOf:
> - const: iface
> - const: sleep
> - const: mock_utmi
> + required:
> + - power-domains
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - qcom,ipq9574-dwc3
You do not need new entry. Just open the file and file respective
existing if.
Best regards,
Krzysztof
On Thu, Apr 06, 2023 at 09:43:48AM +0200, Krzysztof Kozlowski wrote:
> On 05/04/2023 13:41, Varadarajan Narayanan wrote:
> > Document the IPQ9574 dwc3 compatible.
> >
> > Signed-off-by: Varadarajan Narayanan <[email protected]>
> > ---
> > Changes in v6:
> > - Made power-domains as optional
> > - Resolved all 'make dtbs_check' messages
> >
> > Changes in v5:
> > - Restore removed constraints
> >
> > Changes in v4:
> > - Update other relevant sections
> > - Remove constraints not applicable to IPQ9574
> > ---
> > .../devicetree/bindings/usb/qcom,dwc3.yaml | 22 +++++++++++++++++++++-
> > 1 file changed, 21 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> > index d842819..f5dd268 100644
> > --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> > +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> > @@ -17,6 +17,7 @@ properties:
> > - qcom,ipq6018-dwc3
> > - qcom,ipq8064-dwc3
> > - qcom,ipq8074-dwc3
> > + - qcom,ipq9574-dwc3
> > - qcom,msm8953-dwc3
> > - qcom,msm8994-dwc3
> > - qcom,msm8996-dwc3
> > @@ -133,7 +134,6 @@ required:
> > - "#address-cells"
> > - "#size-cells"
> > - ranges
> > - - power-domains
>
>
> Power domains are required. Commit msg does not explain why this should
> be now optional.
Since IPQ9574 doesn't have power switches, couldn't provide power-domains info.
So, had to make it optional to pass 'make dtbs_check'.
Will post patch with updated commit msg.
> > - clocks
> > - clock-names
> > - interrupts
> > @@ -197,6 +197,26 @@ allOf:
> > - const: iface
> > - const: sleep
> > - const: mock_utmi
> > + required:
> > + - power-domains
> > +
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + enum:
> > + - qcom,ipq9574-dwc3
>
> You do not need new entry. Just open the file and file respective
> existing if.
Sure. Will fix this and post.
Thanks
Varada
> Best regards,
> Krzysztof