2014-04-06 11:57:04

by Sergei Trofimovich

Subject: [PATCH] cpts: add missing <linux/if_vlan.h>

From: Sergei Trofimovich <[email protected]>

gcc complains as:
drivers/net/ethernet/ti/cpts.c: In function 'cpts_match':
drivers/net/ethernet/ti/cpts.c:266:12: error: 'ETH_HLEN' undeclared (first use in this function)
drivers/net/ethernet/ti/cpts.c:266:12: note: each undeclared identifier is reported only once for each function it appears in
drivers/net/ethernet/ti/cpts.c:276:23: error: 'VLAN_HLEN' undeclared (first use in this function)

Signed-off-by: Sergei Trofimovich <[email protected]>
CC: "David S. Miller" <[email protected]>
CC: [email protected]
---
drivers/net/ethernet/ti/cpts.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/ti/cpts.c b/drivers/net/ethernet/ti/cpts.c
index a3bbf59..c413e79 100644
--- a/drivers/net/ethernet/ti/cpts.c
+++ b/drivers/net/ethernet/ti/cpts.c
@@ -19,6 +19,7 @@
*/
#include <linux/err.h>
#include <linux/if.h>
+#include <linux/if_vlan.h>
#include <linux/hrtimer.h>
#include <linux/module.h>
#include <linux/net_tstamp.h>
--
1.9.0

2014-04-06 16:48:30

by Daniel Borkmann

Subject: Re: [PATCH] cpts: add missing <linux/if_vlan.h>

On 04/06/2014 01:55 PM, Sergei Trofimovich wrote:
> From: Sergei Trofimovich <[email protected]>
>
> gcc complains as:
> drivers/net/ethernet/ti/cpts.c: In function 'cpts_match':
> drivers/net/ethernet/ti/cpts.c:266:12: error: 'ETH_HLEN' undeclared (first use in this function)
> drivers/net/ethernet/ti/cpts.c:266:12: note: each undeclared identifier is reported only once for each function it appears in
> drivers/net/ethernet/ti/cpts.c:276:23: error: 'VLAN_HLEN' undeclared (first use in this function)
>
> Signed-off-by: Sergei Trofimovich <[email protected]>
> CC: "David S. Miller" <[email protected]>
> CC: [email protected]

Thanks, fix is already in net tree:

https://git.kernel.org/cgit/linux/kernel/git/davem/net.git/commit/?id=79eb9d28c9b22fa419e2c3f1b2cc6e285720ae41