2014-04-04 14:43:49

by Lyude

Subject: [PATCH] Favor native backlight interface for ThinkPad Helix

Like many other Windows 8 laptops the ThinkPad Helix's backlight has a
broken ACPI interface and can only be properly adjusted by using the
video card's native backlight control. This adds the ThinkPad Helix to
the list of laptops affected with this issue so that
video.use_native_backlight is enabled by default.

Signed-off-by: Stephen Chandler Paul <[email protected]>
---
drivers/acpi/video.c | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index 48c7e8a..8b6990e 100644
--- a/drivers/acpi/video.c
+++ b/drivers/acpi/video.c
@@ -488,6 +488,14 @@ static struct dmi_system_id video_dmi_table[] __initdata = {
},
},
{
+ .callback = video_set_use_native_backlight,
+ .ident = "Thinkpad Helix",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+ DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad Helix"),
+ },
+ },
+ {
.callback = video_set_use_native_backlight,
.ident = "Dell Inspiron 7520",
.matches = {
--
1.8.3.2

2014-04-08 02:48:46

by Aaron Lu

Subject: Re: [PATCH] Favor native backlight interface for ThinkPad Helix

On 04/04/2014 10:44 PM, Stephen Chandler Paul wrote:
> Like many other Windows 8 laptops the ThinkPad Helix's backlight has a
> broken ACPI interface and can only be properly adjusted by using the
> video card's native backlight control. This adds the ThinkPad Helix to
> the list of laptops affected with this issue so that
> video.use_native_backlight is enabled by default.

It would be good to attach your acpidump so that we know for sure and if
one day we need to remove this entry, we can verify its table.

Bug 51231 is tracking this problem and mostly are thinkpad laptops, so
please attach your acpidump and dmi there, thanks.
https://bugzilla.kernel.org/show_bug.cgi?id=51231

-Aaron

>
> Signed-off-by: Stephen Chandler Paul <[email protected]>
> ---
> drivers/acpi/video.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
> index 48c7e8a..8b6990e 100644
> --- a/drivers/acpi/video.c
> +++ b/drivers/acpi/video.c
> @@ -488,6 +488,14 @@ static struct dmi_system_id video_dmi_table[] __initdata = {
> },
> },
> {
> + .callback = video_set_use_native_backlight,
> + .ident = "Thinkpad Helix",
> + .matches = {
> + DMI_MATCH(DMI_SYS_Vhttps://bugzilla.kernel.org/show_bug.cgi?id=51231ENDOR, "LENOVO"),
> + DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad Helix"),
> + },
> + },
> + {
> .callback = video_set_use_native_backlight,
> .ident = "Dell Inspiron 7520",
> .matches = {
>

2014-04-08 12:14:03

by Rafael J. Wysocki

Subject: Re: [PATCH] Favor native backlight interface for ThinkPad Helix

On Tuesday, April 08, 2014 10:49:17 AM Aaron Lu wrote:
> On 04/04/2014 10:44 PM, Stephen Chandler Paul wrote:
> > Like many other Windows 8 laptops the ThinkPad Helix's backlight has a
> > broken ACPI interface and can only be properly adjusted by using the
> > video card's native backlight control. This adds the ThinkPad Helix to
> > the list of laptops affected with this issue so that
> > video.use_native_backlight is enabled by default.
>
> It would be good to attach your acpidump so that we know for sure and if
> one day we need to remove this entry, we can verify its table.
>
> Bug 51231 is tracking this problem and mostly are thinkpad laptops, so
> please attach your acpidump and dmi there, thanks.
> https://bugzilla.kernel.org/show_bug.cgi?id=51231

I've queued this patch up for the next ACPI pull request. We'll revert it
if it turns out to be incorrect.

> > Signed-off-by: Stephen Chandler Paul <[email protected]>
> > ---
> > drivers/acpi/video.c | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
> > index 48c7e8a..8b6990e 100644
> > --- a/drivers/acpi/video.c
> > +++ b/drivers/acpi/video.c
> > @@ -488,6 +488,14 @@ static struct dmi_system_id video_dmi_table[] __initdata = {
> > },
> > },
> > {
> > + .callback = video_set_use_native_backlight,
> > + .ident = "Thinkpad Helix",
> > + .matches = {
> > + DMI_MATCH(DMI_SYS_Vhttps://bugzilla.kernel.org/show_bug.cgi?id=51231ENDOR, "LENOVO"),
> > + DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad Helix"),
> > + },
> > + },
> > + {
> > .callback = video_set_use_native_backlight,
> > .ident = "Dell Inspiron 7520",
> > .matches = {
> >
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.