2022-02-22 13:43:21

by Antoniu Miclaus

Subject: [PATCH v5 1/3] dt-bindings: iio: amplifiers: add ada4250 doc

Add device tree bindings for the ADA4250 driver.

Signed-off-by: Antoniu Miclaus <[email protected]>
---
changes in v5:
- put dt-bindings patch first in the series
- add spaces after `:` in commit subject
.../bindings/iio/amplifiers/adi,ada4250.yaml | 50 +++++++++++++++++++
1 file changed, 50 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/amplifiers/adi,ada4250.yaml

diff --git a/Documentation/devicetree/bindings/iio/amplifiers/adi,ada4250.yaml b/Documentation/devicetree/bindings/iio/amplifiers/adi,ada4250.yaml
new file mode 100644
index 000000000000..2d22037496bc
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/amplifiers/adi,ada4250.yaml
@@ -0,0 +1,50 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/amplifiers/adi,ada4250.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ADA4250 Programmable Gain Instrumentation Amplifier
+
+maintainers:
+ - Antoniu Miclaus <[email protected]>
+
+description: |
+ Precision Low Power, 110kHz, 26uA, Programmable Gain Instrumentation Amplifier.
+
+properties:
+ compatible:
+ enum:
+ - adi,ada4250
+
+ reg:
+ maxItems: 1
+
+ avdd-supply: true
+
+ adi,refbuf-enable:
+ description:
+ Enable internal buffer to drive the reference pin.
+ type: boolean
+
+ spi-max-frequency: true
+
+required:
+ - compatible
+ - reg
+ - avdd-supply
+
+additionalProperties: false
+
+examples:
+ - |
+ spi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ amplifier@0{
+ compatible = "adi,ada4250";
+ reg = <0>;
+ avdd-supply = <&avdd>;
+ };
+ };
+...
--
2.35.1

2022-02-22 14:06:12

by Antoniu Miclaus

Subject: [PATCH v5 3/3] MAINTAINERS: add maintainer for ADA4250 driver

Add myself as maintainer for the ADA4250 driver.

Signed-off-by: Antoniu Miclaus <[email protected]>
---
MAINTAINERS | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index fb18ce7168aa..0410054a7bf5 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1075,6 +1075,14 @@ L: [email protected]
S: Maintained
F: drivers/media/i2c/ad9389b*

+ANALOG DEVICES INC ADA4250 DRIVER
+M: Antoniu Miclaus <[email protected]>
+L: [email protected]
+S: Supported
+W: https://ez.analog.com/linux-software-drivers
+F: Documentation/devicetree/bindings/iio/amplifiers/adi,ada4250.yaml
+F: drivers/iio/amplifiers/ada4250.c
+
ANALOG DEVICES INC ADGS1408 DRIVER
M: Mircea Caprioru <[email protected]>
S: Supported
--
2.35.1

2022-02-23 12:49:55

by Krzysztof Kozlowski

Subject: Re: [PATCH v5 1/3] dt-bindings: iio: amplifiers: add ada4250 doc

On 22/02/2022 11:38, Antoniu Miclaus wrote:
> Add device tree bindings for the ADA4250 driver.
>
> Signed-off-by: Antoniu Miclaus <[email protected]>
> ---
> changes in v5:
> - put dt-bindings patch first in the series
> - add spaces after `:` in commit subject
> .../bindings/iio/amplifiers/adi,ada4250.yaml | 50 +++++++++++++++++++
> 1 file changed, 50 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/amplifiers/adi,ada4250.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/amplifiers/adi,ada4250.yaml b/Documentation/devicetree/bindings/iio/amplifiers/adi,ada4250.yaml
> new file mode 100644
> index 000000000000..2d22037496bc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/amplifiers/adi,ada4250.yaml
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/amplifiers/adi,ada4250.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ADA4250 Programmable Gain Instrumentation Amplifier
> +
> +maintainers:
> + - Antoniu Miclaus <[email protected]>
> +
> +description: |
> + Precision Low Power, 110kHz, 26uA, Programmable Gain Instrumentation Amplifier.
> +
> +properties:
> + compatible:
> + enum:
> + - adi,ada4250
> +
> + reg:
> + maxItems: 1
> +
> + avdd-supply: true
> +
> + adi,refbuf-enable:
> + description:
> + Enable internal buffer to drive the reference pin.
> + type: boolean
> +
> + spi-max-frequency: true
> +
> +required:
> + - compatible
> + - reg
> + - avdd-supply
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + amplifier@0{

The same as in other patches from Analog. Space before '{'.

Please fix it in all other patchsets as well. You submit these days
around 3-4 different devices, which is cool and great. But please fix
pointed out issue not only here, but for every other driver/binding you
work on.

With the space added:

Reviewed-by: Krzysztof Kozlowski <[email protected]>

> + compatible = "adi,ada4250";
> + reg = <0>;
> + avdd-supply = <&avdd>;
> + };
> + };
> +...


Best regards,
Krzysztof