2014-04-15 22:27:11

by Stratos Karafotis

Subject: [PATCH v2 8/8] sh: clk: Use cpufreq_for_each_valid_entry macro for iteration

The cpufreq core now supports the cpufreq_for_each_valid_entry macro
helper for iteration over the cpufreq_frequency_table, so use it.

It should have no functional changes.

Signed-off-by: Stratos Karafotis <[email protected]>
---
drivers/sh/clk/core.c | 20 +++++---------------
1 file changed, 5 insertions(+), 15 deletions(-)

diff --git a/drivers/sh/clk/core.c b/drivers/sh/clk/core.c
index 7472785..be56b22 100644
--- a/drivers/sh/clk/core.c
+++ b/drivers/sh/clk/core.c
@@ -196,17 +196,11 @@ int clk_rate_table_find(struct clk *clk,
struct cpufreq_frequency_table *freq_table,
unsigned long rate)
{
- int i;
-
- for (i = 0; freq_table[i].frequency != CPUFREQ_TABLE_END; i++) {
- unsigned long freq = freq_table[i].frequency;
+ struct cpufreq_frequency_table *pos;

- if (freq == CPUFREQ_ENTRY_INVALID)
- continue;
-
- if (freq == rate)
- return i;
- }
+ cpufreq_for_each_valid_entry(pos, freq_table)
+ if (pos->frequency == rate)
+ return pos - freq_table;

return -ENOENT;
}
@@ -575,11 +569,7 @@ long clk_round_parent(struct clk *clk, unsigned long target,
return abs(target - *best_freq);
}

- for (freq = parent->freq_table; freq->frequency != CPUFREQ_TABLE_END;
- freq++) {
- if (freq->frequency == CPUFREQ_ENTRY_INVALID)
- continue;
-
+ cpufreq_for_each_valid_entry(freq, parent->freq_table) {
if (unlikely(freq->frequency / target <= div_min - 1)) {
unsigned long freq_max;

--
1.9.0

2014-04-16 01:11:24

by Simon Horman

Subject: Re: [PATCH v2 8/8] sh: clk: Use cpufreq_for_each_valid_entry macro for iteration

On Wed, Apr 16, 2014 at 01:27:04AM +0300, Stratos Karafotis wrote:
> The cpufreq core now supports the cpufreq_for_each_valid_entry macro
> helper for iteration over the cpufreq_frequency_table, so use it.
>
> It should have no functional changes.
>
> Signed-off-by: Stratos Karafotis <[email protected]>

Thanks, I have queued this up.

2014-04-16 01:25:00

by Simon Horman

Subject: Re: [PATCH v2 8/8] sh: clk: Use cpufreq_for_each_valid_entry macro for iteration

On Wed, Apr 16, 2014 at 10:11:20AM +0900, Simon Horman wrote:
> On Wed, Apr 16, 2014 at 01:27:04AM +0300, Stratos Karafotis wrote:
> > The cpufreq core now supports the cpufreq_for_each_valid_entry macro
> > helper for iteration over the cpufreq_frequency_table, so use it.
> >
> > It should have no functional changes.
> >
> > Signed-off-by: Stratos Karafotis <[email protected]>
>
> Thanks, I have queued this up.

I have dropped this patch.

Please let me know if there is a stable branch which
includes cpufreq_frequency_table which I can use as a base to apply
this patch.

Alternatively, I would be happy to Ack this patch and let someone
else pick up this patch, but I'm entirely unclear on who that would be.

2014-04-16 04:00:26

by Viresh Kumar

Subject: Re: [PATCH v2 8/8] sh: clk: Use cpufreq_for_each_valid_entry macro for iteration

On 16 April 2014 06:54, Simon Horman <[email protected]> wrote:
> I have dropped this patch.
>
> Please let me know if there is a stable branch which
> includes cpufreq_frequency_table which I can use as a base to apply
> this patch.
>
> Alternatively, I would be happy to Ack this patch and let someone
> else pick up this patch, but I'm entirely unclear on who that would be.

Rafael will take this patch, please Ack it :)

2014-04-16 04:13:50

by Simon Horman

Subject: Re: [PATCH v2 8/8] sh: clk: Use cpufreq_for_each_valid_entry macro for iteration

On Wed, Apr 16, 2014 at 01:27:04AM +0300, Stratos Karafotis wrote:
> The cpufreq core now supports the cpufreq_for_each_valid_entry macro
> helper for iteration over the cpufreq_frequency_table, so use it.
>
> It should have no functional changes.
>
> Signed-off-by: Stratos Karafotis <[email protected]>

Rafael, please feel free to take this one.

Acked-by: Simon Horman <[email protected]>

> ---
> drivers/sh/clk/core.c | 20 +++++---------------
> 1 file changed, 5 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/sh/clk/core.c b/drivers/sh/clk/core.c
> index 7472785..be56b22 100644
> --- a/drivers/sh/clk/core.c
> +++ b/drivers/sh/clk/core.c
> @@ -196,17 +196,11 @@ int clk_rate_table_find(struct clk *clk,
> struct cpufreq_frequency_table *freq_table,
> unsigned long rate)
> {
> - int i;
> -
> - for (i = 0; freq_table[i].frequency != CPUFREQ_TABLE_END; i++) {
> - unsigned long freq = freq_table[i].frequency;
> + struct cpufreq_frequency_table *pos;
>
> - if (freq == CPUFREQ_ENTRY_INVALID)
> - continue;
> -
> - if (freq == rate)
> - return i;
> - }
> + cpufreq_for_each_valid_entry(pos, freq_table)
> + if (pos->frequency == rate)
> + return pos - freq_table;
>
> return -ENOENT;
> }
> @@ -575,11 +569,7 @@ long clk_round_parent(struct clk *clk, unsigned long target,
> return abs(target - *best_freq);
> }
>
> - for (freq = parent->freq_table; freq->frequency != CPUFREQ_TABLE_END;
> - freq++) {
> - if (freq->frequency == CPUFREQ_ENTRY_INVALID)
> - continue;
> -
> + cpufreq_for_each_valid_entry(freq, parent->freq_table) {
> if (unlikely(freq->frequency / target <= div_min - 1)) {
> unsigned long freq_max;
>
> --
> 1.9.0
>

2014-04-16 04:14:00

by Simon Horman

Subject: Re: [PATCH v2 8/8] sh: clk: Use cpufreq_for_each_valid_entry macro for iteration

On Wed, Apr 16, 2014 at 09:30:24AM +0530, Viresh Kumar wrote:
> On 16 April 2014 06:54, Simon Horman <[email protected]> wrote:
> > I have dropped this patch.
> >
> > Please let me know if there is a stable branch which
> > includes cpufreq_frequency_table which I can use as a base to apply
> > this patch.
> >
> > Alternatively, I would be happy to Ack this patch and let someone
> > else pick up this patch, but I'm entirely unclear on who that would be.
>
> Rafael will take this patch, please Ack it :)

Thanks, done.

2014-04-16 07:04:44

by Stratos Karafotis

Subject: Re: [PATCH v2 8/8] sh: clk: Use cpufreq_for_each_valid_entry macro for iteration

On 16/04/2014 07:13 πμ, Simon Horman wrote:
> On Wed, Apr 16, 2014 at 01:27:04AM +0300, Stratos Karafotis wrote:
>> The cpufreq core now supports the cpufreq_for_each_valid_entry macro
>> helper for iteration over the cpufreq_frequency_table, so use it.
>>
>> It should have no functional changes.
>>
>> Signed-off-by: Stratos Karafotis <[email protected]>
>
> Rafael, please feel free to take this one.
>
> Acked-by: Simon Horman <[email protected]>
>

Thanks!

Stratos

2014-04-21 23:02:44

by Stratos Karafotis

Subject: [PATCH v4 8/8] sh: clk: Use cpufreq_for_each_valid_entry macro for iteration

The cpufreq core now supports the cpufreq_for_each_valid_entry macro
helper for iteration over the cpufreq_frequency_table, so use it.

It should have no functional changes.

Signed-off-by: Stratos Karafotis <[email protected]>
---
drivers/sh/clk/core.c | 20 +++++---------------
1 file changed, 5 insertions(+), 15 deletions(-)

diff --git a/drivers/sh/clk/core.c b/drivers/sh/clk/core.c
index 7472785..be56b22 100644
--- a/drivers/sh/clk/core.c
+++ b/drivers/sh/clk/core.c
@@ -196,17 +196,11 @@ int clk_rate_table_find(struct clk *clk,
struct cpufreq_frequency_table *freq_table,
unsigned long rate)
{
- int i;
-
- for (i = 0; freq_table[i].frequency != CPUFREQ_TABLE_END; i++) {
- unsigned long freq = freq_table[i].frequency;
+ struct cpufreq_frequency_table *pos;

- if (freq == CPUFREQ_ENTRY_INVALID)
- continue;
-
- if (freq == rate)
- return i;
- }
+ cpufreq_for_each_valid_entry(pos, freq_table)
+ if (pos->frequency == rate)
+ return pos - freq_table;

return -ENOENT;
}
@@ -575,11 +569,7 @@ long clk_round_parent(struct clk *clk, unsigned long target,
return abs(target - *best_freq);
}

- for (freq = parent->freq_table; freq->frequency != CPUFREQ_TABLE_END;
- freq++) {
- if (freq->frequency == CPUFREQ_ENTRY_INVALID)
- continue;
-
+ cpufreq_for_each_valid_entry(freq, parent->freq_table) {
if (unlikely(freq->frequency / target <= div_min - 1)) {
unsigned long freq_max;

--
1.9.0