2020-11-23 18:03:15

by Jani Nikula

[permalink] [raw]
Subject: [PATCH 5/9] drm/i915: make relay callbacks const

Now that relay_open() accepts const callbacks, make relay callbacks
const.

Cc: [email protected]
Signed-off-by: Jani Nikula <[email protected]>
---
drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
index 9bbe8a795cb8..c92f2c056db4 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
@@ -134,7 +134,7 @@ static int remove_buf_file_callback(struct dentry *dentry)
}

/* relay channel callbacks */
-static struct rchan_callbacks relay_callbacks = {
+static const struct rchan_callbacks relay_callbacks = {
.subbuf_start = subbuf_start_callback,
.create_buf_file = create_buf_file_callback,
.remove_buf_file = remove_buf_file_callback,
--
2.20.1


2020-11-24 09:45:25

by Christoph Hellwig

[permalink] [raw]
Subject: Re: [PATCH 5/9] drm/i915: make relay callbacks const

On Mon, Nov 23, 2020 at 07:59:25PM +0200, Jani Nikula wrote:
> Now that relay_open() accepts const callbacks, make relay callbacks
> const.
>
> Cc: [email protected]
> Signed-off-by: Jani Nikula <[email protected]>

Looks good,

Reviewed-by: Christoph Hellwig <[email protected]>