2014-04-24 14:31:28

by Balaji T K

[permalink] [raw]
Subject: Re: [PATCH 0/5] mmc: host: omap_hsmmc: a few improvements

On Thursday 27 March 2014 05:34 AM, Felipe Balbi wrote:
> Hi,
>
> this series lets us access the newer registers introduced
> back in OMAP4 which give us some valid information about
> the OMAP HSMMC IP like max block size, support for ADMA,
> support for Retention.

"Support for Retention" looks interesting, can you shed more lights
on it

>
> Right now, only setting max_blk_size correctly as supporting
> ADMA and Retention will take a lot of work.
>
> Tested on OMAP5 uEVM.
>
> Felipe Balbi (5):
> mmc: host: omap_hsmmc: pass host as an argument
> mmc: host: omap_hsmmc: add reg_offset field
> mmc: host: omap_hsmmc: introduce new accessor functions
> mmc: host: omap_hsmmc: switch over to new accessors
> mmc: host: omap_hsmmc: set max_blk_size correctly
>
> drivers/mmc/host/omap_hsmmc.c | 291 ++++++++++++++++++++++++++----------------
> 1 file changed, 182 insertions(+), 109 deletions(-)
>


2014-04-24 14:39:46

by Felipe Balbi

[permalink] [raw]
Subject: Re: [PATCH 0/5] mmc: host: omap_hsmmc: a few improvements

On Thu, Apr 24, 2014 at 08:01:19PM +0530, Balaji T K wrote:
> On Thursday 27 March 2014 05:34 AM, Felipe Balbi wrote:
> >Hi,
> >
> >this series lets us access the newer registers introduced
> >back in OMAP4 which give us some valid information about
> >the OMAP HSMMC IP like max block size, support for ADMA,
> >support for Retention.
>
> "Support for Retention" looks interesting, can you shed more lights on
> it

HWINFO has a bit (bit 6) which tells you whether retention is supported,
it's in all TRMs since OMAP3630 or so.

"6 RERETMODE Retention mode generic parameter
This bit field indicates whether the
retention mode is supported using the
pin PIRFFRET.

0x0: Retention mode disabled
0x1: Retention mode enabled"

--
balbi


Attachments:
(No filename) (757.00 B)
signature.asc (819.00 B)
Digital signature
Download all attachments

2014-04-24 14:43:26

by Balaji T K

[permalink] [raw]
Subject: Re: [PATCH 0/5] mmc: host: omap_hsmmc: a few improvements

On Thursday 24 April 2014 08:09 PM, Felipe Balbi wrote:
> On Thu, Apr 24, 2014 at 08:01:19PM +0530, Balaji T K wrote:
>> On Thursday 27 March 2014 05:34 AM, Felipe Balbi wrote:
>>> Hi,
>>>
>>> this series lets us access the newer registers introduced
>>> back in OMAP4 which give us some valid information about
>>> the OMAP HSMMC IP like max block size, support for ADMA,
>>> support for Retention.
>>
>> "Support for Retention" looks interesting, can you shed more lights on
>> it
>
> HWINFO has a bit (bit 6) which tells you whether retention is supported,
> it's in all TRMs since OMAP3630 or so.
>
> "6 RERETMODE Retention mode generic parameter
> This bit field indicates whether the
> retention mode is supported using the
> pin PIRFFRET.
>
> 0x0: Retention mode disabled
> 0x1: Retention mode enabled"
>

I have seen that but just wondering how the driver can make use of it :-)

2014-04-24 14:48:35

by Felipe Balbi

[permalink] [raw]
Subject: Re: [PATCH 0/5] mmc: host: omap_hsmmc: a few improvements

On Thu, Apr 24, 2014 at 08:13:16PM +0530, Balaji T K wrote:
> On Thursday 24 April 2014 08:09 PM, Felipe Balbi wrote:
> >On Thu, Apr 24, 2014 at 08:01:19PM +0530, Balaji T K wrote:
> >>On Thursday 27 March 2014 05:34 AM, Felipe Balbi wrote:
> >>>Hi,
> >>>
> >>>this series lets us access the newer registers introduced
> >>>back in OMAP4 which give us some valid information about
> >>>the OMAP HSMMC IP like max block size, support for ADMA,
> >>>support for Retention.
> >>
> >>"Support for Retention" looks interesting, can you shed more lights on
> >>it
> >
> >HWINFO has a bit (bit 6) which tells you whether retention is supported,
> >it's in all TRMs since OMAP3630 or so.
> >
> >"6 RERETMODE Retention mode generic parameter
> > This bit field indicates whether the
> > retention mode is supported using the
> > pin PIRFFRET.
> >
> > 0x0: Retention mode disabled
> > 0x1: Retention mode enabled"
> >
>
> I have seen that but just wondering how the driver can make use of it
> :-)

oh, perhaps you can use to conditionally save context. The difficulty is
knowing if we're going to RET or OFF, but that could be extrapolated
from pm_qos, perhaps ?!?

just a thought.

--
balbi


Attachments:
(No filename) (1.17 kB)
signature.asc (819.00 B)
Digital signature
Download all attachments