Patches need to be sent inline. Perhaps use git send-email.
On Fri, Apr 25, 2014 at 01:06:44AM -0300, Nicolas Del Piano wrote:
>
> >From 38e0d5778bd97062115e7d8a8ca40d18f3d71707 Mon Sep 17 00:00:00 2001
> From: Nicolas Del Piano <[email protected]>
> Date: Thu, 24 Apr 2014 18:46:49 -0300
> Subject: [PATCH] Staging: comedi: drivers: fixed a missing blank line after a
> declaration coding style.
>
We don't want these headers in the patch.
> Fixed a coding style issue.
>
> Signed-off-by: Nicolas Del Piano <[email protected]>
> ---
> drivers/staging/comedi/drivers.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/comedi/drivers.c b/drivers/staging/comedi/drivers.c
> index cb5d214..71569bc 100644
> --- a/drivers/staging/comedi/drivers.c
> +++ b/drivers/staging/comedi/drivers.c
> @@ -439,6 +439,7 @@ static void *comedi_recognize(struct comedi_driver *driv, const char *name)
> static void comedi_report_boards(struct comedi_driver *driv)
> {
> unsigned int i;
> +
> const char *const *name_ptr;
The original code was correct. This is a bug in checkpatch.pl. The
missing line check should count any lines starting with "const" or
"static" as declarations.
regards,
dan carpenter
On Fri, 2014-04-25 at 10:50 +0300, Dan Carpenter wrote:
> On Fri, Apr 25, 2014 at 01:06:44AM -0300, Nicolas Del Piano wrote:
> > diff --git a/drivers/staging/comedi/drivers.c b/drivers/staging/comedi/drivers.c
[]
> > @@ -439,6 +439,7 @@ static void *comedi_recognize(struct comedi_driver *driv, const char *name)
> > static void comedi_report_boards(struct comedi_driver *driv)
> > {
> > unsigned int i;
> > +
> > const char *const *name_ptr;
>
> The original code was correct. This is a bug in checkpatch.pl. The
> missing line check should count any lines starting with "const" or
> "static" as declarations.
Right, thanks for the report.
I'm not around for a couple weeks.
I'll fix it properly later.
It looks like the $Type test in checkpatch
should allow multiple pointer declarations like
"const foo * const *"
instead of just
"const foo * const"
but it takes awhile to test that it doesn't stuff up
something else.
Andy? Any opinion of this?
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 89f44f1..daa4767 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -433,7 +433,7 @@ sub build_types {
}x;
$Type = qr{
$NonptrType
- (?:(?:\s|\*|\[\])+\s*const|(?:\s|\*|\[\])+|(?:\s*\[\s*\])+)?
+ (?:(?:\s|\*|\[\])+\s*const|(?:\s|\*|\[\])+|(?:\s*\[\s*\])+)*
(?:\s+$Inline|\s+$Modifier)*
}x;
$Declare = qr{(?:$Storage\s+(?:$Inline\s+)?)?$Type};
On Fri, Apr 25, 2014 at 08:29:59PM -0700, Joe Perches wrote:
> On Fri, 2014-04-25 at 10:50 +0300, Dan Carpenter wrote:
> > On Fri, Apr 25, 2014 at 01:06:44AM -0300, Nicolas Del Piano wrote:
> > > diff --git a/drivers/staging/comedi/drivers.c b/drivers/staging/comedi/drivers.c
> []
> > > @@ -439,6 +439,7 @@ static void *comedi_recognize(struct comedi_driver *driv, const char *name)
> > > static void comedi_report_boards(struct comedi_driver *driv)
> > > {
> > > unsigned int i;
> > > +
> > > const char *const *name_ptr;
> >
> > The original code was correct. This is a bug in checkpatch.pl. The
> > missing line check should count any lines starting with "const" or
> > "static" as declarations.
>
> Right, thanks for the report.
>
> I'm not around for a couple weeks.
> I'll fix it properly later.
No stress. These are not a big deal. These false positives are rare,
there is no way we would have applied the patch and even if we did then
the extra blank line is harmless.
regards,
dan carpenter