2014-04-02 09:55:19

by 敬锐

Subject: [PATCH] staging: rts5208: fix static checker warnings

From: Micky Ching <[email protected]>

The patch fa590c222fba: "staging: rts5208: add support for rts5208
and rts5288" from Nov 12, 2013, leads to the following static checker
warning:
drivers/staging/rts5208/rtsx_chip.c:107 rtsx_enable_bus_int()
warn: add curly braces?
This warning is produced because incorrect code indent.

Signed-off-by: Micky Ching <[email protected]>
---
drivers/staging/rts5208/rtsx_chip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rts5208/rtsx_chip.c b/drivers/staging/rts5208/rtsx_chip.c
index 6426807..7907e93 100644
--- a/drivers/staging/rts5208/rtsx_chip.c
+++ b/drivers/staging/rts5208/rtsx_chip.c
@@ -104,7 +104,7 @@ void rtsx_enable_bus_int(struct rtsx_chip *chip)
if (chip->ic_version >= IC_VER_C)
reg |= DELINK_INT_EN;
#ifdef SUPPORT_OCP
- reg |= OC_INT_EN;
+ reg |= OC_INT_EN;
#endif
if (!chip->adma_mode)
reg |= DATA_DONE_INT_EN;
--
1.7.9.5

2014-04-30 01:16:08

by 敬锐

Subject: Re: [PATCH] staging: rts5208: fix static checker warnings

Hi Dan,

I have send this patch to fix the static checker warning, but not
applied yet.

Best Regards.
micky.
On 04/02/2014 05:58 PM, [email protected] wrote:
> From: Micky Ching <[email protected]>
>
> The patch fa590c222fba: "staging: rts5208: add support for rts5208
> and rts5288" from Nov 12, 2013, leads to the following static checker
> warning:
> drivers/staging/rts5208/rtsx_chip.c:107 rtsx_enable_bus_int()
> warn: add curly braces?
> This warning is produced because incorrect code indent.
>
> Signed-off-by: Micky Ching <[email protected]>
> ---
> drivers/staging/rts5208/rtsx_chip.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rts5208/rtsx_chip.c b/drivers/staging/rts5208/rtsx_chip.c
> index 6426807..7907e93 100644
> --- a/drivers/staging/rts5208/rtsx_chip.c
> +++ b/drivers/staging/rts5208/rtsx_chip.c
> @@ -104,7 +104,7 @@ void rtsx_enable_bus_int(struct rtsx_chip *chip)
> if (chip->ic_version >= IC_VER_C)
> reg |= DELINK_INT_EN;
> #ifdef SUPPORT_OCP
> - reg |= OC_INT_EN;
> + reg |= OC_INT_EN;
> #endif
> if (!chip->adma_mode)
> reg |= DATA_DONE_INT_EN;