2017-07-22 08:13:39

by Dan Carpenter

Subject: [PATCH] tile: array underflow in setup_maxnodemem()

My static checker correctly complains that we should have a lower bound
on "node" to prevent an array underflow.

Fixes: 867e359b97c9 ("arch/tile: core support for Tilera 32-bit chips.")
Signed-off-by: Dan Carpenter <[email protected]>

diff --git a/arch/tile/kernel/setup.c b/arch/tile/kernel/setup.c
index 443a70bccc1c..b1474e7d9afb 100644
--- a/arch/tile/kernel/setup.c
+++ b/arch/tile/kernel/setup.c
@@ -140,7 +140,7 @@ static int __init setup_maxnodemem(char *str)
{
char *endp;
unsigned long long maxnodemem;
- long node;
+ unsigned long node;

node = str ? simple_strtoul(str, &endp, 0) : INT_MAX;
if (node >= MAX_NUMNODES || *endp != ':')

2017-07-24 15:26:01

by Chris Metcalf

Subject: Re: [PATCH] tile: array underflow in setup_maxnodemem()

On 7/22/2017 3:33 AM, Dan Carpenter wrote:
> My static checker correctly complains that we should have a lower bound
> on "node" to prevent an array underflow.
>
> Fixes: 867e359b97c9 ("arch/tile: core support for Tilera 32-bit chips.")
> Signed-off-by: Dan Carpenter<[email protected]>

Thanks, taken into the tile tree.

--
Chris Metcalf, Mellanox Technologies
http://www.mellanox.com