LinuxLists.cc - [PATCH 1/2] perf annotate: Handle x86 instruction suffix generally

2023-05-24 05:32:29

Subject: [PATCH 1/2] perf annotate: Handle x86 instruction suffix generally

Most of x86 instructions can have size suffix like b, w, l or q.
Instead of adding all these instructions in the table, we can handle
them in a general way. For example, it can try to find an instruction
as is. If not found, it'd try again without the suffix if it's one of
the allowed suffixes.

Signed-off-by: Namhyung Kim <[email protected]>
---
tools/perf/util/annotate.c | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)

diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index b708bbc49c9e..7f05f2a2aa83 100644
--- a/tools/perf/util/annotate.c
+++ b/tools/perf/util/annotate.c
@@ -70,6 +70,7 @@ struct arch {
struct ins_ops *(*associate_instruction_ops)(struct arch *arch, const char *name);
bool sorted_instructions;
bool initialized;
+ const char *insn_suffix;
void *priv;
unsigned int model;
unsigned int family;
@@ -179,6 +180,7 @@ static struct arch architectures[] = {
.init = x86__annotate_init,
.instructions = x86__instructions,
.nr_instructions = ARRAY_SIZE(x86__instructions),
+ .insn_suffix = "bwlq",
.objdump = {
.comment_char = '#',
},
@@ -720,6 +722,26 @@ static struct ins_ops *__ins__find(struct arch *arch, const char *name)
}

ins = bsearch(name, arch->instructions, nmemb, sizeof(struct ins), ins__key_cmp);
+ if (ins)
+ return ins->ops;
+
+ if (arch->insn_suffix) {
+ char tmp[32];
+ char suffix;
+ size_t len = strlen(name);
+
+ if (len == 0 || len >= sizeof(tmp))
+ return NULL;
+
+ suffix = name[len - 1];
+ if (strchr(arch->insn_suffix, suffix) == NULL)
+ return NULL;
+
+ strcpy(tmp, name);
+ tmp[len - 1] = '\0'; /* remove the suffix and check again */
+
+ ins = bsearch(tmp, arch->instructions, nmemb, sizeof(struct ins), ins__key_cmp);
+ }
return ins ? ins->ops : NULL;
}

--
2.40.1.698.g37aff9b760-goog

2023-05-24 05:38:17

by Namhyung Kim

[permalink] [raw]

Subject: [PATCH 2/2] perf annotate: Remove x86 instructions with suffix

Not the suffix is handled in the general code. Let's get rid of them.

Signed-off-by: Namhyung Kim <[email protected]>
---
tools/perf/arch/x86/annotate/instructions.c | 44 +--------------------
1 file changed, 2 insertions(+), 42 deletions(-)

diff --git a/tools/perf/arch/x86/annotate/instructions.c b/tools/perf/arch/x86/annotate/instructions.c
index 5c7bec25fee4..714fd8784d99 100644
--- a/tools/perf/arch/x86/annotate/instructions.c
+++ b/tools/perf/arch/x86/annotate/instructions.c
@@ -1,48 +1,29 @@
// SPDX-License-Identifier: GPL-2.0
static struct ins x86__instructions[] = {
{ .name = "adc", .ops = &mov_ops, },
- { .name = "adcb", .ops = &mov_ops, },
- { .name = "adcl", .ops = &mov_ops, },
{ .name = "add", .ops = &mov_ops, },
- { .name = "addl", .ops = &mov_ops, },
- { .name = "addq", .ops = &mov_ops, },
{ .name = "addsd", .ops = &mov_ops, },
- { .name = "addw", .ops = &mov_ops, },
{ .name = "and", .ops = &mov_ops, },
- { .name = "andb", .ops = &mov_ops, },
- { .name = "andl", .ops = &mov_ops, },
{ .name = "andpd", .ops = &mov_ops, },
{ .name = "andps", .ops = &mov_ops, },
- { .name = "andq", .ops = &mov_ops, },
- { .name = "andw", .ops = &mov_ops, },
{ .name = "bsr", .ops = &mov_ops, },
{ .name = "bt", .ops = &mov_ops, },
{ .name = "btr", .ops = &mov_ops, },
{ .name = "bts", .ops = &mov_ops, },
- { .name = "btsq", .ops = &mov_ops, },
{ .name = "call", .ops = &call_ops, },
- { .name = "callq", .ops = &call_ops, },
{ .name = "cmovbe", .ops = &mov_ops, },
{ .name = "cmove", .ops = &mov_ops, },
{ .name = "cmovae", .ops = &mov_ops, },
{ .name = "cmp", .ops = &mov_ops, },
- { .name = "cmpb", .ops = &mov_ops, },
- { .name = "cmpl", .ops = &mov_ops, },
- { .name = "cmpq", .ops = &mov_ops, },
- { .name = "cmpw", .ops = &mov_ops, },
{ .name = "cmpxch", .ops = &mov_ops, },
{ .name = "cmpxchg", .ops = &mov_ops, },
{ .name = "cs", .ops = &mov_ops, },
{ .name = "dec", .ops = &dec_ops, },
- { .name = "decl", .ops = &dec_ops, },
- { .name = "decq", .ops = &dec_ops, },
{ .name = "divsd", .ops = &mov_ops, },
{ .name = "divss", .ops = &mov_ops, },
{ .name = "gs", .ops = &mov_ops, },
{ .name = "imul", .ops = &mov_ops, },
{ .name = "inc", .ops = &dec_ops, },
- { .name = "incl", .ops = &dec_ops, },
- { .name = "incq", .ops = &dec_ops, },
{ .name = "ja", .ops = &jump_ops, },
{ .name = "jae", .ops = &jump_ops, },
{ .name = "jb", .ops = &jump_ops, },
@@ -56,7 +37,6 @@ static struct ins x86__instructions[] = {
{ .name = "jl", .ops = &jump_ops, },
{ .name = "jle", .ops = &jump_ops, },
{ .name = "jmp", .ops = &jump_ops, },
- { .name = "jmpq", .ops = &jump_ops, },
{ .name = "jna", .ops = &jump_ops, },
{ .name = "jnae", .ops = &jump_ops, },
{ .name = "jnb", .ops = &jump_ops, },
@@ -83,49 +63,31 @@ static struct ins x86__instructions[] = {
{ .name = "mov", .ops = &mov_ops, },
{ .name = "movapd", .ops = &mov_ops, },
{ .name = "movaps", .ops = &mov_ops, },
- { .name = "movb", .ops = &mov_ops, },
{ .name = "movdqa", .ops = &mov_ops, },
{ .name = "movdqu", .ops = &mov_ops, },
- { .name = "movl", .ops = &mov_ops, },
- { .name = "movq", .ops = &mov_ops, },
{ .name = "movsd", .ops = &mov_ops, },
{ .name = "movslq", .ops = &mov_ops, },
{ .name = "movss", .ops = &mov_ops, },
{ .name = "movupd", .ops = &mov_ops, },
{ .name = "movups", .ops = &mov_ops, },
- { .name = "movw", .ops = &mov_ops, },
{ .name = "movzbl", .ops = &mov_ops, },
{ .name = "movzwl", .ops = &mov_ops, },
{ .name = "mulsd", .ops = &mov_ops, },
{ .name = "mulss", .ops = &mov_ops, },
{ .name = "nop", .ops = &nop_ops, },
- { .name = "nopl", .ops = &nop_ops, },
- { .name = "nopw", .ops = &nop_ops, },
{ .name = "or", .ops = &mov_ops, },
- { .name = "orb", .ops = &mov_ops, },
- { .name = "orl", .ops = &mov_ops, },
{ .name = "orps", .ops = &mov_ops, },
- { .name = "orq", .ops = &mov_ops, },
{ .name = "pand", .ops = &mov_ops, },
{ .name = "paddq", .ops = &mov_ops, },
{ .name = "pcmpeqb", .ops = &mov_ops, },
{ .name = "por", .ops = &mov_ops, },
- { .name = "rclb", .ops = &mov_ops, },
- { .name = "rcll", .ops = &mov_ops, },
+ { .name = "rcl", .ops = &mov_ops, },
{ .name = "ret", .ops = &ret_ops, },
- { .name = "retq", .ops = &ret_ops, },
{ .name = "sbb", .ops = &mov_ops, },
- { .name = "sbbl", .ops = &mov_ops, },
{ .name = "sete", .ops = &mov_ops, },
{ .name = "sub", .ops = &mov_ops, },
- { .name = "subl", .ops = &mov_ops, },
- { .name = "subq", .ops = &mov_ops, },
{ .name = "subsd", .ops = &mov_ops, },
- { .name = "subw", .ops = &mov_ops, },
{ .name = "test", .ops = &mov_ops, },
- { .name = "testb", .ops = &mov_ops, },
- { .name = "testl", .ops = &mov_ops, },
- { .name = "testq", .ops = &mov_ops, },
{ .name = "tzcnt", .ops = &mov_ops, },
{ .name = "ucomisd", .ops = &mov_ops, },
{ .name = "ucomiss", .ops = &mov_ops, },
@@ -139,11 +101,9 @@ static struct ins x86__instructions[] = {
{ .name = "vsubsd", .ops = &mov_ops, },
{ .name = "vucomisd", .ops = &mov_ops, },
{ .name = "xadd", .ops = &mov_ops, },
- { .name = "xbeginl", .ops = &jump_ops, },
- { .name = "xbeginq", .ops = &jump_ops, },
+ { .name = "xbegin", .ops = &jump_ops, },
{ .name = "xchg", .ops = &mov_ops, },
{ .name = "xor", .ops = &mov_ops, },
- { .name = "xorb", .ops = &mov_ops, },
{ .name = "xorpd", .ops = &mov_ops, },
{ .name = "xorps", .ops = &mov_ops, },
};
--
2.40.1.698.g37aff9b760-goog

2023-05-24 06:38:14

by Adrian Hunter

[permalink] [raw]

Subject: Re: [PATCH 1/2] perf annotate: Handle x86 instruction suffix generally

On 24/05/23 08:28, Namhyung Kim wrote:
> Most of x86 instructions can have size suffix like b, w, l or q.

(AT&T mnemonics)

> Instead of adding all these instructions in the table, we can handle
> them in a general way. For example, it can try to find an instruction
> as is. If not found, it'd try again without the suffix if it's one of
> the allowed suffixes.

I guess it might be possible that xyz is in the table but xyz<suffix>
is a completely different instruction?

>
> Signed-off-by: Namhyung Kim <[email protected]>
> ---
> tools/perf/util/annotate.c | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
> index b708bbc49c9e..7f05f2a2aa83 100644
> --- a/tools/perf/util/annotate.c
> +++ b/tools/perf/util/annotate.c
> @@ -70,6 +70,7 @@ struct arch {
> struct ins_ops *(*associate_instruction_ops)(struct arch *arch, const char *name);
> bool sorted_instructions;
> bool initialized;
> + const char *insn_suffix;
> void *priv;
> unsigned int model;
> unsigned int family;
> @@ -179,6 +180,7 @@ static struct arch architectures[] = {
> .init = x86__annotate_init,
> .instructions = x86__instructions,
> .nr_instructions = ARRAY_SIZE(x86__instructions),
> + .insn_suffix = "bwlq",
> .objdump = {
> .comment_char = '#',
> },
> @@ -720,6 +722,26 @@ static struct ins_ops *__ins__find(struct arch *arch, const char *name)
> }
>
> ins = bsearch(name, arch->instructions, nmemb, sizeof(struct ins), ins__key_cmp);
> + if (ins)
> + return ins->ops;
> +
> + if (arch->insn_suffix) {
> + char tmp[32];
> + char suffix;
> + size_t len = strlen(name);
> +
> + if (len == 0 || len >= sizeof(tmp))
> + return NULL;
> +
> + suffix = name[len - 1];
> + if (strchr(arch->insn_suffix, suffix) == NULL)
> + return NULL;
> +
> + strcpy(tmp, name);
> + tmp[len - 1] = '\0'; /* remove the suffix and check again */
> +
> + ins = bsearch(tmp, arch->instructions, nmemb, sizeof(struct ins), ins__key_cmp);
> + }
> return ins ? ins->ops : NULL;
> }
>

2023-05-24 06:39:30

by Adrian Hunter

[permalink] [raw]

Subject: Re: [PATCH 2/2] perf annotate: Remove x86 instructions with suffix

On 24/05/23 08:28, Namhyung Kim wrote:
> Not the suffix is handled in the general code. Let's get rid of them.

Not -> Now ?

>
> Signed-off-by: Namhyung Kim <[email protected]>
> ---
> tools/perf/arch/x86/annotate/instructions.c | 44 +--------------------
> 1 file changed, 2 insertions(+), 42 deletions(-)
>
> diff --git a/tools/perf/arch/x86/annotate/instructions.c b/tools/perf/arch/x86/annotate/instructions.c
> index 5c7bec25fee4..714fd8784d99 100644
> --- a/tools/perf/arch/x86/annotate/instructions.c
> +++ b/tools/perf/arch/x86/annotate/instructions.c
> @@ -1,48 +1,29 @@
> // SPDX-License-Identifier: GPL-2.0

Could probably use a comment about how the table works
with suffixes.

> static struct ins x86__instructions[] = {
> { .name = "adc", .ops = &mov_ops, },
> - { .name = "adcb", .ops = &mov_ops, },
> - { .name = "adcl", .ops = &mov_ops, },
> { .name = "add", .ops = &mov_ops, },
> - { .name = "addl", .ops = &mov_ops, },
> - { .name = "addq", .ops = &mov_ops, },
> { .name = "addsd", .ops = &mov_ops, },
> - { .name = "addw", .ops = &mov_ops, },
> { .name = "and", .ops = &mov_ops, },
> - { .name = "andb", .ops = &mov_ops, },
> - { .name = "andl", .ops = &mov_ops, },
> { .name = "andpd", .ops = &mov_ops, },
> { .name = "andps", .ops = &mov_ops, },
> - { .name = "andq", .ops = &mov_ops, },
> - { .name = "andw", .ops = &mov_ops, },
> { .name = "bsr", .ops = &mov_ops, },
> { .name = "bt", .ops = &mov_ops, },
> { .name = "btr", .ops = &mov_ops, },
> { .name = "bts", .ops = &mov_ops, },
> - { .name = "btsq", .ops = &mov_ops, },
> { .name = "call", .ops = &call_ops, },
> - { .name = "callq", .ops = &call_ops, },
> { .name = "cmovbe", .ops = &mov_ops, },
> { .name = "cmove", .ops = &mov_ops, },
> { .name = "cmovae", .ops = &mov_ops, },
> { .name = "cmp", .ops = &mov_ops, },
> - { .name = "cmpb", .ops = &mov_ops, },
> - { .name = "cmpl", .ops = &mov_ops, },
> - { .name = "cmpq", .ops = &mov_ops, },
> - { .name = "cmpw", .ops = &mov_ops, },
> { .name = "cmpxch", .ops = &mov_ops, },
> { .name = "cmpxchg", .ops = &mov_ops, },
> { .name = "cs", .ops = &mov_ops, },
> { .name = "dec", .ops = &dec_ops, },
> - { .name = "decl", .ops = &dec_ops, },
> - { .name = "decq", .ops = &dec_ops, },
> { .name = "divsd", .ops = &mov_ops, },
> { .name = "divss", .ops = &mov_ops, },
> { .name = "gs", .ops = &mov_ops, },
> { .name = "imul", .ops = &mov_ops, },
> { .name = "inc", .ops = &dec_ops, },
> - { .name = "incl", .ops = &dec_ops, },
> - { .name = "incq", .ops = &dec_ops, },
> { .name = "ja", .ops = &jump_ops, },
> { .name = "jae", .ops = &jump_ops, },
> { .name = "jb", .ops = &jump_ops, },
> @@ -56,7 +37,6 @@ static struct ins x86__instructions[] = {
> { .name = "jl", .ops = &jump_ops, },
> { .name = "jle", .ops = &jump_ops, },
> { .name = "jmp", .ops = &jump_ops, },
> - { .name = "jmpq", .ops = &jump_ops, },
> { .name = "jna", .ops = &jump_ops, },
> { .name = "jnae", .ops = &jump_ops, },
> { .name = "jnb", .ops = &jump_ops, },
> @@ -83,49 +63,31 @@ static struct ins x86__instructions[] = {
> { .name = "mov", .ops = &mov_ops, },
> { .name = "movapd", .ops = &mov_ops, },
> { .name = "movaps", .ops = &mov_ops, },
> - { .name = "movb", .ops = &mov_ops, },
> { .name = "movdqa", .ops = &mov_ops, },
> { .name = "movdqu", .ops = &mov_ops, },
> - { .name = "movl", .ops = &mov_ops, },
> - { .name = "movq", .ops = &mov_ops, },
> { .name = "movsd", .ops = &mov_ops, },
> { .name = "movslq", .ops = &mov_ops, },
> { .name = "movss", .ops = &mov_ops, },
> { .name = "movupd", .ops = &mov_ops, },
> { .name = "movups", .ops = &mov_ops, },
> - { .name = "movw", .ops = &mov_ops, },
> { .name = "movzbl", .ops = &mov_ops, },
> { .name = "movzwl", .ops = &mov_ops, },
> { .name = "mulsd", .ops = &mov_ops, },
> { .name = "mulss", .ops = &mov_ops, },
> { .name = "nop", .ops = &nop_ops, },
> - { .name = "nopl", .ops = &nop_ops, },
> - { .name = "nopw", .ops = &nop_ops, },
> { .name = "or", .ops = &mov_ops, },
> - { .name = "orb", .ops = &mov_ops, },
> - { .name = "orl", .ops = &mov_ops, },
> { .name = "orps", .ops = &mov_ops, },
> - { .name = "orq", .ops = &mov_ops, },
> { .name = "pand", .ops = &mov_ops, },
> { .name = "paddq", .ops = &mov_ops, },
> { .name = "pcmpeqb", .ops = &mov_ops, },
> { .name = "por", .ops = &mov_ops, },
> - { .name = "rclb", .ops = &mov_ops, },
> - { .name = "rcll", .ops = &mov_ops, },
> + { .name = "rcl", .ops = &mov_ops, },
> { .name = "ret", .ops = &ret_ops, },
> - { .name = "retq", .ops = &ret_ops, },
> { .name = "sbb", .ops = &mov_ops, },
> - { .name = "sbbl", .ops = &mov_ops, },
> { .name = "sete", .ops = &mov_ops, },
> { .name = "sub", .ops = &mov_ops, },
> - { .name = "subl", .ops = &mov_ops, },
> - { .name = "subq", .ops = &mov_ops, },
> { .name = "subsd", .ops = &mov_ops, },
> - { .name = "subw", .ops = &mov_ops, },
> { .name = "test", .ops = &mov_ops, },
> - { .name = "testb", .ops = &mov_ops, },
> - { .name = "testl", .ops = &mov_ops, },
> - { .name = "testq", .ops = &mov_ops, },
> { .name = "tzcnt", .ops = &mov_ops, },
> { .name = "ucomisd", .ops = &mov_ops, },
> { .name = "ucomiss", .ops = &mov_ops, },
> @@ -139,11 +101,9 @@ static struct ins x86__instructions[] = {
> { .name = "vsubsd", .ops = &mov_ops, },
> { .name = "vucomisd", .ops = &mov_ops, },
> { .name = "xadd", .ops = &mov_ops, },
> - { .name = "xbeginl", .ops = &jump_ops, },
> - { .name = "xbeginq", .ops = &jump_ops, },
> + { .name = "xbegin", .ops = &jump_ops, },
> { .name = "xchg", .ops = &mov_ops, },
> { .name = "xor", .ops = &mov_ops, },
> - { .name = "xorb", .ops = &mov_ops, },
> { .name = "xorpd", .ops = &mov_ops, },
> { .name = "xorps", .ops = &mov_ops, },
> };

2023-05-24 16:31:35

by Namhyung Kim

[permalink] [raw]

Subject: Re: [PATCH 1/2] perf annotate: Handle x86 instruction suffix generally

Hi Adrian,

On Tue, May 23, 2023 at 11:11 PM Adrian Hunter <[email protected]> wrote:
>
> On 24/05/23 08:28, Namhyung Kim wrote:
> > Most of x86 instructions can have size suffix like b, w, l or q.
>
> (AT&T mnemonics)

Right, will update.

>
> > Instead of adding all these instructions in the table, we can handle
> > them in a general way. For example, it can try to find an instruction
> > as is. If not found, it'd try again without the suffix if it's one of
> > the allowed suffixes.
>
> I guess it might be possible that xyz is in the table but xyz<suffix>
> is a completely different instruction?

Then xyz<suffix> should be in the table too. The match without
suffix is a fallback so it should find the correct instruction first.

Thanks,
Namhyung

>
> >
> > Signed-off-by: Namhyung Kim <[email protected]>
> > ---
> > tools/perf/util/annotate.c | 22 ++++++++++++++++++++++
> > 1 file changed, 22 insertions(+)
> >
> > diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
> > index b708bbc49c9e..7f05f2a2aa83 100644
> > --- a/tools/perf/util/annotate.c
> > +++ b/tools/perf/util/annotate.c
> > @@ -70,6 +70,7 @@ struct arch {
> > struct ins_ops *(*associate_instruction_ops)(struct arch *arch, const char *name);
> > bool sorted_instructions;
> > bool initialized;
> > + const char *insn_suffix;
> > void *priv;
> > unsigned int model;
> > unsigned int family;
> > @@ -179,6 +180,7 @@ static struct arch architectures[] = {
> > .init = x86__annotate_init,
> > .instructions = x86__instructions,
> > .nr_instructions = ARRAY_SIZE(x86__instructions),
> > + .insn_suffix = "bwlq",
> > .objdump = {
> > .comment_char = '#',
> > },
> > @@ -720,6 +722,26 @@ static struct ins_ops *__ins__find(struct arch *arch, const char *name)
> > }
> >
> > ins = bsearch(name, arch->instructions, nmemb, sizeof(struct ins), ins__key_cmp);
> > + if (ins)
> > + return ins->ops;
> > +
> > + if (arch->insn_suffix) {
> > + char tmp[32];
> > + char suffix;
> > + size_t len = strlen(name);
> > +
> > + if (len == 0 || len >= sizeof(tmp))
> > + return NULL;
> > +
> > + suffix = name[len - 1];
> > + if (strchr(arch->insn_suffix, suffix) == NULL)
> > + return NULL;
> > +
> > + strcpy(tmp, name);
> > + tmp[len - 1] = '\0'; /* remove the suffix and check again */
> > +
> > + ins = bsearch(tmp, arch->instructions, nmemb, sizeof(struct ins), ins__key_cmp);
> > + }
> > return ins ? ins->ops : NULL;
> > }
> >
>

2023-05-24 16:32:55

by Namhyung Kim

[permalink] [raw]

Subject: Re: [PATCH 2/2] perf annotate: Remove x86 instructions with suffix

On Tue, May 23, 2023 at 11:15 PM >
> On 24/05/23 08:28, Namhyung Kim > > Not the suffix is handled >
> Not -> Now ?

Correct, will fix.

>
> >
> > Signed-off-by: Namhyung > > ---
> > tools/perf/arch/x86/annotate/instructions.c > > 1 file changed, 2 insertions(+), > >
> > diff --git a/tools/perf/arch/x86/ > > index 5c7bec25fee4..714fd8784d99 > > --- a/tools/perf/arch/x86/annotat > > +++ b/tools/perf/arch/x86/annotat > > @@ -1,48 +1,29 @@
> > // SPDX-License-Identifier: >
> Could probably use a comment > with suffixes.

Ok, I will add a comment.

Thanks for your review!
Namhyung

>
> > static struct ins x86__instructions[] > > { .name = "adc", > > - { .name = "adcb", > > - { .name = "adcl", > > { .name = "add", > > - { .name = "addl", > > - { .name = "addq", > > { .name = "addsd", > > - { .name = "addw", > > { .name = "and", > > - { .name = "andb", > > - { .name = "andl", > > { .name = "andpd", > > { .name = "andps", > > - { .name = "andq", > > - { .name = "andw", > > { .name = "bsr", > > { .name = "bt", > > { .name = "btr", > > { .name = "bts", > > - { .name = "btsq", > > { .name = "call", > > - { .name = "callq", > > { .name = "cmovbe", > > { .name = "cmove", > > { .name = "cmovae", > > { .name = "cmp", > > - { .name = "cmpb", > > - { .name = "cmpl", > > - { .name = "cmpq", > > - { .name = "cmpw", > > { .name = "cmpxch", > > { .name = "cmpxchg", > > { .name = "cs", > > { .name = "dec", > > - { .name = "decl", > > - { .name = "decq", > > { .name = "divsd", > > { .name = "divss", > > { .name = "gs", > > { .name = "imul", > > { .name = "inc", > > - { .name = "incl", > > - { .name = "incq", > > { .name = "ja", > > { .name = "jae", > > { .name = "jb", > > @@ -56,7 +37,6 @@ static > > { .name = "jl", > > { .name = "jle", > > { .name = "jmp", > > - { .name = "jmpq", > > { .name = "jna", > > { .name = "jnae", > > { .name = "jnb", > > @@ -83,49 +63,31 @@ static > > { .name = "mov", > > { .name = "movapd", > > { .name = "movaps", > > - { .name = "movb", > > { .name = "movdqa", > > { .name = "movdqu", > > - { .name = "movl", > > - { .name = "movq", > > { .name = "movsd", > > { .name = "movslq", > > { .name = "movss", > > { .name = "movupd", > > { .name = "movups", > > - { .name = "movw", > > { .name = "movzbl", > > { .name = "movzwl", > > { .name = "mulsd", > > { .name = "mulss", > > { .name = "nop", > > - { .name = "nopl", > > - { .name = "nopw", > > { .name = "or", > > - { .name = "orb", > > - { .name = "orl", > > { .name = "orps", > > - { .name = "orq", > > { .name = "pand", > > { .name = "paddq", > > { .name = "pcmpeqb", > > { .name = "por", > > - { .name = "rclb", > > - { .name = "rcll", > > + { .name = "rcl", > > { .name = "ret", > > - { .name = "retq", > > { .name = "sbb", > > - { .name = "sbbl", > > { .name = "sete", > > { .name = "sub", > > - { .name = "subl", > > - { .name = "subq", > > { .name = "subsd", > > - { .name = "subw", > > { .name = "test", > > - { .name = "testb", > > - { .name = "testl", > > - { .name = "testq", > > { .name = "tzcnt", > > { .name = "ucomisd", > > { .name = "ucomiss", > > @@ -139,11 +101,9 @@ static > > { .name = "vsubsd", > > { .name = "vucomisd", > > { .name = "xadd", > > - { .name = "xbeginl", > > - { .name = "xbeginq", > > + { .name = "xbegin", > > { .name = "xchg", > > { .name = "xor", > > - { .name = "xorb", > > { .name = "xorpd", > > { .name = "xorps", > > };
>

Adrian Hunter <[email protected]> wrote:
wrote:
in the general code. Let's get rid of them.
Kim <[email protected]>
| 44 +--------------------
42 deletions(-)
annotate/instructions.c b/tools/perf/arch/x86/annotate/instructions.c
100644
e/instructions.c
e/instructions.c
GPL-2.0
about how the table works
= {
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &call_ops, },
.ops = &call_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &dec_ops, },
.ops = &dec_ops, },
.ops = &dec_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &dec_ops, },
.ops = &dec_ops, },
.ops = &dec_ops, },
.ops = &jump_ops, },
.ops = &jump_ops, },
.ops = &jump_ops, },
struct ins x86__instructions[] = {
.ops = &jump_ops, },
.ops = &jump_ops, },
.ops = &jump_ops, },
.ops = &jump_ops, },
.ops = &jump_ops, },
.ops = &jump_ops, },
.ops = &jump_ops, },
struct ins x86__instructions[] = {
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &nop_ops, },
.ops = &nop_ops, },
.ops = &nop_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &ret_ops, },
.ops = &ret_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
struct ins x86__instructions[] = {
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &jump_ops, },
.ops = &jump_ops, },
.ops = &jump_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },
.ops = &mov_ops, },

2023-05-24 17:56:04

by Adrian Hunter

[permalink] [raw]

Subject: Re: [PATCH 1/2] perf annotate: Handle x86 instruction suffix generally

On 24/05/23 19:10, Namhyung Kim wrote:
> Hi Adrian,
>
> On Tue, May 23, 2023 at 11:11 PM Adrian Hunter <[email protected]> wrote:
>>
>> On 24/05/23 08:28, Namhyung Kim wrote:
>>> Most of x86 instructions can have size suffix like b, w, l or q.
>>
>> (AT&T mnemonics)
>
> Right, will update.
>
>>
>>> Instead of adding all these instructions in the table, we can handle
>>> them in a general way. For example, it can try to find an instruction
>>> as is. If not found, it'd try again without the suffix if it's one of
>>> the allowed suffixes.
>>
>> I guess it might be possible that xyz is in the table but xyz<suffix>
>> is a completely different instruction?
>
> Then xyz<suffix> should be in the table too. The match without
> suffix is a fallback so it should find the correct instruction first.

Right, so when adding xyz to the table, xyz<suffix> does not need
to be added as well if it is the same instruction but with different
operand sizes, but xyz<suffix> must be added as well if it is a
different instruction with different ops.

>
> Thanks,
> Namhyung
>
>
>>
>>>
>>> Signed-off-by: Namhyung Kim <[email protected]>
>>> ---
>>> tools/perf/util/annotate.c | 22 ++++++++++++++++++++++
>>> 1 file changed, 22 insertions(+)
>>>
>>> diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
>>> index b708bbc49c9e..7f05f2a2aa83 100644
>>> --- a/tools/perf/util/annotate.c
>>> +++ b/tools/perf/util/annotate.c
>>> @@ -70,6 +70,7 @@ struct arch {
>>> struct ins_ops *(*associate_instruction_ops)(struct arch *arch, const char *name);
>>> bool sorted_instructions;
>>> bool initialized;
>>> + const char *insn_suffix;
>>> void *priv;
>>> unsigned int model;
>>> unsigned int family;
>>> @@ -179,6 +180,7 @@ static struct arch architectures[] = {
>>> .init = x86__annotate_init,
>>> .instructions = x86__instructions,
>>> .nr_instructions = ARRAY_SIZE(x86__instructions),
>>> + .insn_suffix = "bwlq",
>>> .objdump = {
>>> .comment_char = '#',
>>> },
>>> @@ -720,6 +722,26 @@ static struct ins_ops *__ins__find(struct arch *arch, const char *name)
>>> }
>>>
>>> ins = bsearch(name, arch->instructions, nmemb, sizeof(struct ins), ins__key_cmp);
>>> + if (ins)
>>> + return ins->ops;
>>> +
>>> + if (arch->insn_suffix) {
>>> + char tmp[32];
>>> + char suffix;
>>> + size_t len = strlen(name);
>>> +
>>> + if (len == 0 || len >= sizeof(tmp))
>>> + return NULL;
>>> +
>>> + suffix = name[len - 1];
>>> + if (strchr(arch->insn_suffix, suffix) == NULL)
>>> + return NULL;
>>> +
>>> + strcpy(tmp, name);
>>> + tmp[len - 1] = '\0'; /* remove the suffix and check again */
>>> +
>>> + ins = bsearch(tmp, arch->instructions, nmemb, sizeof(struct ins), ins__key_cmp);
>>> + }
>>> return ins ? ins->ops : NULL;
>>> }
>>>
>>