2006-10-16 17:59:47

by Geert Uytterhoeven

[permalink] [raw]
Subject: [PATCH] CONFIG_TELCLOCK depends on X86


The telecom clock driver for MPBL0010 ATCA SBC depends on X86

Signed-Off-By: Geert Uytterhoeven <[email protected]>
Cc: Mark Gross <[email protected]>

--- linux-2.6.19-rc2/drivers/char/Kconfig.orig 2006-10-05 11:16:43.000000000 +0200
+++ linux-2.6.19-rc2/drivers/char/Kconfig 2006-10-16 09:26:10.000000000 +0200
@@ -1046,7 +1046,7 @@ source "drivers/char/tpm/Kconfig"

config TELCLOCK
tristate "Telecom clock driver for MPBL0010 ATCA SBC"
- depends on EXPERIMENTAL
+ depends on EXPERIMENTAL && X86
default n
help
The telecom clock device is specific to the MPBL0010 ATCA computer and

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds


2006-10-16 19:09:50

by Gross, Mark

[permalink] [raw]
Subject: RE: [PATCH] CONFIG_TELCLOCK depends on X86

This is good.

Thank you for doing this.

Acked-by: Mark Gross <[email protected]>

--mgross

>-----Original Message-----
>From: [email protected] [mailto:[email protected]]
>Sent: Monday, October 16, 2006 11:00 AM
>To: Linus Torvalds; Andrew Morton
>Cc: Linux Kernel Development; Gross, Mark
>Subject: [PATCH] CONFIG_TELCLOCK depends on X86
>
>
>The telecom clock driver for MPBL0010 ATCA SBC depends on X86
>
>Signed-Off-By: Geert Uytterhoeven <[email protected]>
>Cc: Mark Gross <[email protected]>
>
>--- linux-2.6.19-rc2/drivers/char/Kconfig.orig 2006-10-05
11:16:43.000000000 +0200
>+++ linux-2.6.19-rc2/drivers/char/Kconfig 2006-10-16
09:26:10.000000000 +0200
>@@ -1046,7 +1046,7 @@ source "drivers/char/tpm/Kconfig"
>
> config TELCLOCK
> tristate "Telecom clock driver for MPBL0010 ATCA SBC"
>- depends on EXPERIMENTAL
>+ depends on EXPERIMENTAL && X86
> default n
> help
> The telecom clock device is specific to the MPBL0010 ATCA
computer and
>
>--
>Geert Uytterhoeven -- There's lots of Linux beyond ia32 --
[email protected]
>
>In personal conversations with technical people, I call myself a
hacker. But
>when I'm talking to journalists I just say "programmer" or something
like that.
> -- Linus
Torvalds

2006-10-16 23:54:33

by Andrew Morton

[permalink] [raw]
Subject: Re: [PATCH] CONFIG_TELCLOCK depends on X86

On Mon, 16 Oct 2006 19:59:43 +0200 (CEST)
Geert Uytterhoeven <[email protected]> wrote:

> The telecom clock driver for MPBL0010 ATCA SBC depends on X86
>

But it compiles on other architectures (doesn't it?)

And perhaps sometime the hardware will be available on other architectures.

And there's benefit in being able to compile drivers on other architectures
- sometimes it will catch bugs.

IOW: what is the reason for making this change?

2006-10-17 08:11:47

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH] CONFIG_TELCLOCK depends on X86

On Mon, 16 Oct 2006, Andrew Morton wrote:
> On Mon, 16 Oct 2006 19:59:43 +0200 (CEST)
> Geert Uytterhoeven <[email protected]> wrote:
>
> > The telecom clock driver for MPBL0010 ATCA SBC depends on X86
> >
>
> But it compiles on other architectures (doesn't it?)
>
> And perhaps sometime the hardware will be available on other architectures.
>
> And there's benefit in being able to compile drivers on other architectures
> - sometimes it will catch bugs.
>
> IOW: what is the reason for making this change?

It does ISA I/O accesses and failed to build for most m68k platforms.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds