2014-06-02 19:36:09

by Stephen Boyd

Subject: Re: [PATCH v2 2/4] clk: qcom: Add APQ8084 Global Clock Controller support

On 05/31, Georgi Djakov wrote:
> +
> +static const struct qcom_reset_map gcc_apq8084_resets[] = {

> + [GCC_VENUS0_BCR] = { 0x1020 },

> + [GCC_VPU_BCR] = { 0x1400 },

> + [GCC_MDSS_BCR] = { 0x2300 },
> + [GCC_AVSYNC_BCR] = { 0x2400 },
> + [GCC_OXILI_BCR] = { 0x4020 },
> + [GCC_OXILICX_BCR] = { 0x4030 },
> + [GCC_OCMEMCX_BCR] = { 0x4050 },

These aren't in global clock control (looks like mmcc).

> +#define GCC_VENUS0_BCR 56

> +#define GCC_VPU_BCR 76


> +#define GCC_MDSS_BCR 93
> +#define GCC_AVSYNC_BCR 94
> +#define GCC_OXILI_BCR 95
> +#define GCC_OXILICX_BCR 96
> +#define GCC_OCMEMCX_BCR 97

Ditto

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation

2014-06-02 19:47:43

by Georgi Djakov

Subject: Re: [PATCH v2 2/4] clk: qcom: Add APQ8084 Global Clock Controller support

On 02.06.14, 22:36, Stephen Boyd wrote:
> On 05/31, Georgi Djakov wrote:
>> +
>> +static const struct qcom_reset_map gcc_apq8084_resets[] = {
>
>> + [GCC_VENUS0_BCR] = { 0x1020 },
>
>> + [GCC_VPU_BCR] = { 0x1400 },
>
>> + [GCC_MDSS_BCR] = { 0x2300 },
>> + [GCC_AVSYNC_BCR] = { 0x2400 },
>> + [GCC_OXILI_BCR] = { 0x4020 },
>> + [GCC_OXILICX_BCR] = { 0x4030 },
>> + [GCC_OCMEMCX_BCR] = { 0x4050 },
>
> These aren't in global clock control (looks like mmcc).
>

Will remove it!

>> +#define GCC_VENUS0_BCR 56
>
>> +#define GCC_VPU_BCR 76
>
>
>> +#define GCC_MDSS_BCR 93
>> +#define GCC_AVSYNC_BCR 94
>> +#define GCC_OXILI_BCR 95
>> +#define GCC_OXILICX_BCR 96
>> +#define GCC_OCMEMCX_BCR 97
>
> Ditto
>

Thank you for reviewing the patches!