The current documentation is incomplete wrt the intel_pstate internal
governors. The confusion comes from the general use internal governors
which also use the names performance and powersave. This patch
differentiates between the two sets of governors.
Cc: Dirk Brandewie <[email protected]>
Cc: Randy Dunlap <[email protected]>
Cc: Russell King <[email protected]>
Cc: Jesper Nilsson <[email protected]>
Cc: Viresh Kumar <[email protected]>
Cc: "David S. Miller" <[email protected]>
Cc: Ramkumar Ramachandra <[email protected]>
Cc: "Rafael J. Wysocki" <[email protected]>
Cc: [email protected]
Signed-off-by: Prarit Bhargava <[email protected]>
---
Documentation/cpu-freq/governors.txt | 2 +-
Documentation/cpu-freq/intel-pstate.txt | 8 ++++++++
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/Documentation/cpu-freq/governors.txt b/Documentation/cpu-freq/governors.txt
index 77ec215..c15aa75 100644
--- a/Documentation/cpu-freq/governors.txt
+++ b/Documentation/cpu-freq/governors.txt
@@ -36,7 +36,7 @@ Contents:
1. What Is A CPUFreq Governor?
==============================
-Most cpufreq drivers (in fact, all except one, longrun) or even most
+Most cpufreq drivers (except the intel_pstate and longrun) or even most
cpu frequency scaling algorithms only offer the CPU to be set to one
frequency. In order to offer dynamic frequency scaling, the cpufreq
core must be able to tell these drivers of a "target frequency". So
diff --git a/Documentation/cpu-freq/intel-pstate.txt b/Documentation/cpu-freq/intel-pstate.txt
index e742d21..ce894cc 100644
--- a/Documentation/cpu-freq/intel-pstate.txt
+++ b/Documentation/cpu-freq/intel-pstate.txt
@@ -9,6 +9,14 @@ assumed to implement internal governors by the cpufreq core. All the
logic for selecting the current P state is contained within the
driver; no external governor is used by the cpufreq core.
+The Intel P-state driver has two internal governors, performance and
+powersave. These governors differ from the general use governors of the
+same name in the kernel. The internal performance governor sets the
+max_perf_pct and min_perf_pct to 100; that is, the governor selects the
+highest available P state to maximize the performance of the core. The
+internal powersave governor, selects the appropriate P state based on the
+current load on the CPU.
+
Intel SandyBridge+ processors are supported.
New sysfs files for controlling P state selection have been added to
--
1.7.9.3
On 5 June 2014 19:13, Prarit Bhargava <[email protected]> wrote:
> The current documentation is incomplete wrt the intel_pstate internal
> governors. The confusion comes from the general use internal governors
> which also use the names performance and powersave. This patch
> differentiates between the two sets of governors.
>
> Cc: Dirk Brandewie <[email protected]>
> Cc: Randy Dunlap <[email protected]>
> Cc: Russell King <[email protected]>
> Cc: Jesper Nilsson <[email protected]>
> Cc: Viresh Kumar <[email protected]>
> Cc: "David S. Miller" <[email protected]>
> Cc: Ramkumar Ramachandra <[email protected]>
> Cc: "Rafael J. Wysocki" <[email protected]>
> Cc: [email protected]
>
> Signed-off-by: Prarit Bhargava <[email protected]>
> ---
> Documentation/cpu-freq/governors.txt | 2 +-
> Documentation/cpu-freq/intel-pstate.txt | 8 ++++++++
> 2 files changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/cpu-freq/governors.txt b/Documentation/cpu-freq/governors.txt
> index 77ec215..c15aa75 100644
> --- a/Documentation/cpu-freq/governors.txt
> +++ b/Documentation/cpu-freq/governors.txt
> @@ -36,7 +36,7 @@ Contents:
> 1. What Is A CPUFreq Governor?
> ==============================
>
> -Most cpufreq drivers (in fact, all except one, longrun) or even most
> +Most cpufreq drivers (except the intel_pstate and longrun) or even most
> cpu frequency scaling algorithms only offer the CPU to be set to one
> frequency. In order to offer dynamic frequency scaling, the cpufreq
> core must be able to tell these drivers of a "target frequency". So
> diff --git a/Documentation/cpu-freq/intel-pstate.txt b/Documentation/cpu-freq/intel-pstate.txt
> index e742d21..ce894cc 100644
> --- a/Documentation/cpu-freq/intel-pstate.txt
> +++ b/Documentation/cpu-freq/intel-pstate.txt
> @@ -9,6 +9,14 @@ assumed to implement internal governors by the cpufreq core. All the
> logic for selecting the current P state is contained within the
> driver; no external governor is used by the cpufreq core.
>
> +The Intel P-state driver has two internal governors, performance and
> +powersave. These governors differ from the general use governors of the
s/general use/generally used ??
> +same name in the kernel. The internal performance governor sets the
> +max_perf_pct and min_perf_pct to 100; that is, the governor selects the
> +highest available P state to maximize the performance of the core. The
> +internal powersave governor, selects the appropriate P state based on the
> +current load on the CPU.
> +
> Intel SandyBridge+ processors are supported.
>
> New sysfs files for controlling P state selection have been added to
> --
> 1.7.9.3
>
The current documentation is incomplete wrt the intel_pstate internal
governors. The confusion comes from the general use internal governors
which also use the names performance and powersave. This patch
differentiates between the two sets of governors.
Cc: Viresh Kumar <[email protected]>
Cc: Dirk Brandewie <[email protected]>
Cc: Randy Dunlap <[email protected]>
Cc: Russell King <[email protected]>
Cc: Jesper Nilsson <[email protected]>
Cc: Viresh Kumar <[email protected]>
Cc: "David S. Miller" <[email protected]>
Cc: Ramkumar Ramachandra <[email protected]>
Cc: "Rafael J. Wysocki" <[email protected]>
Cc: [email protected]
Signed-off-by: Prarit Bhargava <[email protected]>
[v2]: text update
---
Documentation/cpu-freq/governors.txt | 2 +-
Documentation/cpu-freq/intel-pstate.txt | 8 ++++++++
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/Documentation/cpu-freq/governors.txt b/Documentation/cpu-freq/governors.txt
index 77ec215..c15aa75 100644
--- a/Documentation/cpu-freq/governors.txt
+++ b/Documentation/cpu-freq/governors.txt
@@ -36,7 +36,7 @@ Contents:
1. What Is A CPUFreq Governor?
==============================
-Most cpufreq drivers (in fact, all except one, longrun) or even most
+Most cpufreq drivers (except the intel_pstate and longrun) or even most
cpu frequency scaling algorithms only offer the CPU to be set to one
frequency. In order to offer dynamic frequency scaling, the cpufreq
core must be able to tell these drivers of a "target frequency". So
diff --git a/Documentation/cpu-freq/intel-pstate.txt b/Documentation/cpu-freq/intel-pstate.txt
index e742d21..2edd8d9 100644
--- a/Documentation/cpu-freq/intel-pstate.txt
+++ b/Documentation/cpu-freq/intel-pstate.txt
@@ -9,6 +9,14 @@ assumed to implement internal governors by the cpufreq core. All the
logic for selecting the current P state is contained within the
driver; no external governor is used by the cpufreq core.
+The Intel P-state driver has two internal governors, performance and
+powersave. These governors differ from the generally used governors of the
+same name in the kernel. The internal performance governor sets the
+max_perf_pct and min_perf_pct to 100; that is, the governor selects the
+highest available P state to maximize the performance of the core. The
+internal powersave governor, selects the appropriate P state based on the
+current load on the CPU.
+
Intel SandyBridge+ processors are supported.
New sysfs files for controlling P state selection have been added to
--
1.7.9.3
On 06/05/2014 08:07 AM, Prarit Bhargava wrote:
> The current documentation is incomplete wrt the intel_pstate internal
> governors. The confusion comes from the general use internal governors
> which also use the names performance and powersave. This patch
> differentiates between the two sets of governors.
>
> Cc: Viresh Kumar <[email protected]>
> Cc: Dirk Brandewie <[email protected]>
> Cc: Randy Dunlap <[email protected]>
> Cc: Russell King <[email protected]>
> Cc: Jesper Nilsson <[email protected]>
> Cc: Viresh Kumar <[email protected]>
> Cc: "David S. Miller" <[email protected]>
> Cc: Ramkumar Ramachandra <[email protected]>
> Cc: "Rafael J. Wysocki" <[email protected]>
> Cc: [email protected]
> Signed-off-by: Prarit Bhargava <[email protected]>
>
Acked-by: Dirk Brandewie <[email protected]>
> [v2]: text update
> ---
> Documentation/cpu-freq/governors.txt | 2 +-
> Documentation/cpu-freq/intel-pstate.txt | 8 ++++++++
> 2 files changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/cpu-freq/governors.txt b/Documentation/cpu-freq/governors.txt
> index 77ec215..c15aa75 100644
> --- a/Documentation/cpu-freq/governors.txt
> +++ b/Documentation/cpu-freq/governors.txt
> @@ -36,7 +36,7 @@ Contents:
> 1. What Is A CPUFreq Governor?
> ==============================
>
> -Most cpufreq drivers (in fact, all except one, longrun) or even most
> +Most cpufreq drivers (except the intel_pstate and longrun) or even most
> cpu frequency scaling algorithms only offer the CPU to be set to one
> frequency. In order to offer dynamic frequency scaling, the cpufreq
> core must be able to tell these drivers of a "target frequency". So
> diff --git a/Documentation/cpu-freq/intel-pstate.txt b/Documentation/cpu-freq/intel-pstate.txt
> index e742d21..2edd8d9 100644
> --- a/Documentation/cpu-freq/intel-pstate.txt
> +++ b/Documentation/cpu-freq/intel-pstate.txt
> @@ -9,6 +9,14 @@ assumed to implement internal governors by the cpufreq core. All the
> logic for selecting the current P state is contained within the
> driver; no external governor is used by the cpufreq core.
>
> +The Intel P-state driver has two internal governors, performance and
> +powersave. These governors differ from the generally used governors of the
> +same name in the kernel. The internal performance governor sets the
> +max_perf_pct and min_perf_pct to 100; that is, the governor selects the
> +highest available P state to maximize the performance of the core. The
> +internal powersave governor, selects the appropriate P state based on the
> +current load on the CPU.
> +
> Intel SandyBridge+ processors are supported.
>
> New sysfs files for controlling P state selection have been added to
>
On 06/05/2014 08:07 AM, Prarit Bhargava wrote:
> The current documentation is incomplete wrt the intel_pstate internal
> governors. The confusion comes from the general use internal governors
> which also use the names performance and powersave. This patch
> differentiates between the two sets of governors.
>
> Cc: Viresh Kumar <[email protected]>
> Cc: Dirk Brandewie <[email protected]>
> Cc: Randy Dunlap <[email protected]>
> Cc: Russell King <[email protected]>
> Cc: Jesper Nilsson <[email protected]>
> Cc: Viresh Kumar <[email protected]>
> Cc: "David S. Miller" <[email protected]>
> Cc: Ramkumar Ramachandra <[email protected]>
> Cc: "Rafael J. Wysocki" <[email protected]>
> Cc: [email protected]
> Signed-off-by: Prarit Bhargava <[email protected]>
>
> [v2]: text update
> ---
> Documentation/cpu-freq/governors.txt | 2 +-
> Documentation/cpu-freq/intel-pstate.txt | 8 ++++++++
> 2 files changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/cpu-freq/governors.txt b/Documentation/cpu-freq/governors.txt
> index 77ec215..c15aa75 100644
> --- a/Documentation/cpu-freq/governors.txt
> +++ b/Documentation/cpu-freq/governors.txt
> @@ -36,7 +36,7 @@ Contents:
> 1. What Is A CPUFreq Governor?
> ==============================
>
> -Most cpufreq drivers (in fact, all except one, longrun) or even most
> +Most cpufreq drivers (except the intel_pstate and longrun) or even most
> cpu frequency scaling algorithms only offer the CPU to be set to one
> frequency. In order to offer dynamic frequency scaling, the cpufreq
> core must be able to tell these drivers of a "target frequency". So
> diff --git a/Documentation/cpu-freq/intel-pstate.txt b/Documentation/cpu-freq/intel-pstate.txt
> index e742d21..2edd8d9 100644
> --- a/Documentation/cpu-freq/intel-pstate.txt
> +++ b/Documentation/cpu-freq/intel-pstate.txt
> @@ -9,6 +9,14 @@ assumed to implement internal governors by the cpufreq core. All the
> logic for selecting the current P state is contained within the
> driver; no external governor is used by the cpufreq core.
>
> +The Intel P-state driver has two internal governors, performance and
> +powersave. These governors differ from the generally used governors of the
> +same name in the kernel. The internal performance governor sets the
> +max_perf_pct and min_perf_pct to 100; that is, the governor selects the
> +highest available P state to maximize the performance of the core. The
> +internal powersave governor, selects the appropriate P state based on the
no comma here ---------------^
> +current load on the CPU.
> +
> Intel SandyBridge+ processors are supported.
>
> New sysfs files for controlling P state selection have been added to
>
--
~Randy
The current documentation is incomplete wrt the intel_pstate internal
governors. The confusion comes from the general use internal governors
which also use the names performance and powersave. This patch
differentiates between the two sets of governors.
Cc: Viresh Kumar <[email protected]>
Cc: Dirk Brandewie <[email protected]>
Cc: Randy Dunlap <[email protected]>
Cc: Russell King <[email protected]>
Cc: Jesper Nilsson <[email protected]>
Cc: Viresh Kumar <[email protected]>
Cc: "David S. Miller" <[email protected]>
Cc: Ramkumar Ramachandra <[email protected]>
Cc: "Rafael J. Wysocki" <[email protected]>
Cc: [email protected]
Signed-off-by: Prarit Bhargava <[email protected]>
[v2]: text update
[v3]: text update
---
Documentation/cpu-freq/governors.txt | 2 +-
Documentation/cpu-freq/intel-pstate.txt | 8 ++++++++
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/Documentation/cpu-freq/governors.txt b/Documentation/cpu-freq/governors.txt
index 77ec215..c15aa75 100644
--- a/Documentation/cpu-freq/governors.txt
+++ b/Documentation/cpu-freq/governors.txt
@@ -36,7 +36,7 @@ Contents:
1. What Is A CPUFreq Governor?
==============================
-Most cpufreq drivers (in fact, all except one, longrun) or even most
+Most cpufreq drivers (except the intel_pstate and longrun) or even most
cpu frequency scaling algorithms only offer the CPU to be set to one
frequency. In order to offer dynamic frequency scaling, the cpufreq
core must be able to tell these drivers of a "target frequency". So
diff --git a/Documentation/cpu-freq/intel-pstate.txt b/Documentation/cpu-freq/intel-pstate.txt
index e742d21..7e9db8f 100644
--- a/Documentation/cpu-freq/intel-pstate.txt
+++ b/Documentation/cpu-freq/intel-pstate.txt
@@ -9,6 +9,14 @@ assumed to implement internal governors by the cpufreq core. All the
logic for selecting the current P state is contained within the
driver; no external governor is used by the cpufreq core.
+The Intel P-state driver has two internal governors, performance and
+powersave. These governors differ from the generally used governors of the
+same name in the kernel. The internal performance governor sets the
+max_perf_pct and min_perf_pct to 100; that is, the governor selects the
+highest available P state to maximize the performance of the core. The
+internal powersave governor selects the appropriate P state based on the
+current load on the CPU.
+
Intel SandyBridge+ processors are supported.
New sysfs files for controlling P state selection have been added to
--
1.7.9.3
On 5 June 2014 22:51, Prarit Bhargava <[email protected]> wrote:
> The current documentation is incomplete wrt the intel_pstate internal
> governors. The confusion comes from the general use internal governors
> which also use the names performance and powersave. This patch
> differentiates between the two sets of governors.
>
> Cc: Viresh Kumar <[email protected]>
> Cc: Dirk Brandewie <[email protected]>
> Cc: Randy Dunlap <[email protected]>
> Cc: Russell King <[email protected]>
> Cc: Jesper Nilsson <[email protected]>
> Cc: Viresh Kumar <[email protected]>
> Cc: "David S. Miller" <[email protected]>
> Cc: Ramkumar Ramachandra <[email protected]>
> Cc: "Rafael J. Wysocki" <[email protected]>
> Cc: [email protected]
> Signed-off-by: Prarit Bhargava <[email protected]>
>
> [v2]: text update
> [v3]: text update
This will get into 'git logs' :(, you should have placed those below the ---
on the next line.
In case we are going to do a resend of this please change subject to:
I have seen some commits where [v3] in $subject is pushed into the logs,
but I am not sure if that's the right way. Why would we need to
know which version went into the kernel? In case maintainer
picked the wrong version we can simply check the diff..
cpufreq: documentation/intel_pstate: Add a description of the
intel_pstate internal governors
Anyway, I think Rafael might do these changes himself. So
don't resend it unless he asks for..
> ---
> Documentation/cpu-freq/governors.txt | 2 +-
> Documentation/cpu-freq/intel-pstate.txt | 8 ++++++++
> 2 files changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/cpu-freq/governors.txt b/Documentation/cpu-freq/governors.txt
> index 77ec215..c15aa75 100644
> --- a/Documentation/cpu-freq/governors.txt
> +++ b/Documentation/cpu-freq/governors.txt
> @@ -36,7 +36,7 @@ Contents:
> 1. What Is A CPUFreq Governor?
> ==============================
>
> -Most cpufreq drivers (in fact, all except one, longrun) or even most
> +Most cpufreq drivers (except the intel_pstate and longrun) or even most
> cpu frequency scaling algorithms only offer the CPU to be set to one
> frequency. In order to offer dynamic frequency scaling, the cpufreq
> core must be able to tell these drivers of a "target frequency". So
> diff --git a/Documentation/cpu-freq/intel-pstate.txt b/Documentation/cpu-freq/intel-pstate.txt
> index e742d21..7e9db8f 100644
> --- a/Documentation/cpu-freq/intel-pstate.txt
> +++ b/Documentation/cpu-freq/intel-pstate.txt
> @@ -9,6 +9,14 @@ assumed to implement internal governors by the cpufreq core. All the
> logic for selecting the current P state is contained within the
> driver; no external governor is used by the cpufreq core.
>
> +The Intel P-state driver has two internal governors, performance and
> +powersave. These governors differ from the generally used governors of the
> +same name in the kernel. The internal performance governor sets the
> +max_perf_pct and min_perf_pct to 100; that is, the governor selects the
> +highest available P state to maximize the performance of the core. The
> +internal powersave governor selects the appropriate P state based on the
> +current load on the CPU.
> +
> Intel SandyBridge+ processors are supported.
>
> New sysfs files for controlling P state selection have been added to
Otherwise looks good:
Acked-by: Viresh Kumar <[email protected]>