2014-06-03 01:36:26

by Namhyung Kim

Subject: Re: [PATCH 2/4] perf tools: allow user to specify hardware breakpoint bp_len

Hi Jiri,

On Fri, 30 May 2014 15:39:06 +0200, Jiri Olsa wrote:
> On Thu, May 29, 2014 at 05:26:51PM +0200, Frederic Weisbecker wrote:
>> From: Jacob Shin <[email protected]>
>>
>> Currently bp_len is given a default value of 4. Allow user to override it:
>>
>> $ perf stat -e mem:0x1000/8
>> ^
>> bp_len
>>
>> If no value is given, it will default to 4 as it did before.
>
> Namhyung,
> both perf tols patches from this patchset mess up with hists
> tests.. I havent found any connection yet.. any idea? ;-)

So you already found the problem in the hpp->elide change and that's the
reason of the failure, right? :)

Thanks,
Namhyung

2014-06-03 11:55:39

by Jiri Olsa

Subject: Re: [PATCH 2/4] perf tools: allow user to specify hardware breakpoint bp_len

On Tue, Jun 03, 2014 at 10:36:22AM +0900, Namhyung Kim wrote:
> Hi Jiri,
>
> On Fri, 30 May 2014 15:39:06 +0200, Jiri Olsa wrote:
> > On Thu, May 29, 2014 at 05:26:51PM +0200, Frederic Weisbecker wrote:
> >> From: Jacob Shin <[email protected]>
> >>
> >> Currently bp_len is given a default value of 4. Allow user to override it:
> >>
> >> $ perf stat -e mem:0x1000/8
> >> ^
> >> bp_len
> >>
> >> If no value is given, it will default to 4 as it did before.
> >
> > Namhyung,
> > both perf tols patches from this patchset mess up with hists
> > tests.. I havent found any connection yet.. any idea? ;-)
>
> So you already found the problem in the hpp->elide change and that's the
> reason of the failure, right? :)

I haven't got a chance to test it yet.. but it looks like
thats the case.. I'll retest soon ;-)

jirka

2014-06-06 16:30:31

by Suthikulpanit, Suravee

Subject: Re: [PATCH 2/4] perf tools: allow user to specify hardware breakpoint bp_len

On 6/3/2014 6:55 AM, Jiri Olsa wrote:
> On Tue, Jun 03, 2014 at 10:36:22AM +0900, Namhyung Kim wrote:
>> Hi Jiri,
>>
>> On Fri, 30 May 2014 15:39:06 +0200, Jiri Olsa wrote:
>>> On Thu, May 29, 2014 at 05:26:51PM +0200, Frederic Weisbecker wrote:
>>>> From: Jacob Shin <[email protected]>
>>>>
>>>> Currently bp_len is given a default value of 4. Allow user to override it:
>>>>
>>>> $ perf stat -e mem:0x1000/8
>>>> ^
>>>> bp_len
>>>>
>>>> If no value is given, it will default to 4 as it did before.
>>>
>>> Namhyung,
>>> both perf tols patches from this patchset mess up with hists
>>> tests.. I havent found any connection yet.. any idea? ;-)
>>
>> So you already found the problem in the hpp->elide change and that's the
>> reason of the failure, right? :)
>
> I haven't got a chance to test it yet.. but it looks like
> thats the case.. I'll retest soon ;-)
>
> jirka
>
Anything I can do to help here?

Thanks,

Suravee