2014-06-07 11:09:36

by Fabian Frédérick

Subject: [PATCH 1/1] mm/zswap.c: add __init to zswap_entry_cache_destroy

zswap_entry_cache_destroy is only called by __init init_zswap

This patch also fixes function name
zswap_entry_cache_ s/destory/destroy

Cc: Seth Jennings <[email protected]>
Cc: [email protected]
Cc: Andrew Morton <[email protected]>
Signed-off-by: Fabian Frederick <[email protected]>
---
mm/zswap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/zswap.c b/mm/zswap.c
index aeaef0f..ab7fa0f 100644
--- a/mm/zswap.c
+++ b/mm/zswap.c
@@ -207,7 +207,7 @@ static int zswap_entry_cache_create(void)
return zswap_entry_cache == NULL;
}

-static void zswap_entry_cache_destory(void)
+static void __init zswap_entry_cache_destroy(void)
{
kmem_cache_destroy(zswap_entry_cache);
}
@@ -926,7 +926,7 @@ static int __init init_zswap(void)
pcpufail:
zswap_comp_exit();
compfail:
- zswap_entry_cache_destory();
+ zswap_entry_cache_destroy();
cachefail:
zbud_destroy_pool(zswap_pool);
error:
--
1.9.1

2014-06-07 13:56:16

by Seth Jennings

Subject: Re: [PATCH 1/1] mm/zswap.c: add __init to zswap_entry_cache_destroy

On Jun 7, 2014 6:08 AM, Fabian Frederick <[email protected]> wrote:
>
> zswap_entry_cache_destroy is only called by __init init_zswap
>
> This patch also fixes function name
> zswap_entry_cache_ s/destory/destroy

Thanks for the  improvement ☺

Acked-by <[email protected]>

>
> Cc: Seth Jennings <[email protected]>
> Cc: [email protected]
> Cc: Andrew Morton <[email protected]>
> Signed-off-by: Fabian Frederick <[email protected]>
> ---
> mm/zswap.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/zswap.c b/mm/zswap.c
> index aeaef0f..ab7fa0f 100644
> --- a/mm/zswap.c
> +++ b/mm/zswap.c
> @@ -207,7 +207,7 @@ static int zswap_entry_cache_create(void)
> return zswap_entry_cache == NULL;
> }
>
> -static void zswap_entry_cache_destory(void)
> +static void __init zswap_entry_cache_destroy(void)
> {
> kmem_cache_destroy(zswap_entry_cache);
> }
> @@ -926,7 +926,7 @@ static int __init init_zswap(void)
> pcpufail:
> zswap_comp_exit();
> compfail:
> - zswap_entry_cache_destory();
> + zswap_entry_cache_destroy();
> cachefail:
> zbud_destroy_pool(zswap_pool);
> error:
> --
> 1.9.1
>
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?