2014-06-09 10:26:30

by Srivatsa S. Bhat

[permalink] [raw]
Subject: [PATCH] PM / Documentation: Update Srivatsa S. Bhat's email address

My @linux.vnet.ibm.com email address is going to disappear soon, as I will be
beginning my M.S./PhD studies at MIT in a few months. So update my email
address in the documentation.

Signed-off-by: Srivatsa S. Bhat <[email protected]>
Signed-off-by: Srivatsa S. Bhat <[email protected]>
---

Documentation/power/suspend-and-cpuhotplug.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/power/suspend-and-cpuhotplug.txt b/Documentation/power/suspend-and-cpuhotplug.txt
index e13dafc..3813703 100644
--- a/Documentation/power/suspend-and-cpuhotplug.txt
+++ b/Documentation/power/suspend-and-cpuhotplug.txt
@@ -1,6 +1,6 @@
Interaction of Suspend code (S3) with the CPU hotplug infrastructure

- (C) 2011 Srivatsa S. Bhat <[email protected]>
+ (C) 2011-2014 Srivatsa S. Bhat <[email protected]>


I. How does the regular CPU hotplug code differ from how the Suspend-to-RAM


2014-06-09 10:32:29

by Viresh Kumar

[permalink] [raw]
Subject: Re: [PATCH] PM / Documentation: Update Srivatsa S. Bhat's email address

On 9 June 2014 15:54, Srivatsa S. Bhat <[email protected]> wrote:
> My @linux.vnet.ibm.com email address is going to disappear soon, as I will be
> beginning my M.S./PhD studies at MIT in a few months. So update my email
> address in the documentation.

Congratulations once again buddy!! We will surely miss you specially for
discussions around cpufreq stuff :( ..

> Signed-off-by: Srivatsa S. Bhat <[email protected]>
> Signed-off-by: Srivatsa S. Bhat <[email protected]>
> ---
>
> Documentation/power/suspend-and-cpuhotplug.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

That's it ? I am not sure if you are planning to send few more
mails like this, but these can all go as a single commit via
Andrew Morton...

Also see if you wanna update .mailmap

Here is how I moved, 10d8935 :)

I hope you don't need my Ack here :)

2014-06-09 10:48:47

by Srivatsa S. Bhat

[permalink] [raw]
Subject: Re: [PATCH] PM / Documentation: Update Srivatsa S. Bhat's email address

On 06/09/2014 04:02 PM, Viresh Kumar wrote:
> On 9 June 2014 15:54, Srivatsa S. Bhat <[email protected]> wrote:
>> My @linux.vnet.ibm.com email address is going to disappear soon, as I will be
>> beginning my M.S./PhD studies at MIT in a few months. So update my email
>> address in the documentation.
>
> Congratulations once again buddy!!

Thank you very much! :-)

> We will surely miss you specially for
> discussions around cpufreq stuff :( ..
>

Actually, I think I'll still be able to remain active on LKML, since the
area I'll be working on is going to be very closely related :-) So hopefully
I'll continue to have the opportunity to take part in our enlightening
discussions on the mailing lists :-)

>> Signed-off-by: Srivatsa S. Bhat <[email protected]>
>> Signed-off-by: Srivatsa S. Bhat <[email protected]>
>> ---
>>
>> Documentation/power/suspend-and-cpuhotplug.txt | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> That's it ? I am not sure if you are planning to send few more
> mails like this, but these can all go as a single commit via
> Andrew Morton...

Well, that's the only file that has my name/email-id on it ;-)

>
> Also see if you wanna update .mailmap
>
> Here is how I moved, 10d8935 :)
>

Ah, I see. I was not aware of the mailmap thing, thank you!

> I hope you don't need my Ack here :)
>

I guess I don't need it, but thanks a lot for your inputs! I'll send
an updated patch which updates the mailmap as well.

Regards,
Srivatsa S. Bhat

2014-06-09 11:11:23

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [PATCH] PM / Documentation: Update Srivatsa S. Bhat's email address

On Monday, June 09, 2014 03:54:49 PM Srivatsa S. Bhat wrote:
> My @linux.vnet.ibm.com email address is going to disappear soon, as I will be
> beginning my M.S./PhD studies at MIT in a few months.

Congratulations!

> So update my email address in the documentation.
>
> Signed-off-by: Srivatsa S. Bhat <[email protected]>
> Signed-off-by: Srivatsa S. Bhat <[email protected]>
> ---
>
> Documentation/power/suspend-and-cpuhotplug.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/power/suspend-and-cpuhotplug.txt b/Documentation/power/suspend-and-cpuhotplug.txt
> index e13dafc..3813703 100644
> --- a/Documentation/power/suspend-and-cpuhotplug.txt
> +++ b/Documentation/power/suspend-and-cpuhotplug.txt
> @@ -1,6 +1,6 @@
> Interaction of Suspend code (S3) with the CPU hotplug infrastructure
>
> - (C) 2011 Srivatsa S. Bhat <[email protected]>
> + (C) 2011-2014 Srivatsa S. Bhat <[email protected]>

I'm actually unsure if updating copyright notices like that is OK.

Yes, you're moving, but the address in the notice documents the status at
the time you added it.

You still can add a new copyright notice with the new address when you update
the document in the future. :-)

Updating the address where it is a "contact info" or in MAINTAINERS is a
different matter, of course.

Rafael

2014-06-09 11:25:33

by Srivatsa S. Bhat

[permalink] [raw]
Subject: Re: [PATCH] PM / Documentation: Update Srivatsa S. Bhat's email address

On 06/09/2014 04:58 PM, Rafael J. Wysocki wrote:
> On Monday, June 09, 2014 03:54:49 PM Srivatsa S. Bhat wrote:
>> My @linux.vnet.ibm.com email address is going to disappear soon, as I will be
>> beginning my M.S./PhD studies at MIT in a few months.
>
> Congratulations!
>

Thanks a lot! :-)

>> So update my email address in the documentation.
>>
>> Signed-off-by: Srivatsa S. Bhat <[email protected]>
>> Signed-off-by: Srivatsa S. Bhat <[email protected]>
>> ---
>>
>> Documentation/power/suspend-and-cpuhotplug.txt | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/power/suspend-and-cpuhotplug.txt b/Documentation/power/suspend-and-cpuhotplug.txt
>> index e13dafc..3813703 100644
>> --- a/Documentation/power/suspend-and-cpuhotplug.txt
>> +++ b/Documentation/power/suspend-and-cpuhotplug.txt
>> @@ -1,6 +1,6 @@
>> Interaction of Suspend code (S3) with the CPU hotplug infrastructure
>>
>> - (C) 2011 Srivatsa S. Bhat <[email protected]>
>> + (C) 2011-2014 Srivatsa S. Bhat <[email protected]>
>
> I'm actually unsure if updating copyright notices like that is OK.
>
> Yes, you're moving, but the address in the notice documents the status at
> the time you added it.
>

Oh, ok..

> You still can add a new copyright notice with the new address when you update
> the document in the future. :-)
>

Sure :-) For now, I'll just send a patch to update the copyright and extend
it to 2014 (for my IBM id), while that email-id is still in use.

But what about .mailmap? Can I add to that? I guess I can, since that's not
related to copyrights and it is meant to handle email-id changes and such.

> Updating the address where it is a "contact info" or in MAINTAINERS is a
> different matter, of course.
>

Ah, I see. Thank you!

Regards,
Srivatsa S. Bhat

2014-06-09 12:18:43

by Srivatsa S. Bhat

[permalink] [raw]
Subject: Re: [PATCH] PM / Documentation: Update Srivatsa S. Bhat's email address

On 06/09/2014 04:53 PM, Srivatsa S. Bhat wrote:

> But what about .mailmap? Can I add to that? I guess I can, since that's not
> related to copyrights and it is meant to handle email-id changes and such.
>

Ah, nevermind.. mailmap only helps if we want to update our name (if it was
mis-spelled in any of our commits) or if we want to attribute commits from
a different email id to a preferred one, in git-shortlog.

I don't want to do either of that (all my commits have the right name, and
I would prefer to retain the commit attributions to their respective email-ids).
So I won't touch mailmap at the moment.

Regards,
Srivatsa S. Bhat

2014-06-14 22:36:36

by Pavel Machek

[permalink] [raw]
Subject: company copyrights. Re: [PATCH] PM / Documentation: Update Srivatsa S. Bhat's email address

On Mon 2014-06-09 13:28:36, Rafael J. Wysocki wrote:
> On Monday, June 09, 2014 03:54:49 PM Srivatsa S. Bhat wrote:
> > My @linux.vnet.ibm.com email address is going to disappear soon, as I will be
> > beginning my M.S./PhD studies at MIT in a few months.
>
> Congratulations!
>
> > So update my email address in the documentation.
> >
> > Signed-off-by: Srivatsa S. Bhat <[email protected]>
> > Signed-off-by: Srivatsa S. Bhat <[email protected]>
> > ---
> >
> > Documentation/power/suspend-and-cpuhotplug.txt | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/power/suspend-and-cpuhotplug.txt b/Documentation/power/suspend-and-cpuhotplug.txt
> > index e13dafc..3813703 100644
> > --- a/Documentation/power/suspend-and-cpuhotplug.txt
> > +++ b/Documentation/power/suspend-and-cpuhotplug.txt
> > @@ -1,6 +1,6 @@
> > Interaction of Suspend code (S3) with the CPU hotplug infrastructure
> >
> > - (C) 2011 Srivatsa S. Bhat <[email protected]>
> > + (C) 2011-2014 Srivatsa S. Bhat <[email protected]>
>
> I'm actually unsure if updating copyright notices like that is OK.
>
> Yes, you're moving, but the address in the notice documents the status at
> the time you added it.

Well, invalid addresses in the comments are useless.

If copyright is _yours_, updating the address is ok.

If copyright is your company's, you should probably say that plainly, not
just by email address.

(C) 2011 IBM (Srivatsa...)

is what people do.

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

2014-06-15 22:39:24

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: company copyrights. Re: [PATCH] PM / Documentation: Update Srivatsa S. Bhat's email address

On Sunday, June 15, 2014 12:36:11 AM Pavel Machek wrote:
> On Mon 2014-06-09 13:28:36, Rafael J. Wysocki wrote:
> > On Monday, June 09, 2014 03:54:49 PM Srivatsa S. Bhat wrote:
> > > My @linux.vnet.ibm.com email address is going to disappear soon, as I will be
> > > beginning my M.S./PhD studies at MIT in a few months.
> >
> > Congratulations!
> >
> > > So update my email address in the documentation.
> > >
> > > Signed-off-by: Srivatsa S. Bhat <[email protected]>
> > > Signed-off-by: Srivatsa S. Bhat <[email protected]>
> > > ---
> > >
> > > Documentation/power/suspend-and-cpuhotplug.txt | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/Documentation/power/suspend-and-cpuhotplug.txt b/Documentation/power/suspend-and-cpuhotplug.txt
> > > index e13dafc..3813703 100644
> > > --- a/Documentation/power/suspend-and-cpuhotplug.txt
> > > +++ b/Documentation/power/suspend-and-cpuhotplug.txt
> > > @@ -1,6 +1,6 @@
> > > Interaction of Suspend code (S3) with the CPU hotplug infrastructure
> > >
> > > - (C) 2011 Srivatsa S. Bhat <[email protected]>
> > > + (C) 2011-2014 Srivatsa S. Bhat <[email protected]>
> >
> > I'm actually unsure if updating copyright notices like that is OK.
> >
> > Yes, you're moving, but the address in the notice documents the status at
> > the time you added it.
>
> Well, invalid addresses in the comments are useless.
>
> If copyright is _yours_, updating the address is ok.

It may be OK from the legal standpoint, but only as long as you change it to
your private address (that is, one that you own personally). Also it is
changing history retroactively which I don't really find helpful.

> If copyright is your company's, you should probably say that plainly, not
> just by email address.
>
> (C) 2011 IBM (Srivatsa...)
>
> is what people do.

Yes, that's the preferred way to do that.

Rafael

2014-06-16 07:03:26

by Pavel Machek

[permalink] [raw]
Subject: Re: company copyrights. Re: [PATCH] PM / Documentation: Update Srivatsa S. Bhat's email address

Hi!
> On Sunday, June 15, 2014 12:36:11 AM Pavel Machek wrote:
> > On Mon 2014-06-09 13:28:36, Rafael J. Wysocki wrote:
> > > On Monday, June 09, 2014 03:54:49 PM Srivatsa S. Bhat wrote:
> > > > My @linux.vnet.ibm.com email address is going to disappear soon, as I will be
> > > > beginning my M.S./PhD studies at MIT in a few months.
> > >
> > > Congratulations!
> > >
> > > > So update my email address in the documentation.
> > > >
> > > > Signed-off-by: Srivatsa S. Bhat <[email protected]>
> > > > Signed-off-by: Srivatsa S. Bhat <[email protected]>
> > > > ---
> > > >
> > > > Documentation/power/suspend-and-cpuhotplug.txt | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/Documentation/power/suspend-and-cpuhotplug.txt b/Documentation/power/suspend-and-cpuhotplug.txt
> > > > index e13dafc..3813703 100644
> > > > --- a/Documentation/power/suspend-and-cpuhotplug.txt
> > > > +++ b/Documentation/power/suspend-and-cpuhotplug.txt
> > > > @@ -1,6 +1,6 @@
> > > > Interaction of Suspend code (S3) with the CPU hotplug infrastructure
> > > >
> > > > - (C) 2011 Srivatsa S. Bhat <[email protected]>
> > > > + (C) 2011-2014 Srivatsa S. Bhat <[email protected]>
> > >
> > > I'm actually unsure if updating copyright notices like that is OK.
> > >
> > > Yes, you're moving, but the address in the notice documents the status at
> > > the time you added it.
> >
> > Well, invalid addresses in the comments are useless.
> >
> > If copyright is _yours_, updating the address is ok.
>
> It may be OK from the legal standpoint, but only as long as you change it to
> your private address (that is, one that you own personally). Also it is
> changing history retroactively which I don't really find helpful.

People do fix invalid email addresses. That's what normally done on
lkml. If people want to credit the companies at the same time, its
easy to add note "for IBM", "in cooperation with IBM" or something...

> > If copyright is your company's, you should probably say that plainly, not
> > just by email address.
> >
> > (C) 2011 IBM (Srivatsa...)
> >
> > is what people do.
>
> Yes, that's the preferred way to do that.

Agreed.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html