2014-06-10 11:46:21

by Tomasz Figa

[permalink] [raw]
Subject: Re: [PATCH v4 02/11] ARM: EXYNOS: Move cpufreq and cpuidle device registration to init_machine

Hi Pankaj,

On 10.05.2014 08:56, Pankaj Dubey wrote:
> As exynos_cpuidle_init and exynos_cpufreq_init function have just one lines
> of code for registering platform devices. We can move these lines to
> exynos_dt_machine_init and delete exynos_cpuidle_init and exynos_cpufreq_init
> function. This will help in reducing lines of code in exynos.c, making it
> more cleaner.
>
> Suggested-by: Tomasz Figa <[email protected]>
> Signed-off-by: Pankaj Dubey <[email protected]>
> ---
> arch/arm/mach-exynos/exynos.c | 19 ++++---------------
> 1 file changed, 4 insertions(+), 15 deletions(-)
>

Reviewed-by: Tomasz Figa <[email protected]>

Btw. This and other simple clean-up patches from this series could be
applied separately, without re-spinning them every time with this series.

Best regards,
Tomasz


2014-06-17 03:47:46

by Pankaj Dubey

[permalink] [raw]
Subject: RE: [PATCH v4 02/11] ARM: EXYNOS: Move cpufreq and cpuidle device registration to init_machine

Hi Tomasz,

> -----Original Message-----
>
> Hi Pankaj,
>
> On 10.05.2014 08:56, Pankaj Dubey wrote:
> > As exynos_cpuidle_init and exynos_cpufreq_init function have just one
> > lines of code for registering platform devices. We can move these
> > lines to exynos_dt_machine_init and delete exynos_cpuidle_init and
> > exynos_cpufreq_init function. This will help in reducing lines of code
> > in exynos.c, making it more cleaner.
> >
> > Suggested-by: Tomasz Figa <[email protected]>
> > Signed-off-by: Pankaj Dubey <[email protected]>
> > ---
> > arch/arm/mach-exynos/exynos.c | 19 ++++---------------
> > 1 file changed, 4 insertions(+), 15 deletions(-)
> >
>
> Reviewed-by: Tomasz Figa <[email protected]>
>

Thanks for review.

> Btw. This and other simple clean-up patches from this series could be
applied
> separately, without re-spinning them every time with this series.
>

OK, I will separate cleanup patches.

> Best regards,
> Tomasz

Thanks,
Pankaj Dubey