2014-06-17 14:29:17

by Jeff Liu

Subject: [PATCH 07/24] kernel: return actual error on param_sysfs_init

From: Jie Liu <[email protected]>

Return the actual error code if kset_create_and_add() failed

Cc: Andrew Morton <[email protected]>
Cc: Christoph Lameter <[email protected]>
Signed-off-by: Jie Liu <[email protected]>
---
kernel/params.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/kernel/params.c b/kernel/params.c
index 1e52ca2..a110987 100644
--- a/kernel/params.c
+++ b/kernel/params.c
@@ -928,10 +928,9 @@ struct kobj_type module_ktype = {
static int __init param_sysfs_init(void)
{
module_kset = kset_create_and_add("module", &module_uevent_ops, NULL);
- if (!module_kset) {
- printk(KERN_WARNING "%s (%d): error creating kset\n",
- __FILE__, __LINE__);
- return -ENOMEM;
+ if (IS_ERR(module_kset)) {
+ pr_warn("%s (%d): error creating kset\n", __FILE__, __LINE__);
+ return PTR_ERR(module_kset);
}
module_sysfs_initialized = 1;

--
1.8.3.2

2014-06-17 19:21:33

by Greg KH

Subject: Re: [PATCH 07/24] kernel: return actual error on param_sysfs_init

On Tue, Jun 17, 2014 at 10:29:07PM +0800, Jeff Liu wrote:
> From: Jie Liu <[email protected]>
>
> Return the actual error code if kset_create_and_add() failed
>
> Cc: Andrew Morton <[email protected]>
> Cc: Christoph Lameter <[email protected]>
> Signed-off-by: Jie Liu <[email protected]>
> ---
> kernel/params.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)

Andrew and Christoph, please do not take this patch.

thanks,

greg k-h