2014-06-17 14:30:49

by Jeff Liu

Subject: [PATCH 09/24] drivers/iommu: check actual error on iommu_init

From: Jie Liu <[email protected]>

kset_create_and_add() has been fixed to return the actual error
code ptr rather than NULL, so update iommu_init() to check the
return value via IS_ERR() accordingly.

Cc: Joerg Roedel <[email protected]>
Signed-off-by: Jie Liu <[email protected]>
---
drivers/iommu/iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index e5555fc..297b5ad 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -925,7 +925,7 @@ static int __init iommu_init(void)
ida_init(&iommu_group_ida);
mutex_init(&iommu_group_mutex);

- BUG_ON(!iommu_group_kset);
+ BUG_ON(IS_ERR(iommu_group_kset));

return 0;
}
--
1.8.3.2

2014-06-17 15:22:00

by Joerg Roedel

Subject: Re: [PATCH 09/24] drivers/iommu: check actual error on iommu_init

On Tue, Jun 17, 2014 at 10:29:19PM +0800, Jeff Liu wrote:
> From: Jie Liu <[email protected]>
>
> kset_create_and_add() has been fixed to return the actual error
> code ptr rather than NULL, so update iommu_init() to check the
> return value via IS_ERR() accordingly.
>
> Cc: Joerg Roedel <[email protected]>
> Signed-off-by: Jie Liu <[email protected]>

Acked-by: Joerg Roedel <[email protected]>

2014-06-17 19:20:33

by Greg Kroah-Hartman

Subject: Re: [PATCH 09/24] drivers/iommu: check actual error on iommu_init

On Tue, Jun 17, 2014 at 05:21:54PM +0200, Joerg Roedel wrote:
> On Tue, Jun 17, 2014 at 10:29:19PM +0800, Jeff Liu wrote:
> > From: Jie Liu <[email protected]>
> >
> > kset_create_and_add() has been fixed to return the actual error
> > code ptr rather than NULL, so update iommu_init() to check the
> > return value via IS_ERR() accordingly.
> >
> > Cc: Joerg Roedel <[email protected]>
> > Signed-off-by: Jie Liu <[email protected]>
>
> Acked-by: Joerg Roedel <[email protected]>

Nope, please do not take this patch, it is not needed and as the kset
call is not changing, it will be incorrect.

thanks,

greg k-h