2014-06-17 14:31:54

by Jeff Liu

Subject: [PATCH 04/24] powerpc: check/return actual error on sysfs functions

From: Jie Liu <[email protected]>

Cc: Benjamin Herrenschmidt <[email protected]>
Cc: Paul Mackerras <[email protected]>
Signed-off-by: Jie Liu <[email protected]>
---
arch/powerpc/platforms/powernv/opal-dump.c | 2 +-
arch/powerpc/platforms/powernv/opal-elog.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/powerpc/platforms/powernv/opal-dump.c b/arch/powerpc/platforms/powernv/opal-dump.c
index 788a197..e718baf 100644
--- a/arch/powerpc/platforms/powernv/opal-dump.c
+++ b/arch/powerpc/platforms/powernv/opal-dump.c
@@ -424,7 +424,7 @@ void __init opal_platform_dump_init(void)
int rc;

dump_kset = kset_create_and_add("dump", NULL, opal_kobj);
- if (!dump_kset) {
+ if (IS_ERR(dump_kset)) {
pr_warn("%s: Failed to create dump kset\n", __func__);
return;
}
diff --git a/arch/powerpc/platforms/powernv/opal-elog.c b/arch/powerpc/platforms/powernv/opal-elog.c
index 10268c4..09c1f6f 100644
--- a/arch/powerpc/platforms/powernv/opal-elog.c
+++ b/arch/powerpc/platforms/powernv/opal-elog.c
@@ -296,9 +296,9 @@ int __init opal_elog_init(void)
int rc = 0;

elog_kset = kset_create_and_add("elog", NULL, opal_kobj);
- if (!elog_kset) {
+ if (IS_ERR(elog_kset)) {
pr_warn("%s: failed to create elog kset\n", __func__);
- return -1;
+ return PTR_ERR(elog_kset);
}

rc = opal_notifier_register(&elog_nb);
--
1.8.3.2

2014-06-17 19:19:38

by Greg Kroah-Hartman

Subject: Re: [PATCH 04/24] powerpc: check/return actual error on sysfs functions

On Tue, Jun 17, 2014 at 10:31:09PM +0800, Jeff Liu wrote:
> From: Jie Liu <[email protected]>
>
> Cc: Benjamin Herrenschmidt <[email protected]>
> Cc: Paul Mackerras <[email protected]>
> Signed-off-by: Jie Liu <[email protected]>
> ---
> arch/powerpc/platforms/powernv/opal-dump.c | 2 +-
> arch/powerpc/platforms/powernv/opal-elog.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)

Ben and Paul, please do not take this patch, it is incorrect.

greg k-h

2014-06-24 02:35:11

by Benjamin Herrenschmidt

Subject: Re: [PATCH 04/24] powerpc: check/return actual error on sysfs functions

On Tue, 2014-06-17 at 12:23 -0700, Greg KH wrote:
> On Tue, Jun 17, 2014 at 10:31:09PM +0800, Jeff Liu wrote:
> > From: Jie Liu <[email protected]>
> >
> > Cc: Benjamin Herrenschmidt <[email protected]>
> > Cc: Paul Mackerras <[email protected]>
> > Signed-off-by: Jie Liu <[email protected]>
> > ---
> > arch/powerpc/platforms/powernv/opal-dump.c | 2 +-
> > arch/powerpc/platforms/powernv/opal-elog.c | 4 ++--
> > 2 files changed, 3 insertions(+), 3 deletions(-)
>
> Ben and Paul, please do not take this patch, it is incorrect.

Thanks, ignored :-)

Cheers,
Ben.