2014-06-19 21:04:06

by Federico Di Pierro

Subject: [PATCH] staging: iio: kernel style neatening

Hi!
I've finally found some spare time from my studies to sit back and try
again this eudyptula challenge task.
This is a very small patch that fixes 3 little coding style problems.
I'm using linux-next.

Signed-off-by: Federico Di Pierro <[email protected]>

--- linux/drivers/staging/iio/frequency/ad9832.c.orig 2014-06-02
17:26:12.929978122 +0200
+++ linux/drivers/staging/iio/frequency/ad9832.c 2014-06-02
19:34:57.129506826 +0200
@@ -57,7 +57,7 @@ static int ad9832_write_frequency(struct
}

static int ad9832_write_phase(struct ad9832_state *st,
- unsigned long addr, unsigned long phase)
+ unsigned long addr, unsigned long phase)
{
if (phase > (1 << AD9832_PHASE_BITS))
return -EINVAL;
@@ -72,10 +72,8 @@ static int ad9832_write_phase(struct ad9
return spi_sync(st->spi, &st->phase_msg);
}

-static ssize_t ad9832_write(struct device *dev,
- struct device_attribute *attr,
- const char *buf,
- size_t len)
+static ssize_t ad9832_write(struct device *dev, struct device_attribute
*attr,
+ const char *buf,size_t len)
{
struct iio_dev *indio_dev = dev_to_iio_dev(dev);
struct ad9832_state *st = iio_priv(indio_dev);
@@ -109,11 +107,11 @@ static ssize_t ad9832_write(struct devic
ret = spi_sync(st->spi, &st->msg);
break;
case AD9832_FREQ_SYM:
- if (val == 1)
+ if (val == 1) {
st->ctrl_fp |= AD9832_FREQ;
- else if (val == 0)
+ } else if (val == 0) {
st->ctrl_fp &= ~AD9832_FREQ;
- else {
+ } else {
ret = -EINVAL;
break;
}

--
Federico

2014-06-19 21:13:45

by Joe Perches

Subject: Re: [PATCH] staging: iio: kernel style neatening

On Thu, 2014-06-19 at 23:04 +0200, Federico Di Pierro wrote:
> This is a very small patch that fixes 3 little coding style problems.
> I'm using linux-next.

Hello Federico.

Your patch is word wrapped and can't be applied.

Please read Documentation/SubmittingPatches and
Documentation/email-clients.txt

Ideally, try to use git, git format-patch and
git send-email.

> --- linux/drivers/staging/iio/frequency/ad9832.c.orig 2014-06-02
> 17:26:12.929978122 +0200
> +++ linux/drivers/staging/iio/frequency/ad9832.c 2014-06-02
> 19:34:57.129506826 +0200