2014-06-20 07:29:42

by Tobias Klauser

Subject: [PATCH] m68knommu: Remove unnecessary prototype for kobjsize()

The prototype for kobjsize() is already defined in linux/mm.h which is
included where kobjsize() is used.

Signed-off-by: Tobias Klauser <[email protected]>
---
arch/m68k/include/asm/pgtable_no.h | 5 -----
1 file changed, 5 deletions(-)

diff --git a/arch/m68k/include/asm/pgtable_no.h b/arch/m68k/include/asm/pgtable_no.h
index c527fc2..11859b8 100644
--- a/arch/m68k/include/asm/pgtable_no.h
+++ b/arch/m68k/include/asm/pgtable_no.h
@@ -46,11 +46,6 @@ static inline int pte_file(pte_t pte) { return 0; }
#define ZERO_PAGE(vaddr) (virt_to_page(0))

/*
- * These would be in other places but having them here reduces the diffs.
- */
-extern unsigned int kobjsize(const void *objp);
-
-/*
* No page table caches to initialise.
*/
#define pgtable_cache_init() do { } while (0)
--
1.7.9.5

2014-06-20 14:21:59

by Greg Ungerer

Subject: Re: [PATCH] m68knommu: Remove unnecessary prototype for kobjsize()

Hi Tobias,

On 20/06/14 17:29, Tobias Klauser wrote:
> The prototype for kobjsize() is already defined in linux/mm.h which is
> included where kobjsize() is used.
>
> Signed-off-by: Tobias Klauser <[email protected]>

Thanks. I have added this to the m68knommu git tree, for-next branch.

Regards
Greg


> ---
> arch/m68k/include/asm/pgtable_no.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/arch/m68k/include/asm/pgtable_no.h b/arch/m68k/include/asm/pgtable_no.h
> index c527fc2..11859b8 100644
> --- a/arch/m68k/include/asm/pgtable_no.h
> +++ b/arch/m68k/include/asm/pgtable_no.h
> @@ -46,11 +46,6 @@ static inline int pte_file(pte_t pte) { return 0; }
> #define ZERO_PAGE(vaddr) (virt_to_page(0))
>
> /*
> - * These would be in other places but having them here reduces the diffs.
> - */
> -extern unsigned int kobjsize(const void *objp);
> -
> -/*
> * No page table caches to initialise.
> */
> #define pgtable_cache_init() do { } while (0)
>