2014-06-20 19:52:11

by Rasmus Villemoes

Subject: [PATCH] trivial: fs/btrfs/tree-log.c: Fix closing brace followed by if

Maybe "else if" was meant, but because of the goto out_unlock, it
doesn't make a difference. Anyway, I chose the "only whitespace" fix.

Signed-off-by: Rasmus Villemoes <[email protected]>
---
fs/btrfs/tree-log.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c
index 9e1f2cd..50af2b9 100644
--- a/fs/btrfs/tree-log.c
+++ b/fs/btrfs/tree-log.c
@@ -3980,7 +3980,8 @@ again:
if (ret < 0) {
err = ret;
goto out_unlock;
- } if (ret) {
+ }
+ if (ret) {
ins_nr = 0;
btrfs_release_path(path);
continue;
--
1.9.2

2014-06-20 20:30:10

by Josef Bacik

Subject: Re: [PATCH] trivial: fs/btrfs/tree-log.c: Fix closing brace followed by if

On 06/20/2014 12:51 PM, Rasmus Villemoes wrote:
> Maybe "else if" was meant, but because of the goto out_unlock, it
> doesn't make a difference. Anyway, I chose the "only whitespace" fix.
>
> Signed-off-by: Rasmus Villemoes <[email protected]>
> ---
> fs/btrfs/tree-log.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c
> index 9e1f2cd..50af2b9 100644
> --- a/fs/btrfs/tree-log.c
> +++ b/fs/btrfs/tree-log.c
> @@ -3980,7 +3980,8 @@ again:
> if (ret < 0) {
> err = ret;
> goto out_unlock;
> - } if (ret) {
> + }
> + if (ret) {
> ins_nr = 0;
> btrfs_release_path(path);
> continue;
>

Nope that's right, thanks,

Reviewed-by: Josef Bacik <[email protected]>