2014-06-24 05:50:29

by Wang Sheng-Hui

Subject: [PATCH] mm: update the description for madvise_remove

Currently, we have more filesystems supporting fallocate, e.g
ext4/btrfs. Remove the outdated comment for madvise_remove.

Signed-off-by: Wang Sheng-Hui <[email protected]>
---
mm/madvise.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/mm/madvise.c b/mm/madvise.c
index a402f8f..0938b30 100644
--- a/mm/madvise.c
+++ b/mm/madvise.c
@@ -292,9 +292,6 @@ static long madvise_dontneed(struct vm_area_struct *vma,
/*
* Application wants to free up the pages and associated backing store.
* This is effectively punching a hole into the middle of a file.
- *
- * NOTE: Currently, only shmfs/tmpfs is supported for this operation.
- * Other filesystems return -ENOSYS.
*/
static long madvise_remove(struct vm_area_struct *vma,
struct vm_area_struct **prev,
--
1.8.3.2

2014-06-24 06:02:42

by Naoya Horiguchi

Subject: Re: [PATCH] mm: update the description for madvise_remove

On Tue, Jun 24, 2014 at 01:49:31PM +0800, Wang Sheng-Hui wrote:
>
> Currently, we have more filesystems supporting fallocate, e.g
> ext4/btrfs. Remove the outdated comment for madvise_remove.
>
> Signed-off-by: Wang Sheng-Hui <[email protected]>

Looks good to me.

Reviewed-by: Naoya Horiguchi <[email protected]>

> ---
> mm/madvise.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/mm/madvise.c b/mm/madvise.c
> index a402f8f..0938b30 100644
> --- a/mm/madvise.c
> +++ b/mm/madvise.c
> @@ -292,9 +292,6 @@ static long madvise_dontneed(struct vm_area_struct *vma,
> /*
> * Application wants to free up the pages and associated backing store.
> * This is effectively punching a hole into the middle of a file.
> - *
> - * NOTE: Currently, only shmfs/tmpfs is supported for this operation.
> - * Other filesystems return -ENOSYS.
> */
> static long madvise_remove(struct vm_area_struct *vma,
> struct vm_area_struct **prev,
> --
> 1.8.3.2
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to [email protected]. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
>

2014-06-24 22:44:38

by David Rientjes

Subject: Re: [PATCH] mm: update the description for madvise_remove

On Tue, 24 Jun 2014, Wang Sheng-Hui wrote:

>
> Currently, we have more filesystems supporting fallocate, e.g
> ext4/btrfs. Remove the outdated comment for madvise_remove.
>
> Signed-off-by: Wang Sheng-Hui <[email protected]>
> ---
> mm/madvise.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/mm/madvise.c b/mm/madvise.c
> index a402f8f..0938b30 100644
> --- a/mm/madvise.c
> +++ b/mm/madvise.c
> @@ -292,9 +292,6 @@ static long madvise_dontneed(struct vm_area_struct *vma,
> /*
> * Application wants to free up the pages and associated backing store.
> * This is effectively punching a hole into the middle of a file.
> - *
> - * NOTE: Currently, only shmfs/tmpfs is supported for this operation.
> - * Other filesystems return -ENOSYS.
> */
> static long madvise_remove(struct vm_area_struct *vma,
> struct vm_area_struct **prev,

[For those without context: this patch has been merged into the -mm tree.]

This reference also exists in the man-page for madvise(2), are you
planning on removing it as well?