PM_OPP is a library used by several of the existing cpufreq drivers.
ARM IMX6Q cpufreq driver uses this library for its functionality.
Thus, it should be selected in Kconfig.
Reported-by: Ezequiel Garcia <[email protected]>
Signed-off-by: Nicolas Del Piano <[email protected]>
---
drivers/cpufreq/Kconfig.arm | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
index ebac671..8c5cf4b 100644
--- a/drivers/cpufreq/Kconfig.arm
+++ b/drivers/cpufreq/Kconfig.arm
@@ -104,6 +104,7 @@ config ARM_IMX6Q_CPUFREQ
tristate "Freescale i.MX6 cpufreq support"
depends on ARCH_MXC
depends on REGULATOR_ANATOP
+ select PM_OPP
help
This adds cpufreq driver support for Freescale i.MX6 series SoCs.
--
1.7.9.5
On 14 July 2014 03:29, Nicolas Del Piano <[email protected]> wrote:
> PM_OPP is a library used by several of the existing cpufreq drivers.
> ARM IMX6Q cpufreq driver uses this library for its functionality.
> Thus, it should be selected in Kconfig.
>
> Reported-by: Ezequiel Garcia <[email protected]>
> Signed-off-by: Nicolas Del Piano <[email protected]>
> ---
> drivers/cpufreq/Kconfig.arm | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> index ebac671..8c5cf4b 100644
> --- a/drivers/cpufreq/Kconfig.arm
> +++ b/drivers/cpufreq/Kconfig.arm
> @@ -104,6 +104,7 @@ config ARM_IMX6Q_CPUFREQ
> tristate "Freescale i.MX6 cpufreq support"
> depends on ARCH_MXC
> depends on REGULATOR_ANATOP
> + select PM_OPP
> help
> This adds cpufreq driver support for Freescale i.MX6 series SoCs.
Acked-by: Viresh Kumar <[email protected]>
Nico,
On 13 Jul 06:59 PM, Nicolas Del Piano wrote:
> PM_OPP is a library used by several of the existing cpufreq drivers.
> ARM IMX6Q cpufreq driver uses this library for its functionality.
> Thus, it should be selected in Kconfig.
>
> Reported-by: Ezequiel Garcia <[email protected]>
> Signed-off-by: Nicolas Del Piano <[email protected]>
Thanks for the patch. I have just a very minor nitpick to comment;
if you run a git log, you'll see the subject should be:
"cpufreq: imx6q: Select PM_OPP"
In general, it's better to see the recent commits to find out how to write
the commit title; each driver can have its own style.
--
Ezequiel Garcia, VanguardiaSur
http://www.vanguardiasur.com.ar
El 14/07/14 09:43, Ezequiel Garcia escribi?:
> Thanks for the patch. I have just a very minor nitpick to comment;
> if you run a git log, you'll see the subject should be:
>
> "cpufreq: imx6q: Select PM_OPP"
>
> In general, it's better to see the recent commits to find out how to write
> the commit title; each driver can have its own style.
Thanks for the advice Eze! I'll do it next time.
On Sunday, July 13, 2014 06:59:00 PM Nicolas Del Piano wrote:
> PM_OPP is a library used by several of the existing cpufreq drivers.
> ARM IMX6Q cpufreq driver uses this library for its functionality.
> Thus, it should be selected in Kconfig.
>
> Reported-by: Ezequiel Garcia <[email protected]>
> Signed-off-by: Nicolas Del Piano <[email protected]>
Fixed up the subject, applied. Thanks!
> ---
> drivers/cpufreq/Kconfig.arm | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> index ebac671..8c5cf4b 100644
> --- a/drivers/cpufreq/Kconfig.arm
> +++ b/drivers/cpufreq/Kconfig.arm
> @@ -104,6 +104,7 @@ config ARM_IMX6Q_CPUFREQ
> tristate "Freescale i.MX6 cpufreq support"
> depends on ARCH_MXC
> depends on REGULATOR_ANATOP
> + select PM_OPP
> help
> This adds cpufreq driver support for Freescale i.MX6 series SoCs.
>
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.