2014-07-23 04:27:45

by Nicholas Krause

Subject: [PATCH] microblaze: Add comment for defines

This adds a comment for and removes a fix me by labeling these
defines as memory cache definitions.

Signed-off-by: Nicholas Krause <[email protected]>
---
arch/microblaze/include/asm/pvr.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/microblaze/include/asm/pvr.h b/arch/microblaze/include/asm/pvr.h
index 4bbdb4c..441f3a0 100644
--- a/arch/microblaze/include/asm/pvr.h
+++ b/arch/microblaze/include/asm/pvr.h
@@ -186,7 +186,7 @@ struct pvr_s {
#define PVR_DCACHE_USE_FSL(_pvr) (_pvr.pvr[5] & PVR5_DCACHE_USE_FSL_MASK)
#define PVR_DCACHE_ALLOW_WR(_pvr) \
(_pvr.pvr[5] & PVR5_DCACHE_ALLOW_WR_MASK)
-/* FIXME two shifts on one line needs any comment */
+/* memory caches */
#define PVR_DCACHE_LINE_LEN(_pvr) \
(1 << ((_pvr.pvr[5] & PVR5_DCACHE_LINE_LEN_MASK) >> 21))
#define PVR_DCACHE_BYTE_SIZE(_pvr) \
--
1.9.1

2014-07-23 14:09:55

by Guenter Roeck

Subject: Re: [PATCH] microblaze: Add comment for defines

On 07/22/2014 09:27 PM, Nicholas Krause wrote:
> This adds a comment for and removes a fix me by labeling these
> defines as memory cache definitions.
>
> Signed-off-by: Nicholas Krause <[email protected]>
> ---
> arch/microblaze/include/asm/pvr.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/microblaze/include/asm/pvr.h b/arch/microblaze/include/asm/pvr.h
> index 4bbdb4c..441f3a0 100644
> --- a/arch/microblaze/include/asm/pvr.h
> +++ b/arch/microblaze/include/asm/pvr.h
> @@ -186,7 +186,7 @@ struct pvr_s {
> #define PVR_DCACHE_USE_FSL(_pvr) (_pvr.pvr[5] & PVR5_DCACHE_USE_FSL_MASK)
> #define PVR_DCACHE_ALLOW_WR(_pvr) \
> (_pvr.pvr[5] & PVR5_DCACHE_ALLOW_WR_MASK)
> -/* FIXME two shifts on one line needs any comment */
> +/* memory caches */

"two shifts on one line needs any comment"

You are not providing the comment asked for. The FIXME requests a comment explaining
why the double shift is needed, not just a random comment like the one you provided
that doesn't explain anything.

Guenter

> #define PVR_DCACHE_LINE_LEN(_pvr) \
> (1 << ((_pvr.pvr[5] & PVR5_DCACHE_LINE_LEN_MASK) >> 21))
> #define PVR_DCACHE_BYTE_SIZE(_pvr) \
>