2014-07-25 06:52:48

by Michal Simek

[permalink] [raw]

Subject: [PATCH v2] ARM: zynq: DT: Add CAN node

---

---

Attachments:

(No filename) (1.63 kB)
(No filename) (198.00 B)
Download all attachments

2014-07-25 15:00:37

by Soren Brinkmann

[permalink] [raw]

Subject: Re: [PATCH v2] ARM: zynq: DT: Add CAN node

---

On Fri, 2014-07-25 at 08:52AM +0200, Michal Simek wrote:
> Add node describing Zynq's CAN controller.
>
> Signed-off-by: Michal Simek <[email protected]>
> ---
>
> Changes in v2:
> - Add can1
> - Enable can0 for zc702
> - Use status property
>
> arch/arm/boot/dts/zynq-7000.dtsi | 26 +++++++++++++++++++++++++-
> arch/arm/boot/dts/zynq-zc702.dts | 4 ++++
> 2 files changed, 29 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
> index 366ca6434f54..983148111e3a 100644
> --- a/arch/arm/boot/dts/zynq-7000.dtsi
> +++ b/arch/arm/boot/dts/zynq-7000.dtsi
> @@ -71,7 +71,31 @@
> interrupts = <0 7 4>;
> interrupt-parent = <&intc>;
> clocks = <&clkc 12>;
> - };
> + };
> +
> + can0: can@e0008000 {
> + compatible = "xlnx,zynq-can-1.0";
> + status = "disabled";
> + clocks = <&clkc 19>, <&clkc 36>;
> + clock-names = "can_clk", "pclk";
> + reg = <0xe0008000 0x1000>;
> + interrupts = <0 28 4>;
> + interrupt-parent = <&intc>;
> + tx-fifo-depth = <0x40>;
> + rx-fifo-depth = <0x40>;
> + };
> +
> + can1: can@e0009000 {
> + compatible = "xlnx,zynq-can-1.0";
> + status = "disabled";
> + clocks = <&clkc 19>, <&clkc 36>;
The clocks for CAN1 must be outputs 20 and 37 of the clkc.

Sören

2014-07-28 09:18:13

by Michal Simek

[permalink] [raw]

Subject: Re: [PATCH v2] ARM: zynq: DT: Add CAN node

---

On 07/25/2014 05:00 PM, Sören Brinkmann wrote:
> On Fri, 2014-07-25 at 08:52AM +0200, Michal Simek wrote:
>> Add node describing Zynq's CAN controller.
>>
>> Signed-off-by: Michal Simek <[email protected]>
>> ---
>>
>> Changes in v2:
>> - Add can1
>> - Enable can0 for zc702
>> - Use status property
>>
>> arch/arm/boot/dts/zynq-7000.dtsi | 26 +++++++++++++++++++++++++-
>> arch/arm/boot/dts/zynq-zc702.dts | 4 ++++
>> 2 files changed, 29 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
>> index 366ca6434f54..983148111e3a 100644
>> --- a/arch/arm/boot/dts/zynq-7000.dtsi
>> +++ b/arch/arm/boot/dts/zynq-7000.dtsi
>> @@ -71,7 +71,31 @@
>> interrupts = <0 7 4>;
>> interrupt-parent = <&intc>;
>> clocks = <&clkc 12>;
>> - };
>> + };
>> +
>> + can0: can@e0008000 {
>> + compatible = "xlnx,zynq-can-1.0";
>> + status = "disabled";
>> + clocks = <&clkc 19>, <&clkc 36>;
>> + clock-names = "can_clk", "pclk";
>> + reg = <0xe0008000 0x1000>;
>> + interrupts = <0 28 4>;
>> + interrupt-parent = <&intc>;
>> + tx-fifo-depth = <0x40>;
>> + rx-fifo-depth = <0x40>;
>> + };
>> +
>> + can1: can@e0009000 {
>> + compatible = "xlnx,zynq-can-1.0";
>> + status = "disabled";
>> + clocks = <&clkc 19>, <&clkc 36>;
> The clocks for CAN1 must be outputs 20 and 37 of the clkc.

Fixed in v3.

Thanks,
Michal


--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: http://www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform

---

Attachments:

signature.asc (263.00 B)
OpenPGP digital signature