2014-07-28 13:28:34

by weiyj_lk

Subject: [PATCH -next] clk: sunxi: sun6i-apb0: fix sparse non static symbol warning

From: Wei Yongjun <[email protected]>

Fixes the following sparse warnings:

drivers/clk/sunxi/clk-sun6i-apb0.c:60:27: warning:
symbol 'sun6i_a31_apb0_clk_dt_ids' was not declared. Should it be static?

Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/clk/sunxi/clk-sun6i-apb0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/sunxi/clk-sun6i-apb0.c b/drivers/clk/sunxi/clk-sun6i-apb0.c
index 11f17c3..1fa2337 100644
--- a/drivers/clk/sunxi/clk-sun6i-apb0.c
+++ b/drivers/clk/sunxi/clk-sun6i-apb0.c
@@ -57,7 +57,7 @@ static int sun6i_a31_apb0_clk_probe(struct platform_device *pdev)
return of_clk_add_provider(np, of_clk_src_simple_get, clk);
}

-const struct of_device_id sun6i_a31_apb0_clk_dt_ids[] = {
+static const struct of_device_id sun6i_a31_apb0_clk_dt_ids[] = {
{ .compatible = "allwinner,sun6i-a31-apb0-clk" },
{ /* sentinel */ }
};

2014-07-28 15:50:28

by Emilio López

Subject: Re: [PATCH -next] clk: sunxi: sun6i-apb0: fix sparse non static symbol warning

Hi,

El 28/07/14 a las 10:27, [email protected] escibi?:
> From: Wei Yongjun <[email protected]>
>
> Fixes the following sparse warnings:
>
> drivers/clk/sunxi/clk-sun6i-apb0.c:60:27: warning:
> symbol 'sun6i_a31_apb0_clk_dt_ids' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <[email protected]>


I sent patches earlier today to fix this and other sparse warnings,
please see

http://lists.infradead.org/pipermail/linux-arm-kernel/2014-July/275680.html
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-July/275681.html

Cheers,

Emilio