2023-11-29 13:06:41

by Michael Walle

[permalink] [raw]
Subject: Re: [PATCH] mtd: spi-nor: issi: Add support for is25lp02g

Hi,

>> >> > Add support for issi is25lp02g.
>> >> >
>> >> > Verified on AMD-Xilinx versal platform and executed mtd_debug
>> >> > read/write test.
>> >> >
>> >> > Signed-off-by: Srikanth Boyapally <[email protected]>
>> >>
>> >> Based on a datasheet [0] I found online, this flash seems to have
>> >> SFDP.
>> >> And since you do not add any flash specific fixups, it likely does
>> >> not need an entry and would work fine with the generic flash driver.
>> >> Did you try using that? See [1] for more info on contribution
>> >> guidelines.
>> >>
>> >> [0] https://www.issi.com/WW/pdf/25LP-WP02GG.pdf
>> >> [1] https://lore.kernel.org/linux-mtd/20231123160721.64561-2-
>> >> [email protected]/
>> >>
>> > I ran mtd_debug read/write tests on this flash, without adding flash
>> > entry, it worked fine for me. Please ignore this patch.
>>
>> Great! Could you please still dump and post your SFDP just for us to
>> have more
>> SFDP of diferent flashes? See [1].
>>
> SFDP dump:
> versal-generic:/home/petalinux# hexdump -C
> /sys/bus/spi/devices/spi0.0/spi-nor/sfdp
> 00000000 53 46 44 50 06 01 01 ff 00 06 01 10 30 00 00 ff
> |SFDP........0...|
> 00000010 84 00 01 02 80 00 00 ff ff ff ff ff ff ff ff ff
> |................|
> 00000020 ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
> |................|
> 00000030 e5 20 fb ff ff ff ff 7f 44 eb 08 6b 08 3b 80 bb |.
> ......D..k.;..|
> 00000040 fe ff ff ff ff ff 00 ff ff ff 44 eb 0c 20 0f 52
> |..........D.. .R|
> 00000050 10 d8 00 ff 62 42 a9 00 82 64 02 e2 ec 8d 69 4c
> |....bB...d....iL|
> 00000060 7a 75 7a 75 f7 a2 d5 5c 4a c2 2c ff e8 30 fa a9
> |zuzu...\J.,..0..|
> 00000070 ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
> |................|
> 00000080 ff ee ff ff 21 5c dc ff |....!\..|
> 00000088

Thanks!

-michael