On Tue, 30 Sep 2014, Pramod Gurav wrote:
> Get rid of using return value from gpiochip_remove() as it returns
> void.
>
> Cc: Linus Walleij <[email protected]>
> Cc: Alexandre Courbot <[email protected]>
> Cc: Jiri Kosina <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
>
> Signed-off-by: Pramod Gurav <[email protected]>
I guess this depends on some other patch that hasn't gone to Linus yet,
right? As Linus' tree currently has this prototype:
int gpiochip_remove(struct gpio_chip *chip)
--
Jiri Kosina
SUSE Labs
On Wednesday 01 October 2014 12:48 PM, Jiri Kosina wrote:
>> > Get rid of using return value from gpiochip_remove() as it returns
>> > void.
>> >
>> > Cc: Linus Walleij <[email protected]>
>> > Cc: Alexandre Courbot <[email protected]>
>> > Cc: Jiri Kosina <[email protected]>
>> > Cc: [email protected]
>> > Cc: [email protected]
>> >
>> > Signed-off-by: Pramod Gurav <[email protected]>
> I guess this depends on some other patch that hasn't gone to Linus yet,
> right? As Linus' tree currently has this prototype:
>
> int gpiochip_remove(struct gpio_chip *chip)
Yes. It is yet to make it to linus's tree. But the change is there in
linux-next master branch.
Thanks
Pramod
On Wed, 1 Oct 2014, Pramod Gurav wrote:
> >> > Cc: Linus Walleij <[email protected]>
> >> > Cc: Alexandre Courbot <[email protected]>
> >> > Cc: Jiri Kosina <[email protected]>
> >> > Cc: [email protected]
> >> > Cc: [email protected]
> >> >
> >> > Signed-off-by: Pramod Gurav <[email protected]>
> > I guess this depends on some other patch that hasn't gone to Linus yet,
> > right? As Linus' tree currently has this prototype:
> >
> > int gpiochip_remove(struct gpio_chip *chip)
>
> Yes. It is yet to make it to linus's tree. But the change is there in
> linux-next master branch.
Alright. It probably makes most sense to take this patch together with the
prototype change in one pile (i.e. not through my tree).
For that purpose
Acked-by: Jiri Kosina <[email protected]>
--
Jiri Kosina
SUSE Labs
On Wednesday 01 October 2014 01:31 PM, Jiri Kosina wrote:
> On Wed, 1 Oct 2014, Pramod Gurav wrote:
>
>>>>> Cc: Linus Walleij <[email protected]>
>>>>> Cc: Alexandre Courbot <[email protected]>
>>>>> Cc: Jiri Kosina <[email protected]>
>>>>> Cc: [email protected]
>>>>> Cc: [email protected]
>>>>>
>>>>> Signed-off-by: Pramod Gurav <[email protected]>
>>> I guess this depends on some other patch that hasn't gone to Linus yet,
>>> right? As Linus' tree currently has this prototype:
>>>
>>> int gpiochip_remove(struct gpio_chip *chip)
>>
>> Yes. It is yet to make it to linus's tree. But the change is there in
>> linux-next master branch.
>
> Alright. It probably makes most sense to take this patch together with the
> prototype change in one pile (i.e. not through my tree).
>
> For that purpose
>
> Acked-by: Jiri Kosina <[email protected]>
Jiri,
Just realized when Linus told me these changes are already in his tree
as well as in mast of linux-tree. Sorry for spaming and late realizing this.
>