2013-10-12 04:15:34

by Michael Opdenacker

Subject: [PATCH] cpqarray: remove deprecated IRQF_DISABLED

This patch proposes to remove the use of the IRQF_DISABLED flag

It's a NOOP since 2.6.35 and it will be removed one day.

Signed-off-by: Michael Opdenacker <[email protected]>
---
drivers/block/cpqarray.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/cpqarray.c b/drivers/block/cpqarray.c
index 2b94403..370721e 100644
--- a/drivers/block/cpqarray.c
+++ b/drivers/block/cpqarray.c
@@ -406,7 +406,7 @@ static int cpqarray_register_ctlr(int i, struct pci_dev *pdev)
}
hba[i]->access.set_intr_mask(hba[i], 0);
if (request_irq(hba[i]->intr, do_ida_intr,
- IRQF_DISABLED|IRQF_SHARED, hba[i]->devname, hba[i]))
+ IRQF_SHARED, hba[i]->devname, hba[i]))
{
printk(KERN_ERR "cpqarray: Unable to get irq %d for %s\n",
hba[i]->intr, hba[i]->devname);
--
1.8.1.2

2013-10-14 22:19:04

by Mike Miller

Subject: RE: [PATCH] cpqarray: remove deprecated IRQF_DISABLED

> -----Original Message-----
> From: Michael Opdenacker [mailto:michael.opdenacker@free-
> electrons.com]
> Sent: Friday, October 11, 2013 11:15 PM
> To: [email protected]
> Cc: ISS StorageDev; [email protected]; Michael Opdenacker
> Subject: [PATCH] cpqarray: remove deprecated IRQF_DISABLED
>
> This patch proposes to remove the use of the IRQF_DISABLED flag
>
> It's a NOOP since 2.6.35 and it will be removed one day.

I plan to send a patch soon to remove cpqarray completely.

-- mikem

>
> Signed-off-by: Michael Opdenacker <michael.opdenacker@free-
> electrons.com>
> ---
> drivers/block/cpqarray.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/cpqarray.c b/drivers/block/cpqarray.c index
> 2b94403..370721e 100644
> --- a/drivers/block/cpqarray.c
> +++ b/drivers/block/cpqarray.c
> @@ -406,7 +406,7 @@ static int cpqarray_register_ctlr(int i, struct pci_dev
> *pdev)
> }
> hba[i]->access.set_intr_mask(hba[i], 0);
> if (request_irq(hba[i]->intr, do_ida_intr,
> - IRQF_DISABLED|IRQF_SHARED, hba[i]->devname, hba[i]))
> + IRQF_SHARED, hba[i]->devname, hba[i]))
> {
> printk(KERN_ERR "cpqarray: Unable to get irq %d for %s\n",
> hba[i]->intr, hba[i]->devname);
> --
> 1.8.1.2

2014-10-01 10:09:16

by Michael Opdenacker

Subject: Re: [PATCH] cpqarray: remove deprecated IRQF_DISABLED

Hi Mike,

On 10/15/2013 12:17 AM, Miller, Mike (OS Dev) wrote:
>
>> -----Original Message-----
>> From: Michael Opdenacker [mailto:michael.opdenacker@free-
>> electrons.com]
>> Sent: Friday, October 11, 2013 11:15 PM
>> To: [email protected]
>> Cc: ISS StorageDev; [email protected]; Michael Opdenacker
>> Subject: [PATCH] cpqarray: remove deprecated IRQF_DISABLED
>>
>> This patch proposes to remove the use of the IRQF_DISABLED flag
>>
>> It's a NOOP since 2.6.35 and it will be removed one day.
> I plan to send a patch soon to remove cpqarray completely.
>
> -- mikem

Any news? Would you like me to take care of this patch if you don't have
time? It would be with pleasure...

Michael.


--
Michael Opdenacker, CEO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
+33 484 258 098