2014-10-02 13:28:55

by Chen Gang

Subject: [PATCH] drivers/clocksource/Kconfig: Let SH_TIMER_CMT depend on HAS_IOMEM

SH_TIMER_CMT will use IO memory features which needs HAS_IOMEM, so need
depend on it. The related error (with allmodconfig under um):

CC drivers/clocksource/sh_cmt.o
drivers/clocksource/sh_cmt.c: In function 'sh_cmt_map_memory':
drivers/clocksource/sh_cmt.c:920:2: error: implicit declaration of function 'ioremap_nocache' [-Werror=implicit-function-declaration]
cmt->mapbase = ioremap_nocache(mem->start, resource_size(mem));
^
drivers/clocksource/sh_cmt.c:920:15: warning: assignment makes pointer from integer without a cast [enabled by default]
cmt->mapbase = ioremap_nocache(mem->start, resource_size(mem));
^
drivers/clocksource/sh_cmt.c: In function 'sh_cmt_setup':
drivers/clocksource/sh_cmt.c:1034:2: error: implicit declaration of function 'iounmap' [-Werror=implicit-function-declaration]
iounmap(cmt->mapbase);
^

Signed-off-by: Chen Gang <[email protected]>
---
drivers/clocksource/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index 82a2ebe..ee8aeeb 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -172,7 +172,7 @@ config SYS_SUPPORTS_EM_STI

config SH_TIMER_CMT
bool "Renesas CMT timer driver" if COMPILE_TEST
- depends on GENERIC_CLOCKEVENTS
+ depends on GENERIC_CLOCKEVENTS && HAS_IOMEM
default SYS_SUPPORTS_SH_CMT
help
This enables build of a clocksource and clockevent driver for
--
1.9.3

2014-10-02 13:35:08

by Chen Gang

Subject: Re: [PATCH] drivers/clocksource/Kconfig: Let SH_TIMER_CMT depend on HAS_IOMEM

Sorry, it also contents another items which need HAS_IOMEM in this
config file, this patch is incomplete, I shall send patch v2 for it.

Thanks.

On 10/2/14 21:34, Chen Gang wrote:
> SH_TIMER_CMT will use IO memory features which needs HAS_IOMEM, so need
> depend on it. The related error (with allmodconfig under um):
>
> CC drivers/clocksource/sh_cmt.o
> drivers/clocksource/sh_cmt.c: In function 'sh_cmt_map_memory':
> drivers/clocksource/sh_cmt.c:920:2: error: implicit declaration of function 'ioremap_nocache' [-Werror=implicit-function-declaration]
> cmt->mapbase = ioremap_nocache(mem->start, resource_size(mem));
> ^
> drivers/clocksource/sh_cmt.c:920:15: warning: assignment makes pointer from integer without a cast [enabled by default]
> cmt->mapbase = ioremap_nocache(mem->start, resource_size(mem));
> ^
> drivers/clocksource/sh_cmt.c: In function 'sh_cmt_setup':
> drivers/clocksource/sh_cmt.c:1034:2: error: implicit declaration of function 'iounmap' [-Werror=implicit-function-declaration]
> iounmap(cmt->mapbase);
> ^
>
> Signed-off-by: Chen Gang <[email protected]>
> ---
> drivers/clocksource/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index 82a2ebe..ee8aeeb 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -172,7 +172,7 @@ config SYS_SUPPORTS_EM_STI
>
> config SH_TIMER_CMT
> bool "Renesas CMT timer driver" if COMPILE_TEST
> - depends on GENERIC_CLOCKEVENTS
> + depends on GENERIC_CLOCKEVENTS && HAS_IOMEM
> default SYS_SUPPORTS_SH_CMT
> help
> This enables build of a clocksource and clockevent driver for
>

--
Chen Gang

Open, share, and attitude like air, water, and life which God blessed