2014-10-03 22:44:59

by Anssi Hannula

[permalink] [raw]
Subject: iio commit dates in future (was: Re: [PATCH] iio: adc: xilinx-xadc: assign auxiliary channels address correctly)

13.09.2014, 23:04, Jonathan Cameron kirjoitti:
> On 12/09/14 18:25, Lars-Peter Clausen wrote:
>> On 09/11/2014 10:55 AM, Subbaraya Sundeep Bhatta wrote:
>>> This patch fixes incorrect logic for assigning address
>>> to auxiliary channels of xilinx xadc.
>>>
>>> Signed-off-by: Subbaraya Sundeep Bhatta <[email protected]>
>>
>> Acked-by: Lars-Peter Clausen <[email protected]>
> Applied to the fixes-togreg branch of iio.git and flagged
> for stable.

Something weird seems to have happened with this commit and at least a
few others:
1887e724e2 "iio: adc: xilinx-xadc: assign auxiliary channels address
correctly"
d4f51956ac "iio: adc: at91: don't use the last converted data register"
a31d092899 "iio:magnetometer: bugfix magnetometers gain values".

They all have their Date in the future (up to Nov 2014), looks to me
like month and day got swapped for some reason.

Not a big issue I guess, but worth looking into if it is something in
your workflow causing this :)

Noticed these strange Dates while looking at Greg's stable-queue repo.

--
Anssi Hannula


2014-10-04 10:17:25

by Jonathan Cameron

[permalink] [raw]
Subject: Re: iio commit dates in future

On 03/10/14 23:34, Anssi Hannula wrote:
> 13.09.2014, 23:04, Jonathan Cameron kirjoitti:
>> On 12/09/14 18:25, Lars-Peter Clausen wrote:
>>> On 09/11/2014 10:55 AM, Subbaraya Sundeep Bhatta wrote:
>>>> This patch fixes incorrect logic for assigning address
>>>> to auxiliary channels of xilinx xadc.
>>>>
>>>> Signed-off-by: Subbaraya Sundeep Bhatta <[email protected]>
>>>
>>> Acked-by: Lars-Peter Clausen <[email protected]>
>> Applied to the fixes-togreg branch of iio.git and flagged
>> for stable.
>
> Something weird seems to have happened with this commit and at least a
> few others:
> 1887e724e2 "iio: adc: xilinx-xadc: assign auxiliary channels address
> correctly"
> d4f51956ac "iio: adc: at91: don't use the last converted data register"
> a31d092899 "iio:magnetometer: bugfix magnetometers gain values".
>
> They all have their Date in the future (up to Nov 2014), looks to me
> like month and day got swapped for some reason.
>
> Not a big issue I guess, but worth looking into if it is something in
> your workflow causing this :)
>
> Noticed these strange Dates while looking at Greg's stable-queue repo.
>
I have a suspicion that this is to do with the fact I use thunderbird to
manage my email and save it out as plain text. I'm using the import
export tools package on top of thunderbird (as it gives a cleaner result)
but it is using numeric dates. Which git am is happy with, but apparently
it isn't coping well with American date formats vs mine. Superficially
looks like this is fine if I use the much more verbose alternative of
saving as an eml file and using that...

There are some dates that have by coincidence jumped a fair way back into
the past as well.

I did notice an incidence of this a few months back but thought it was just
a one off. Thanks for bringing it up Anssi!

Jonathan