From: Hao Liang <[email protected]>
Date: Wed, 1 Oct 2014 14:08:28 +0800
> I double-check my patch and the ->mac->xxx calls are still under the lock.
> I think that lock is trying to protect priv struct and related data, so i
> just remove some functions have no bearing on priv struct.
It's preventing parallel invocations of the ->mac->xxx calls.
The other instances are in device open/close, where RTNL semaphore is
held, and no other code paths in the driver can be active.
You need the lock.
Hello Hao Liang
On 10/1/2014 7:45 PM, David Miller wrote:
> From: Hao Liang <[email protected]>
> Date: Wed, 1 Oct 2014 14:08:28 +0800
>
>> I double-check my patch and the ->mac->xxx calls are still under the lock.
>> I think that lock is trying to protect priv struct and related data, so i
>> just remove some functions have no bearing on priv struct.
>
> It's preventing parallel invocations of the ->mac->xxx calls.
>
> The other instances are in device open/close, where RTNL semaphore is
> held, and no other code paths in the driver can be active.
>
> You need the lock.
Do you have a new patch for this problem after David's advice?
I am reviewing the patches sent some weeks ago for driver looking
and I can also try to fix this in case of you have no news.
Let me know,
Regards,
peppe