2014-10-20 00:57:14

by Gerb Stralko

[permalink] [raw]
Subject: [PATCH] staging : lustre : Fixed static symbol sparse warnings

Signed-off-by: Jerry Stralko <[email protected]>
---
drivers/staging/lustre/lnet/lnet/lib-move.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/lustre/lnet/lnet/lib-move.c b/drivers/staging/lustre/lnet/lnet/lib-move.c
index 4b9567d..5754725 100644
--- a/drivers/staging/lustre/lnet/lnet/lib-move.c
+++ b/drivers/staging/lustre/lnet/lnet/lib-move.c
@@ -561,7 +561,7 @@ lnet_extract_kiov(int dst_niov, lnet_kiov_t *dst,
}
EXPORT_SYMBOL(lnet_extract_kiov);

-void
+static void
lnet_ni_recv(lnet_ni_t *ni, void *private, lnet_msg_t *msg, int delayed,
unsigned int offset, unsigned int mlen, unsigned int rlen)
{
@@ -599,7 +599,7 @@ lnet_ni_recv(lnet_ni_t *ni, void *private, lnet_msg_t *msg, int delayed,
lnet_finalize(ni, msg, rc);
}

-void
+static void
lnet_setpayloadbuffer(lnet_msg_t *msg)
{
lnet_libmd_t *md = msg->msg_md;
@@ -639,7 +639,7 @@ lnet_prep_send(lnet_msg_t *msg, int type, lnet_process_id_t target,
msg->msg_hdr.payload_length = cpu_to_le32(len);
}

-void
+static void
lnet_ni_send(lnet_ni_t *ni, lnet_msg_t *msg)
{
void *priv = msg->msg_private;
@@ -654,7 +654,7 @@ lnet_ni_send(lnet_ni_t *ni, lnet_msg_t *msg)
lnet_finalize(ni, msg, rc);
}

-int
+static int
lnet_ni_eager_recv(lnet_ni_t *ni, lnet_msg_t *msg)
{
int rc;
@@ -679,7 +679,7 @@ lnet_ni_eager_recv(lnet_ni_t *ni, lnet_msg_t *msg)
}

/* NB: caller shall hold a ref on 'lp' as I'd drop lnet_net_lock */
-void
+static void
lnet_ni_query_locked(lnet_ni_t *ni, lnet_peer_t *lp)
{
unsigned long last_alive = 0;
@@ -731,7 +731,7 @@ lnet_peer_is_alive(lnet_peer_t *lp, unsigned long now)

/* NB: returns 1 when alive, 0 when dead, negative when error;
* may drop the lnet_net_lock */
-int
+static int
lnet_peer_alive_locked(lnet_peer_t *lp)
{
unsigned long now = cfs_time_current();
@@ -871,7 +871,7 @@ lnet_post_send_locked(lnet_msg_t *msg, int do_send)
}


-lnet_rtrbufpool_t *
+static lnet_rtrbufpool_t *
lnet_msg2bufpool(lnet_msg_t *msg)
{
lnet_rtrbufpool_t *rbp;
@@ -891,7 +891,7 @@ lnet_msg2bufpool(lnet_msg_t *msg)
return rbp;
}

-int
+static int
lnet_post_routed_recv_locked(lnet_msg_t *msg, int do_recv)
{
/* lnet_parse is going to lnet_net_unlock immediately after this, so it
--
1.9.3


2014-10-24 18:40:07

by Gerb Stralko

[permalink] [raw]
Subject: Re: [PATCH] staging : lustre : Fixed static symbol sparse warnings

On 10/19/2014 08:56 PM, Jerry Stralko wrote:
> Signed-off-by: Jerry Stralko <[email protected]>
> ---
> drivers/staging/lustre/lnet/lnet/lib-move.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/lustre/lnet/lnet/lib-move.c b/drivers/staging/lustre/lnet/lnet/lib-move.c
> index 4b9567d..5754725 100644
> --- a/drivers/staging/lustre/lnet/lnet/lib-move.c
> +++ b/drivers/staging/lustre/lnet/lnet/lib-move.c
> @@ -561,7 +561,7 @@ lnet_extract_kiov(int dst_niov, lnet_kiov_t *dst,
> }
> EXPORT_SYMBOL(lnet_extract_kiov);
>
> -void
> +static void
> lnet_ni_recv(lnet_ni_t *ni, void *private, lnet_msg_t *msg, int delayed,
> unsigned int offset, unsigned int mlen, unsigned int rlen)
> {
> @@ -599,7 +599,7 @@ lnet_ni_recv(lnet_ni_t *ni, void *private, lnet_msg_t *msg, int delayed,
> lnet_finalize(ni, msg, rc);
> }
>
> -void
> +static void
> lnet_setpayloadbuffer(lnet_msg_t *msg)
> {
> lnet_libmd_t *md = msg->msg_md;
> @@ -639,7 +639,7 @@ lnet_prep_send(lnet_msg_t *msg, int type, lnet_process_id_t target,
> msg->msg_hdr.payload_length = cpu_to_le32(len);
> }
>
> -void
> +static void
> lnet_ni_send(lnet_ni_t *ni, lnet_msg_t *msg)
> {
> void *priv = msg->msg_private;
> @@ -654,7 +654,7 @@ lnet_ni_send(lnet_ni_t *ni, lnet_msg_t *msg)
> lnet_finalize(ni, msg, rc);
> }
>
> -int
> +static int
> lnet_ni_eager_recv(lnet_ni_t *ni, lnet_msg_t *msg)
> {
> int rc;
> @@ -679,7 +679,7 @@ lnet_ni_eager_recv(lnet_ni_t *ni, lnet_msg_t *msg)
> }
>
> /* NB: caller shall hold a ref on 'lp' as I'd drop lnet_net_lock */
> -void
> +static void
> lnet_ni_query_locked(lnet_ni_t *ni, lnet_peer_t *lp)
> {
> unsigned long last_alive = 0;
> @@ -731,7 +731,7 @@ lnet_peer_is_alive(lnet_peer_t *lp, unsigned long now)
>
> /* NB: returns 1 when alive, 0 when dead, negative when error;
> * may drop the lnet_net_lock */
> -int
> +static int
> lnet_peer_alive_locked(lnet_peer_t *lp)
> {
> unsigned long now = cfs_time_current();
> @@ -871,7 +871,7 @@ lnet_post_send_locked(lnet_msg_t *msg, int do_send)
> }
>
>
> -lnet_rtrbufpool_t *
> +static lnet_rtrbufpool_t *
> lnet_msg2bufpool(lnet_msg_t *msg)
> {
> lnet_rtrbufpool_t *rbp;
> @@ -891,7 +891,7 @@ lnet_msg2bufpool(lnet_msg_t *msg)
> return rbp;
> }
>
> -int
> +static int
> lnet_post_routed_recv_locked(lnet_msg_t *msg, int do_recv)
> {
> /* lnet_parse is going to lnet_net_unlock immediately after this, so it
Ping?

2014-10-29 15:41:51

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] staging : lustre : Fixed static symbol sparse warnings

On Sat, Oct 18, 2014 at 01:43:27PM -0400, Jerry Stralko wrote:
> Signed-off-by: Jerry Stralko <[email protected]>
> ---
> drivers/staging/lustre/lnet/lnet/lib-move.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)

This doesn't apply to my tree at all :(